The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(compression): a prepared summary never covers unpersisted history it cannot vouch for
Teknium3d8fe711ab88
diff --git a/agent/prepared_compaction.py b/agent/prepared_compaction.pyindex 2bec5caccbe..1fe077ea82f 100644--- a/agent/prepared_compaction.py+++ b/agent/prepared_compaction.py@@ -10,10 +10,12 @@ compressor are untouched, so the prompt cache is too.At the next automatic threshold compaction ``compress`` takes the completedsummary if the messages it covers are still the same messages: same session,same head boundary, a boundary no later than the current tail cut, and the same-message structure (roles, tool call and result ids, and the durable-``message_uid`` where both sides carry one) up to that boundary. Message text is-not compared: plugins rewrite text in place, and a summary written before such a-rewrite still summarises the same messages. On a hit the summary replaces+message structure (roles, tool call and result ids) up to that boundary, each+message vouched for by its durable ``message_uid``. The text of a persisted+message is not compared: plugins rewrite text in place, and a summary written+before such a rewrite still summarises the same messages. Only a message that+has no uid on one side (caller-supplied history that is never persisted) is+compared by text, since nothing else can tell it from a different message. On a hit the summary replaces``messages[start:candidate_end]`` and every message after the candidateboundary, however many arrived since the pass started, stays verbatim in thetail. On a miss compaction runs inline exactly as without the flag.@@ -39,6 +41,7 @@ compressor on a splice, as an inline summary would.from __future__ import annotationsimport copy+import hashlibimport loggingimport threadingimport time@@ -70,8 +73,8 @@ _SUMMARY_CALL_TELEMETRY = ("summary_input_sampled_record_count", "summary_input_elided_record_count", "fallback_used", "failure_class",)-# Per message: (structure, durable uid or None).-_Identity = tuple[str, Optional[str]]+# Per message: (structure, durable uid or None, text digest).+_Identity = tuple[str, Optional[str], str]@dataclass(frozen=True)@@ -114,16 +117,22 @@ class _PendingPass:def _message_identity(msg: Any) -> _Identity:- """Role, tool call ids/names and tool result ids, plus the durable ``message_uid`` when the message- has been persisted. Text, tool arguments and result bodies are left out: the no-LLM prune and- plugins rewrite them in place, while the splice only needs whole messages that line up."""+ """Role, tool call ids/names and tool result ids; the durable ``message_uid`` when the message has+ been persisted; and a digest of its text for messages no uid vouches for. Tool arguments and result+ bodies are left out: the no-LLM prune rewrites them in place."""if not isinstance(msg, dict):- return "?", None+ return "?", None, ""+ from agent.memory_manager import sanitize_context+ from agent.message_content import flatten_message_textfrom agent.message_metadata import message_uid_or_nonerole = str(msg.get("role") or "")+ uid = message_uid_or_none(msg)if role == "tool":- return f"tool\x1f{msg.get('tool_call_id') or ''}", message_uid_or_none(msg)+ return f"tool\x1f{msg.get('tool_call_id') or ''}", uid, ""+ # Normalised the way a SessionDB round trip normalises it.+ text = sanitize_context(flatten_message_text(msg.get("content"))).strip()+ digest = hashlib.blake2b(text.encode("utf-8", errors="replace"), digest_size=8).hexdigest()parts = [role]for tc in msg.get("tool_calls") or []:if isinstance(tc, dict):@@ -131,7 +140,7 @@ def _message_identity(msg: Any) -> _Identity:parts.append(f"{tc.get('id', '')}:{fn.get('name', '') if isinstance(fn, dict) else ''}")else:parts.append(f"{getattr(tc, 'id', '')}:{getattr(getattr(tc, 'function', None), 'name', '')}")- return "\x1f".join(parts), message_uid_or_none(msg)+ return "\x1f".join(parts), uid, digestdef prefix_identities(messages: list[dict[str, Any]], end: int) -> tuple[_Identity, ...]:@@ -151,12 +160,15 @@ def _mismatch(return f"prepared boundary {window.compress_end} is inside the protected tail (cut {end})"if window.compress_end > len(messages):return "transcript shorter than the prepared window"- for idx, ((structure, uid), msg) in enumerate(zip(window.identities, messages)):- now_structure, now_uid = _message_identity(msg)+ for idx, ((structure, uid, digest), msg) in enumerate(zip(window.identities, messages)):+ now_structure, now_uid, now_digest = _message_identity(msg)if now_structure != structure:return f"message {idx} changed shape"- if uid and now_uid and uid != now_uid:- return f"message {idx} is a different message (rewound or branched)"+ if uid and now_uid:+ if uid != now_uid:+ return f"message {idx} is a different message (rewound or branched)"+ elif digest != now_digest:+ return f"message {idx} changed and has no durable id to vouch for it"return Nonediff --git a/tests/agent/test_prepared_compaction.py b/tests/agent/test_prepared_compaction.pyindex 788ebd19633..7ae54069454 100644--- a/tests/agent/test_prepared_compaction.py+++ b/tests/agent/test_prepared_compaction.py@@ -279,24 +279,38 @@ def test_in_place_text_rewrite_of_summarised_messages_keeps_the_candidate():assert entry.summary in _summary_row(compressed)["content"][email protected]("change", ["message dropped", "rewound", "head moved", "other session"])+def _drop_pair_and_regrow(cc, live, start):+ # Caller-supplied history is never persisted, so no uid vouches for it; after regrowth the roles+ # still alternate and line up, but the summarized messages are not the same messages.+ del live[start + 1:start + 3]+ live += _messages(2, tag="regrown")[1:]+++def _drop_and_reshape(cc, live, start):+ del live[start + 1:start + 3]+ live[start + 1]["tool_calls"] = [{"id": "c1", "function": {"name": "x"}}]+++_PREFIX_CHANGES = { # name -> (history persisted with uids?, change applied before compaction)+ "message dropped": (True, _drop_and_reshape),+ # A rewind into the window that regrew the same shape: the rows are new messages.+ "rewound": (True, lambda cc, live, start: live[start + 1].update(message_uid="uid-after-rewind")),+ "pair dropped from history without uids": (False, _drop_pair_and_regrow),+ "head moved": (True, lambda cc, live, start: setattr(cc, "compression_count", 1)), # head protection decays+ "other session": (True, lambda cc, live, start: setattr(cc, "_session_id", "S2")),+}++[email protected]("change", list(_PREFIX_CHANGES))def test_changed_prefix_never_splices(change):+ persisted, apply_change = _PREFIX_CHANGES[change]cc = _compressor()msgs = _messages(30)- for i, msg in enumerate(msgs):+ for i, msg in enumerate(msgs if persisted else []):msg["message_uid"] = f"uid-{i}"entry = _prepare(cc, msgs)live = copy.deepcopy(msgs)- if change == "message dropped":- del live[entry.compress_start + 1:entry.compress_start + 3] # roles still alternate; positions shift- live[entry.compress_start + 1]["tool_calls"] = [{"id": "c1", "function": {"name": "x"}}]- elif change == "rewound":- # A rewind into the window that regrew the same shape: the rows are new messages.- live[entry.compress_start + 1]["message_uid"] = "uid-after-rewind"- elif change == "head moved":- cc.compression_count = 1 # head protection decays after a compaction- else:- cc._session_id = "S2"+ apply_change(cc, live, entry.compress_start)compressed = cc.compress(live, current_tokens=cc.threshold_tokens + 1)assert [c["worker"] for c in cc.calls] == [True, False], "inline summary expected"assert "Summary v2" in _summary_row(compressed)["content"]diff --git a/website/docs/developer-guide/context-compression-and-caching.md b/website/docs/developer-guide/context-compression-and-caching.mdindex b346d1651fa..ffd1820ef2b 100644--- a/website/docs/developer-guide/context-compression-and-caching.md+++ b/website/docs/developer-guide/context-compression-and-caching.md@@ -686,9 +686,11 @@ per compaction: while a summary is held, no further pass starts, however much thAt the next automatic threshold compaction `compress()` splices the completed summary when it stillcovers the same messages: same session, unchanged head boundary, a candidate boundary no later thanthe fresh tail cut, and the same message structure up to that boundary (role, tool call ids and-names, tool result ids, and the durable `message_uid` where both sides carry one). Message text,-tool arguments and tool bodies are not compared: the no-LLM prune and plugins rewrite them in place,-and the summary still describes the same messages. A dropped or inserted message, or a rewind or+names, tool result ids), each message vouched for by its durable `message_uid`. The text of a+persisted message, tool arguments and tool bodies are not compared: the no-LLM prune and plugins+rewrite them in place, and the summary still describes the same messages. A message without a uid on+one side (caller-supplied `conversation_history` that is never persisted) is compared by text, since+nothing else can tell it from a different message. A dropped or inserted message, or a rewind orbranch into the window (new `message_uid`s), is a miss. The summary then covers`[head, candidate boundary)` and every later message, however many arrived after the pass started, iskept as tail; tail rules such as lean-mode tool stubbing still apply to them. Summary placement and