The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(gateway): room allow_silence reads top-level platform blocks and fails safe
kshitijk4poor71981bd1fda6
diff --git a/gateway/run_config_loaders.py b/gateway/run_config_loaders.pyindex 9a3995e7640..1e12bb0c536 100644--- a/gateway/run_config_loaders.py+++ b/gateway/run_config_loaders.py@@ -118,16 +118,33 @@ class GatewayConfigLoadersMixin:def _room_allow_silence(self, source: SessionSource) -> Optional[bool]:"""Resolve the room policy in the serving profile, never the launch snapshot for a route."""from gateway.config import GatewayConfig+ from gateway.config_loader import merge_platform_sections, platform_sectionfrom gateway.run import _get_channel_override, _load_gateway_configfrom gateway.session_identity import identity_ofconfig = getattr(self, "config", None)- if (identity_of(source) is not None or source.profile- or getattr(config, "multiplex_profiles", False) or config is None):- home = self._resolve_profile_home_for_source(source)- config = GatewayConfig.from_dict(_load_gateway_config(home / "config.yaml"))- override = _get_channel_override(- config, source.platform, source.chat_id,- thread_id=source.thread_id, parent_id=source.parent_chat_id)+ try:+ if (identity_of(source) is not None or source.profile+ or getattr(config, "multiplex_profiles", False) or config is None):+ raw = _load_gateway_config(self._resolve_profile_home_for_source(source) / "config.yaml")+ # The loader's own two steps: merge every nested platform block, then the overrides of+ # the block platform_section picks (a top-level ``<platform>:`` block first) win.+ # ``GatewayConfig.from_dict(raw)`` alone reads only the nested ``platforms`` form.+ name, gateway_section = source.platform.value, raw.get("gateway")+ overrides = (merge_platform_sections(raw, gateway_section, {}).get(name) or {}).get("channel_overrides")+ section, _ = platform_section(raw, name, (+ gateway_section.get("platforms") if isinstance(gateway_section, dict) else None))+ if isinstance(section, dict) and isinstance(section.get("channel_overrides"), dict):+ overrides = section["channel_overrides"]+ config = GatewayConfig.from_dict({"platforms": {name: {+ "channel_overrides": overrides if isinstance(overrides, dict) else {}}}})+ override = _get_channel_override(+ config, source.platform, source.chat_id,+ thread_id=source.thread_id, parent_id=source.parent_chat_id)+ except Exception:+ # No permission means the default reply rule; a lookup failure must not become an error reply.+ logger.warning("Room allow_silence lookup failed for %s; keeping the reply rule",+ source.chat_id, exc_info=True)+ return Nonereturn override.allow_silence if override is not None else Nonedef _resolve_model_for_channel(diff --git a/tests/gateway/test_room_allow_silence.py b/tests/gateway/test_room_allow_silence.pyindex 194aacb8692..6d11614b8a0 100644--- a/tests/gateway/test_room_allow_silence.py+++ b/tests/gateway/test_room_allow_silence.py@@ -231,3 +231,37 @@ async def test_recovery_keeps_guard_without_exact_completed_decision(tmp_path, massert sweep_recoverable(deliverable_platforms={"telegram"})finally:_close_store_db(store)++[email protected]("raw,expected", [+ ({"platforms": {"telegram": {"channel_overrides": {"-1001": {"allow_silence": True}}}}}, True),+ ({"telegram": {"channel_overrides": {"-1001": {"allow_silence": True}}}}, True),+ ({"telegram": {"channel_overrides": {"-1001": {"allow_silence": False}}},+ "platforms": {"telegram": {"channel_overrides": {"-1001": {"allow_silence": True}}}}}, False),+ ({"telegram": {"require_mention": True},+ "platforms": {"telegram": {"channel_overrides": {"-1001": {"allow_silence": True}}}}}, True),+], ids=["nested", "top-level", "top-level-wins", "top-level-without-overrides"])+def test_served_profile_lookup_reads_every_platform_block_layout(monkeypatch, tmp_path, raw, expected):+ runner = _runner(monkeypatch, tmp_path)+ home = tmp_path / "served"+ home.mkdir()+ (home / "config.yaml").write_text(json.dumps(raw), encoding="utf-8")+ source = _source()+ source._identity = RoutingIdentity("default", "served", tmp_path, home)++ assert runner._room_allow_silence(source) is expected+++def test_failed_room_lookup_keeps_the_reply_rule(monkeypatch, tmp_path):+ from gateway.profile_routing import ProfileRouteRejected+ runner = _runner(monkeypatch, tmp_path)+ source = _source()+ source.profile = "gone"++ def _reject(_source):+ raise ProfileRouteRejected("gone")++ monkeypatch.setattr(runner, "_resolve_profile_home_for_source", _reject)++ assert runner._room_allow_silence(source) is None+ assert runner._silence_allowed_for_source(source, None, True, {"final_response": "NO_REPLY"}) is False