The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
ci(process): the detached-spawn ratchet fails closed, needs a reason on every marker, and says what it misses
kshitijk4poor782c0f847cd3
diff --git a/hermes_cli/process_identity.py b/hermes_cli/process_identity.pyindex 34a5001f32c..d23c157bbce 100644--- a/hermes_cli/process_identity.py+++ b/hermes_cli/process_identity.py@@ -841,8 +841,8 @@ def attach_self_to_kill_on_close_job() -> bool:# the spawn ledger. Children something else spawns (the MCP SDK, a daemon's own Chromium) hand their# group to ``own_process_groups`` where we learn the pgid; a descendant that leaves the group on# purpose is registered by its own pgid the same way. Stopping an owned child yourself ends with-# ``release_process_groups``. ``scripts/check_detached_spawns.py`` keeps new detached spawns-# (start_new_session / setsid / setpgid) from bypassing this. POSIX-only: Windows children die+# ``release_process_groups``. ``scripts/check_detached_spawns.py`` flags new detached spawns+# (start_new_session / process_group / setsid / setpgid; its docstring lists what it misses). POSIX-only: Windows children die# through the layer-3 job object instead._supervisor = None # Optional[subprocess.Popen]; tests rebind itdiff --git a/scripts/check_detached_spawns.py b/scripts/check_detached_spawns.pyindex fe5090d1e34..bf5f0642147 100644--- a/scripts/check_detached_spawns.py+++ b/scripts/check_detached_spawns.py@@ -18,11 +18,17 @@ Flags, in Python files of the production trees (tests, evals, scripts and nix chany reference to os.setsid / os.setpgid / os.setpgrp (call or ``preexec_fn=os.setsid``)a call to ``windows_detach_popen_kwargs()`` (``start_new_session=True`` on POSIX)+Not caught: a PTY spawn (``pty.fork``, ``ptyprocess.PtyProcess.spawn``, which always start a new+session), aliased imports (``from os import setsid``, ``import os as _os``), ``os.posix_spawn(...,+setsid=True)`` and ``kw.setdefault("start_new_session", True)``. None is used to start a long-lived+child in production today; a review still has to catch a new one.+Opt out of one line with ``detached-spawn: ok — <why>`` on that line or the line directly above-it. Legitimate reasons are the ones that stay valid after the owner dies: the child must OUTLIVE-its owner on purpose (an updater relaunching the gateway, a restart watcher, a detached service-launch), or the child is short-lived and awaited with a hard timeout that kills its group (the-group exists only so that kill reaches grandchildren).+it; a marker without a reason after the dash does not count. Legitimate reasons: the child must+OUTLIVE its owner on purpose (an updater relaunching the gateway, a restart watcher, a detached+service launch), or the child is awaited with a hard timeout that kills its group (the group+exists only so that kill reaches grandchildren). That timeout runs in the owner, so an owner killed+mid-wait leaves such a child to finish on its own: mark it only when that worst case is acceptable.``_BASELINE`` maps a file to a tolerated count of unmarked hits. It is empty: every detachedspawn site is on ``spawn_owned`` or marked with its reason. Keep it that way; an entry is a@@ -35,6 +41,7 @@ from __future__ import annotationsimport argparseimport ast+import reimport subprocessimport sysfrom pathlib import Path@@ -101,18 +108,23 @@ def detach_lines(text: str) -> list[int]:return sorted(lines)+# The marker counts only with a reason: ``detached-spawn: ok — <why>`` (an em dash or hyphens).+_MARKED = re.compile(re.escape(MARKER) + r"\s*(?:—|-+)\s*\S")++def _marked(src_lines: list[str], lineno: int) -> bool:here = src_lines[lineno - 1] if lineno - 1 < len(src_lines) else ""above = src_lines[lineno - 2] if lineno >= 2 else ""- return MARKER in here or MARKER in above+ return bool(_MARKED.search(here) or _MARKED.search(above))def _tracked_files(root: Path) -> list[Path]:try:out = subprocess.run(["git", "-C", str(root), "ls-files", "-z", "--", *SCAN_TREES, *SCAN_ROOT_FILES],capture_output=True, text=True, check=True, stdin=subprocess.DEVNULL, timeout=60).stdout- except (OSError, subprocess.SubprocessError):- return []+ except (OSError, subprocess.SubprocessError) as exc:+ # Fail closed: scanning nothing would report "no detached spawns".+ raise RuntimeError(f"cannot list the tracked files under {root}: {exc}") from excreturn [root / rel for rel in out.split("\0") if rel.endswith(".py")]@@ -163,7 +175,11 @@ def main(argv: list[str] | None = None) -> int:ap.add_argument("--strict-baseline", action="store_true", help="also fail when _BASELINE overstates a file")args = ap.parse_args(argv)- hits = scan(args.paths or None)+ try:+ hits = scan(args.paths or None)+ except RuntimeError as exc:+ print(f"check_detached_spawns: {exc}", file=sys.stderr)+ return 2if args.print_baseline:print(_format_baseline(hits))return 0diff --git a/tests/scripts/test_check_detached_spawns.py b/tests/scripts/test_check_detached_spawns.pyindex 0b44aea359a..ba88613817e 100644--- a/tests/scripts/test_check_detached_spawns.py+++ b/tests/scripts/test_check_detached_spawns.py@@ -96,3 +96,23 @@ def test_the_repository_has_no_unmarked_detached_spawn():mod = _load()assert mod.scan() == {}, "a detached spawn outside spawn_owned lacks a `detached-spawn: ok — <why>` marker"assert mod._BASELINE == {}+++def test_a_marker_without_a_reason_does_not_opt_out(tmp_path):+ mod = _load()+ f = tmp_path / "tools" / "x.py"+ f.parent.mkdir()+ f.write_text(textwrap.dedent("""\+ subprocess.Popen(a, start_new_session=True) # detached-spawn: ok+ subprocess.Popen(b, start_new_session=True) # detached-spawn: ok —+ subprocess.Popen(c, start_new_session=True) # detached-spawn: ok - restart watcher, outlives us+ """), encoding="utf-8")+ assert [n for n, _ in mod.scan([f], root=tmp_path)["tools/x.py"]] == [1, 2]+++def test_a_tree_git_cannot_list_fails_closed(tmp_path, monkeypatch, capsys):+ """No git (or not a checkout) used to scan zero files and report the tree clean."""+ mod = _load()+ monkeypatch.setattr(mod, "ROOT", tmp_path) # not a git checkout+ assert mod.main([]) == 2+ assert "cannot list the tracked files" in capsys.readouterr().err