Skip to content

The agent that grows with you

test(desktop): drop New Bot cancel tests that pass without the fix

Teknium97ad7d12fb29
diff --git a/apps/desktop/src/plugins/hermes-bots/create-agent-lazy-profile.test.tsx b/apps/desktop/src/plugins/hermes-bots/create-agent-lazy-profile.test.tsx
index 0f11df8326e..6cabb205771 100644
--- a/apps/desktop/src/plugins/hermes-bots/create-agent-lazy-profile.test.tsx
+++ b/apps/desktop/src/plugins/hermes-bots/create-agent-lazy-profile.test.tsx
@@ -313,20 +313,10 @@ describe('materializing the draft profile', () => {
})
// #141623: the draft profile is minted before the dialog finishes. Cancelling
-// must delete the draft THIS dialog created, including one whose profiles.create
-// is still in flight when the user backs out — it used to survive as a bot.
+// must delete the draft THIS dialog created, on the machine it created it on,
+// including one whose create or configure is still in flight when the user
+// backs out — it used to survive as a bot.
describe('cancelling New Bot discards its draft profile', () => {
- it('deletes a draft that already exists', async () => {
- await renderDialog(true)
- fireEvent.click(screen.getByRole('button', { name: 'Capabilities' }))
- await waitFor(() => expect(mocks.skillsView.at(-1)).toMatchObject({ fixedProfile: 'inbox-triage' }))
-
- fireEvent.click(screen.getByRole('button', { name: 'Cancel' }))
-
- await waitFor(() => expect(mocks.deleteBot).toHaveBeenCalledWith({ name: 'inbox-triage' }))
- expect(mocks.createCanonicalChat).not.toHaveBeenCalled()
- })
-
it('deletes the draft whose profiles.create was still in flight at cancel', async () => {
const base = mocks.request.getMockImplementation()!
let finishCreate!: () => void
@@ -434,16 +424,6 @@ describe('cancelling New Bot discards its draft profile', () => {
expect(mocks.saveBotMeta).not.toHaveBeenCalled()
})
-
- it('never deletes a bot the dialog finished creating', async () => {
- await renderDialog(true)
- fireEvent.click(screen.getByRole('button', { name: 'Create Bot' }))
- await waitFor(() => expect(mocks.createCanonicalChat).toHaveBeenCalledWith('inbox-triage', { kickoff: true }))
-
- // Reopened and cancelled without touching anything: nothing to discard.
- fireEvent.click(screen.getByRole('button', { name: 'Cancel' }))
- expect(mocks.deleteBot).not.toHaveBeenCalled()
- })
})
describe('provider readiness before the intro turn', () => {