Skip to content

The agent that grows with you

test(browser): the v52 migration tests compare the reached version with DEFAULT_CONFIG, not 52

Teknium99103c578686
diff --git a/tests/hermes_cli/test_config_migration_52_browser.py b/tests/hermes_cli/test_config_migration_52_browser.py
index 8d130baa583..b0883b8533f 100644
--- a/tests/hermes_cli/test_config_migration_52_browser.py
+++ b/tests/hermes_cli/test_config_migration_52_browser.py
@@ -8,6 +8,7 @@ default core let the env override.
import hermes_yaml as yaml
import pytest
+from hermes_cli.config_defaults import DEFAULT_CONFIG
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
_AB_ENV = ("AGENT_BROWSER_EXECUTABLE_PATH", "AGENT_BROWSER_PROFILE", "AGENT_BROWSER_ARGS",
@@ -47,9 +48,9 @@ def test_backend_off_is_dropped_with_a_notice(tmp_path, monkeypatch, capsys):
_migrate(home)
out = capsys.readouterr().out
assert _raw(home)["browser"] == {"inactivity_timeout": 60}
- assert _raw(home)["_config_version"] == 52
+ assert _raw(home)["_config_version"] == DEFAULT_CONFIG["_config_version"]
assert "browser_exec is the browser now" in out and "`browser` toolset in `hermes tools`" in out
- # Once: a second pass at v52 has nothing left to say.
+ # Once: a second pass has nothing left to say.
_migrate(home)
assert "browser_exec" not in capsys.readouterr().out
@@ -88,7 +89,7 @@ def test_boot_migration_shows_the_off_notice_at_the_first_agent_start_once(tmp_p
monkeypatch.delenv("CAMOFOX_URL", raising=False)
home = _home(tmp_path / "a", {"_config_version": 51, "browser": {"backend": "off"}})
said = _boot_agents(home, monkeypatch, starts=2)
- assert _raw(home)["_config_version"] == 52
+ assert _raw(home)["_config_version"] == DEFAULT_CONFIG["_config_version"]
assert len(said) == 1
assert "browser_exec is the browser now" in said[0] and "`browser` toolset in `hermes tools`" in said[0]
assert _boot_agents(home, monkeypatch, starts=1) == []
diff --git a/tests/hermes_cli/test_left_core_camofox.py b/tests/hermes_cli/test_left_core_camofox.py
index 2737417896e..6ecc0eafd9b 100644
--- a/tests/hermes_cli/test_left_core_camofox.py
+++ b/tests/hermes_cli/test_left_core_camofox.py
@@ -13,6 +13,7 @@ import pytest
import hermes_cli.left_core_migration as lcm
import hermes_yaml as yaml
+from hermes_cli.config_defaults import DEFAULT_CONFIG
_CATALOG_ENTRY = """\
name: camofox
@@ -250,7 +251,7 @@ def test_upgrade_converts_after_the_config_step(tmp_path, monkeypatch):
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "launch"))
home = _home(tmp_path, env=_SPLIT_ENV, config={"_config_version": 51, "platform_toolsets": _SPLIT_TOOLSETS})
_migrate_config(home)
- assert _config(home)["_config_version"] == 52
+ assert _config(home)["_config_version"] == DEFAULT_CONFIG["_config_version"]
calls = []
assert lcm.migrate_home(home, install=_installer(home, calls), say=lambda _m: None) == ["camofox"]
config = _config(home)
@@ -290,7 +291,6 @@ def test_the_config_yaml_an_env_only_conversion_creates_is_stamped(tmp_path, mon
import logging
from hermes_cli import post_update
- from hermes_cli.config_defaults import DEFAULT_CONFIG
home = _home(tmp_path, env=_SPLIT_ENV)
assert _boot(home, monkeypatch) == ["camofox"]
@@ -319,7 +319,7 @@ def test_a_plain_save_stamping_an_unversioned_camofox_home_keeps_its_conversion(
save_config(load_config())
finally:
reset_hermes_home_override(token)
- assert _config(home)["_config_version"] == 52
+ assert _config(home)["_config_version"] == DEFAULT_CONFIG["_config_version"]
calls = []
assert lcm.migrate_home(home, install=_installer(home, calls), say=lambda _m: None) == ["camofox"]
assert _config(home)["platform_toolsets"]["cli"] == ["terminal", "file", "camofox"]