Skip to content

The agent that grows with you

fix(delegation): an unavailable replacement default falls back to the bundled strategy

Tekniuma062fa74b2de
diff --git a/agent/delegation_registry.py b/agent/delegation_registry.py
index 12cc9294abd..3ca3b9258ef 100644
--- a/agent/delegation_registry.py
+++ b/agent/delegation_registry.py
@@ -82,17 +82,28 @@ def _load_bundled(name: str) -> Optional[DelegationProvider]:
return _first_use.get(name)
+def _available(provider: Optional[DelegationProvider]) -> bool:
+ return provider is not None and is_available_safe(
+ provider, logger, "delegation provider %s.is_available() raised %s")
+
+
def _usable(name: str) -> Optional[DelegationProvider]:
- """The registered, available provider for ``name``: registry, else a bundled strategy of that
- name, else one plugin discovery sweep (a caller that never imported ``model_tools``)."""
- provider = _registry.get_provider(name) or _load_bundled(name)
- if provider is None:
+ """The available provider for ``name``: the registered one, else a bundled strategy of that name
+ (also when the registered one reports unavailable), else one plugin discovery sweep (a caller
+ that never imported ``model_tools``)."""
+ registered = _registry.get_provider(name)
+ if _available(registered):
+ return registered
+ bundled = _load_bundled(name)
+ if _available(bundled):
+ return bundled
+ if registered is None and bundled is None:
from hermes_cli.plugins import discover_plugins
discover_plugins()
- provider = _registry.get_provider(name)
- if provider is None or not is_available_safe(provider, logger, "delegation provider %s.is_available() raised %s"):
- return None
- return provider
+ registered = _registry.get_provider(name)
+ if _available(registered):
+ return registered
+ return None
def backend_status(name: str) -> tuple[Optional[DelegationProvider], str]:
diff --git a/tests/tools/test_delegation_backends.py b/tests/tools/test_delegation_backends.py
index e9035dcd91f..7677d8525b8 100644
--- a/tests/tools/test_delegation_backends.py
+++ b/tests/tools/test_delegation_backends.py
@@ -501,3 +501,37 @@ def test_a_replacement_default_strategy_gets_the_full_route_contract(monkeypatch
(route,), error = resolve_task_routes([{"goal": "one plain delegated task"}], {}, _parent())
assert error is None and route.label == "codex-fast"
assert route.creds["service_tier"] == "priority" and route.creds["request_overrides"]["service_tier"] == "priority"
+
+
+def test_an_unavailable_replacement_default_falls_back_to_the_bundled_strategy(monkeypatch):
+ """A provider registered as ``default`` that reports unavailable never takes delegation down: the enabled
+ bundled default strategy serves the task instead."""
+ from agent import delegation_registry
+ from agent.delegation_provider import DelegationProvider
+ from agent.delegation_registry import _registry, get_active_provider
+
+ class Unavailable(DelegationProvider):
+ @property
+ def name(self):
+ return "default"
+
+ def is_available(self):
+ return False
+
+ def route_task(self, task, config):
+ raise AssertionError("an unavailable provider is never asked for a route")
+
+ monkeypatch.setattr(delegation_registry, "_first_use", {})
+ previous = _registry.snapshot_registration("default")
+ if previous is not None:
+ _registry.restore_registration("default", previous, None)
+ _registry.register(Unavailable())
+ try:
+ provider = get_active_provider({})
+ assert provider is not None and provider.is_available()
+ assert provider.route_task({"goal": "g", "index": 0}, {"model": "m"}) == {"model": "m"}
+ finally:
+ current = _registry.snapshot_registration("default")
+ if current is not None:
+ _registry.restore_registration("default", current, previous)
+