The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
test(webapp): browser notifications never prompt from an event and open the session on click
Tekniuma10fda2340bc
diff --git a/apps/desktop/src/lib/browser-notifications.test.ts b/apps/desktop/src/lib/browser-notifications.test.tsnew file mode 100644index 00000000000..3077027a43b--- /dev/null+++ b/apps/desktop/src/lib/browser-notifications.test.ts@@ -0,0 +1,52 @@+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'++import { onBrowserFocusSession, showBrowserNotification } from './browser-notifications'++const created: { onclick: (() => void) | null; title: string }[] = []++class FakeNotification {+ static permission: NotificationPermission = 'default'+ static requestPermission = vi.fn(async () => FakeNotification.permission)+ onclick: (() => void) | null = null+ constructor(public title: string) {+ created.push(this)+ }+ close() {}+}++describe('showBrowserNotification', () => {+ beforeEach(() => {+ created.length = 0+ FakeNotification.requestPermission.mockClear()+ vi.stubGlobal('Notification', FakeNotification)+ vi.stubGlobal('isSecureContext', true)+ })++ afterEach(() => {+ vi.unstubAllGlobals()+ })++ it('never asks for permission from an event (only a click in Settings may)', () => {+ FakeNotification.permission = 'default'++ expect(showBrowserNotification({ kind: 'approval', sessionId: 's1', title: 'Approval needed' })).toBe(false)+ expect(FakeNotification.requestPermission).not.toHaveBeenCalled()+ expect(created).toHaveLength(0)+ })++ it('opens the notified session through onFocusSession when clicked', () => {+ FakeNotification.permission = 'granted'+ const opened: string[] = []+ const off = onBrowserFocusSession(id => opened.push(id))+ const focus = vi.spyOn(window, 'focus').mockImplementation(() => undefined)++ expect(+ showBrowserNotification({ focusSessionId: 'stored-1', kind: 'approval', sessionId: 'rt-1', title: 'Approval needed' })+ ).toBe(true)+ created[0].onclick?.()++ expect(focus).toHaveBeenCalled()+ expect(opened).toEqual(['stored-1'])+ off()+ })+})