The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(desktop): a click outside a narrow native window's sidebar overlay reaches the app again
emozillaa1e27754d31e
diff --git a/apps/desktop/DESIGN.md b/apps/desktop/DESIGN.mdindex 80acbd115b1..d8d827accac 100644--- a/apps/desktop/DESIGN.md+++ b/apps/desktop/DESIGN.md@@ -277,8 +277,10 @@ The voice engine split-button uses `--composer-voice-menu-size`: compact ondesktop, matching `--composer-control-size` on touch surfaces.Narrow browser touch layouts show the current session tab with an open-tabcount. Its menu exposes every tab, while the new-tab action remains beside it.-Outside taps dismiss narrow sidebar overlays; cancelled or scrolling gestures-do not. Touch transcript gestures select a pane without focusing its composer.+In the browser-hosted Desktop, outside taps dismiss narrow sidebar overlays;+cancelled or scrolling gestures do not. Native Desktop keeps its overlay until+Escape, the toggle or hover-out. Touch transcript gestures select a pane without+focusing its composer.- **Gutters:** `PAGE_INSET_X` (`src/app/layout-constants.ts`) for page sidepadding; `PAGE_INSET_NEG_X` to bleed a child to the edge. Don't hardcodediff --git a/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.test.tsx b/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.test.tsxindex 547cbb372d4..48283bc7a3e 100644--- a/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.test.tsx+++ b/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.test.tsx@@ -74,8 +74,33 @@ const revealPane = (id: string) => {const overlayTab = (paneId: string) => document.querySelector<HTMLElement>(`[data-narrow-overlay-tab="${paneId}"]`)+// The page the browser-hosted Desktop serves (its bridge writes this marker).+const asBrowserHost = () => {+ window.document.documentElement.dataset.hermesDesktopHost = 'browser'+}++// Native Desktop: the Electron preload's bridge exists and no browser marker is set.+const asNativeDesktop = () => {+ ;(window as unknown as { hermesDesktop?: unknown }).hermesDesktop = {}+}++describe('narrow overlay in native Desktop', () => {+ // A narrow native window keeps main's overlay: no full-window backdrop, so a+ // click outside a pinned overlay reaches the app under it and the overlay+ // stays open until Escape, the toggle or the edge hover closes it.+ it('puts no outside-click backdrop over the app and keeps a pinned overlay open', () => {+ asNativeDesktop()+ render(<NarrowOverlays />)+ revealPane('sessions')++ expect(globalThis.document.querySelector('[data-narrow-overlay-backdrop]')).toBeNull()+ expect(globalThis.document.querySelector('[data-narrow-overlay="sessions"]')).not.toBeNull()+ })+})+describe('narrow overlay of a stacked zone', () => {it('dismisses an outside tap while preserving inside controls and cancelled gestures', () => {+ asBrowserHost()render(<NarrowOverlays />)revealPane('sessions')fireEvent.pointerDown(overlayTab('bots')!, { button: 0 })diff --git a/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.tsx b/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.tsxindex db284cab942..638853ac01d 100644--- a/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.tsx+++ b/apps/desktop/src/components/pane-shell/tree/renderer/narrow-overlays.tsx@@ -204,7 +204,10 @@ export function NarrowOverlays() {return (<>- {revealed && (+ {/* A touch screen has no hover to leave the overlay by, so the browser+ host closes it on a tap outside. Native Desktop lets that click reach+ the app and keeps the overlay until Escape, the toggle or hover-out. */}+ {revealed && isBrowserHostedDesktop() && (<divaria-hidden="true"className="absolute inset-0 z-30"