Skip to content

The agent that grows with you

fix(contracts): admit model_override.reasoning on prompt.submit

Tekniumb0bb0d874992
diff --git a/apps/shared/src/gateway-contract.generated.ts b/apps/shared/src/gateway-contract.generated.ts
index 89e4f176f1c..694f858734d 100644
--- a/apps/shared/src/gateway-contract.generated.ts
+++ b/apps/shared/src/gateway-contract.generated.ts
@@ -5119,6 +5119,7 @@ export interface CanonicalTurnAuthor {
export interface CanonicalModelOverride {
model: string
provider?: string | null
+ reasoning?: string | null
}
export interface CanonicalApprovalParams {
profile?: string | null
diff --git a/apps/shared/src/gateway-contract.openrpc.json b/apps/shared/src/gateway-contract.openrpc.json
index bfaccd5abb6..8a43b5b3c1c 100644
--- a/apps/shared/src/gateway-contract.openrpc.json
+++ b/apps/shared/src/gateway-contract.openrpc.json
@@ -9053,6 +9053,18 @@
],
"default": null,
"title": "Provider"
+ },
+ "reasoning": {
+ "anyOf": [
+ {
+ "type": "string"
+ },
+ {
+ "type": "null"
+ }
+ ],
+ "default": null,
+ "title": "Reasoning"
}
},
"required": [
diff --git a/tests/hermes_cli/test_cli_gateway_model_scope.py b/tests/hermes_cli/test_cli_gateway_model_scope.py
index d56d90056bb..41eb7de0b4d 100644
--- a/tests/hermes_cli/test_cli_gateway_model_scope.py
+++ b/tests/hermes_cli/test_cli_gateway_model_scope.py
@@ -402,3 +402,36 @@ def test_a_session_reasoning_pick_is_committed_once_not_on_every_rebuild(monkeyp
assert stub.chat("second") == "ok"
assert _reasoning_mutates(conn) == [{"effort": "high"}]
assert stub._reasoning_user_set is False
+
+
[email protected]("override", [
+ {"model": "first", "reasoning": "high"},
+ {"model": "claude-sonnet-4.6", "provider": "anthropic", "reasoning": "high"},
+])
+def test_once_reasoning_admission_passes_the_real_submit_contract(monkeypatch, override):
+ """Live pass on #140969: ``/model first --once --reasoning high`` failed its turn ``invalid_params``.
+ The CLI sends ``model_override.reasoning`` but ``CanonicalModelOverride`` forbade the key, and the
+ owner's dispatcher (``canonical_param_problems``) refuses an unknown key before the handler runs.
+ The recorded submit goes through that same production check, not a stubbed connection."""
+ from tui_gateway.contracts.registry import CANONICAL_METHODS, canonical_param_problems
+ contract = CANONICAL_METHODS["prompt.submit"]
+ params = {"session_id": "s", "text": "t", "submission_id": "x", "model_override": override}
+ assert canonical_param_problems(contract, params) == []
+ assert contract.params.model_validate(params).model_override.reasoning == "high"
+
+ conn = RecordingConnection({"model": "old/model", "provider": "openrouter"})
+ cli_mod, stub, _printed = _chat_cli(monkeypatch, conn)
+ stub._confirm_and_apply_cli_model_switch = cli_mod.HermesCLI._confirm_and_apply_cli_model_switch.__get__(stub)
+ cli_mod.HermesCLI._handle_model_switch(stub, "/model claude-sonnet-4.6 --provider anthropic --once --reasoning high")
+ assert stub.chat("the once turn") == "ok"
+ (submit,) = _submits(conn)
+ assert submit["model_override"].get("reasoning") == "high", submit
+ assert canonical_param_problems(contract, submit) == [], submit
+
+
+def test_every_model_override_key_the_cli_sends_is_in_the_contract():
+ """``GatewayAgent._take_turn_route`` and the ``/moa`` one-shot build ``model_override`` from
+ ``_route_off_session`` (``model``/``provider``) plus ``reasoning``: each key must be declared."""
+ from tui_gateway.contracts.canonical_sessions import CanonicalModelOverride
+ assert {"model", "provider", "reasoning"} <= set(CanonicalModelOverride.model_fields)
+
diff --git a/tui_gateway/contracts/canonical_sessions.py b/tui_gateway/contracts/canonical_sessions.py
index 3f49293e79e..1542b9d478e 100644
--- a/tui_gateway/contracts/canonical_sessions.py
+++ b/tui_gateway/contracts/canonical_sessions.py
@@ -191,6 +191,9 @@ class CanonicalTurnAuthor(Params):
class CanonicalModelOverride(Params):
model: str
provider: str | None = None
+ # ``/model B --once --reasoning X``: this admission alone runs level X. The owner refuses a level
+ # ``parse_reasoning_effort`` cannot read (``gateway/session_cli_turn.py``).
+ reasoning: str | None = None
class CanonicalSubmitParams(CanonicalSessionParams):