The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
perf(webapp): a browser journal read scans localStorage once
unsupportedpastelsbe7cb86be25d
diff --git a/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.test.ts b/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.test.tsindex 69ddea5838d..e781e9956c4 100644--- a/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.test.ts+++ b/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.test.ts@@ -24,6 +24,21 @@ test('image recovery never offers expanded slash intent as an ordinary draft andexpect((await readPreparedSubmission(slash))?.text).toBe('expanded skill instructions')})+test('a browser journal read lists the storage keys once, however many stores it reads', async () => {+ vi.stubGlobal('hermesDesktop', undefined)+ const owner = { connectionId: 'local', profile: 'default' }++ for (const id of ['a', 'b', 'c']) {+ await writePreparedSubmission(id, { id, text: id, attachments: [], params: {}, owner })+ }++ await removePreparedSubmission('c', 'c')+ const key = vi.spyOn(window.localStorage, 'key')+ expect((await readPreparedSubmission('a'))?.text).toBe('a')+ expect(await readPreparedSubmission('c')).toBeUndefined()+ expect(key).toHaveBeenCalledTimes(2 * window.localStorage.length)+})+test('native preparation waits for acknowledgement and never downgrades a write failure to browser storage', async () => {let ack!: () => voidconst gate = new Promise<void>(resolve => { ack = resolve })diff --git a/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.ts b/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.tsindex 707fa9911e6..df87a434587 100644--- a/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.ts+++ b/apps/desktop/src/app/session/hooks/use-prompt-actions/prepared-submissions.ts@@ -49,22 +49,27 @@ function readLegacySpent(): Record<string, string> {return parsed && typeof parsed === 'object' && !Array.isArray(parsed) ? parsed as Record<string, string> : {}}-// Every value stored under a key starting with `prefix`, by the rest of that key.-function readPrefixed(prefix: string): Record<string, string> {- const values: Record<string, string> = {}+const PREFIXES = [SPENT_PREFIX, LEGACY_RETIRED_PREFIX, ENTRY_PREFIX] as const+type Prefixed = Record<(typeof PREFIXES)[number], Record<string, string>>++// Every value stored under a key starting with one of the prefixes, by prefix and then by the+// rest of that key, in one pass over localStorage.+function readPrefixed(): Prefixed {+ const values = Object.fromEntries(PREFIXES.map(prefix => [prefix, {}])) as Prefixedfor (let index = 0; index < window.localStorage.length; index += 1) {const key = window.localStorage.key(index)- const value = key?.startsWith(prefix) ? window.localStorage.getItem(key) : null+ const prefix = PREFIXES.find(candidate => key?.startsWith(candidate))+ const value = key && prefix ? window.localStorage.getItem(key) : null- if (key && value) { values[key.slice(prefix.length)] = value }+ if (key && prefix && value) { values[prefix][key.slice(prefix.length)] = value }}return values}-function readSpent(): Record<string, string> {- return { ...readLegacySpent(), ...readPrefixed(SPENT_PREFIX), ...Object.fromEntries(retired) }+function readSpent(prefixed: Prefixed): Record<string, string> {+ return { ...readLegacySpent(), ...prefixed[SPENT_PREFIX], ...Object.fromEntries(retired) }}function writeSpent(key: string, id: string | undefined): void {@@ -98,9 +103,10 @@ async function readJournal(): Promise<Record<string, PreparedSubmission>> {}const stored = parsed as Record<string, PreparedSubmission>- const journal = native ? stored : readBrowserJournal(stored)+ const prefixed = readPrefixed()+ const journal = native ? stored : readBrowserJournal(stored, prefixed)- for (const [key, id] of Object.entries(readSpent())) {+ for (const [key, id] of Object.entries(readSpent(prefixed))) {if (journal[key]?.id === id) {delete journal[key]// Storage may have recovered since: finish the retirement so the stale entry stops lingering.@@ -116,12 +122,12 @@ async function readJournal(): Promise<Record<string, PreparedSubmission>> {}// The entries under their own keys, over the legacy blob's entries not yet retired.-function readBrowserJournal(legacy: Record<string, PreparedSubmission>): Record<string, PreparedSubmission> {- for (const [key, id] of Object.entries(readPrefixed(LEGACY_RETIRED_PREFIX))) {+function readBrowserJournal(legacy: Record<string, PreparedSubmission>, prefixed: Prefixed): Record<string, PreparedSubmission> {+ for (const [key, id] of Object.entries(prefixed[LEGACY_RETIRED_PREFIX])) {if (legacy[key]?.id === id) { delete legacy[key] }}- const entries = Object.entries(readPrefixed(ENTRY_PREFIX)).map(([key, entry]) => [key, JSON.parse(entry)])+ const entries = Object.entries(prefixed[ENTRY_PREFIX]).map(([key, entry]) => [key, JSON.parse(entry)])return { ...legacy, ...Object.fromEntries(entries) }}