Skip to content

The agent that grows with you

chore(browser): Windows footgun clean (utf-8-sig baked path read, launch-log open)

Tekniumbea92913365b
diff --git a/hermes_cli/browser_runtime.py b/hermes_cli/browser_runtime.py
index 08d0ab11229..a2409b20200 100644
--- a/hermes_cli/browser_runtime.py
+++ b/hermes_cli/browser_runtime.py
@@ -37,7 +37,7 @@ def _pm_executable() -> str | None:
def _baked_executable() -> str | None:
try:
- value = BAKED_EXECUTABLE_FILE.read_text(encoding="utf-8").strip()
+ value = BAKED_EXECUTABLE_FILE.read_text(encoding="utf-8-sig").strip()
except OSError: # not a Hermes Docker image: nothing baked
return None
return value if value and os.path.isfile(value) else None
diff --git a/tools/browser_launcher.py b/tools/browser_launcher.py
index 17e2c2daeca..9506188e4de 100644
--- a/tools/browser_launcher.py
+++ b/tools/browser_launcher.py
@@ -339,7 +339,8 @@ def _prepare_dir(user_data_dir: str, ephemeral: bool) -> None:
def _spawn(argv: list[str], env: dict, user_data_dir: str) -> subprocess.Popen:
- with open(os.path.join(user_data_dir, _LAUNCH_LOG), "wb") as log:
+ log_path = os.path.join(user_data_dir, _LAUNCH_LOG)
+ with open(log_path, "wb") as log:
return subprocess.Popen(argv, stdin=subprocess.DEVNULL, stdout=log, stderr=log, env=env,
**_spawn_kwargs())