The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(doctor): never install a moved plugin from a diagnostic; name the install instead
Tekniumbef9b258143b
diff --git a/hermes_cli/doctor.py b/hermes_cli/doctor.pyindex a50dbd0d4f8..d662092c443 100644--- a/hermes_cli/doctor.py+++ b/hermes_cli/doctor.py@@ -186,13 +186,15 @@ def run_doctor(args):"└─────────────────────────────────────────────────────────┘"):print(color(line, Colors.CYAN))total = Finding()- for title, check in DOCTOR_CHECKS:- if title:- _section(title)- total.merge(check(should_fix))- # Opt-in live probes run AFTER all static checks (`--live`: real network calls; bounded + read-only).- with warn_on_error(""):- from hermes_cli.doctor_live import maybe_run_live_checks- maybe_run_live_checks(args, total.manual_issues)+ from hermes_cli.left_core_migration import installs_held+ with installs_held(): # a diagnostic: provider checks resolve through the runtime, which would install+ for title, check in DOCTOR_CHECKS:+ if title:+ _section(title)+ total.merge(check(should_fix))+ # Opt-in live probes run AFTER all static checks (`--live`: real network calls; bounded + read-only).+ with warn_on_error(""):+ from hermes_cli.doctor_live import maybe_run_live_checks+ maybe_run_live_checks(args, total.manual_issues)_print_summary(should_fix, total)return int(bool(total.issues or total.manual_issues))diff --git a/hermes_cli/doctor_config.py b/hermes_cli/doctor_config.pyindex 0f7bd13f394..041e9fe7113 100644--- a/hermes_cli/doctor_config.py+++ b/hermes_cli/doctor_config.py@@ -309,6 +309,7 @@ def _validate_auxiliary_config(config_path, issues: list) -> None:"""Resolve every routed ``auxiliary.<task>`` block through the real entry point the tasks use and reportthe ones that fail — an unresolvable block otherwise silently runs the task on the main model (#116055)."""from hermes_cli.config import read_user_config_raw+ from hermes_cli.left_core_migration import provider_install_hintfrom hermes_cli.runtime_provider import resolve_runtime_providerfrom utils import base_url_hostnameaux = read_user_config_raw(config_path).get("auxiliary")@@ -320,9 +321,11 @@ def _validate_auxiliary_config(config_path, issues: list) -> None:try:runtime = resolve_runtime_provider(requested=provider, target_model=model, explicit_api_key=api_key, explicit_base_url=base_url)except Exception as exc:- _fail_and_issue(f"auxiliary.{task}.provider '{provider}' does not resolve", f"({str(exc).splitlines()[0]})",- f"auxiliary.{task}.provider '{provider}' cannot be resolved ({str(exc).splitlines()[0]}); the task "- f"silently runs on the main model. Fix the provider name/credentials in auxiliary.{task}.", issues)+ reason, moved = str(exc).splitlines()[0], provider_install_hint(provider or "")+ _fail_and_issue(f"auxiliary.{task}.provider '{provider}' does not resolve", f"({reason})",+ f"auxiliary.{task}.provider '{provider}' cannot be resolved ({reason}); the task silently runs "+ f"on the main model. " + (moved or f"Fix the provider name/credentials in auxiliary.{task}."),+ issues)continueif not runtime.get("api_key") and not runtime.get("command"):check_warn(f"auxiliary.{task}.provider '{provider}' resolved without credentials", f"({runtime.get('provider')} @ {runtime.get('base_url')})")diff --git a/hermes_cli/left_core_migration.py b/hermes_cli/left_core_migration.pyindex 2bb494e54cb..55ed29f6511 100644--- a/hermes_cli/left_core_migration.py+++ b/hermes_cli/left_core_migration.py@@ -29,6 +29,8 @@ from __future__ import annotationsimport loggingimport osimport sys+from contextlib import contextmanager+from contextvars import ContextVarfrom dataclasses import dataclassfrom pathlib import Pathfrom typing import Callable, Optional@@ -655,6 +657,18 @@ def moved_plugin_hint(name: str) -> str:_attempted: set[str] = set()_undelivered: dict[str, list[str]] = {}+_installs_held: ContextVar[bool] = ContextVar("left_core_installs_held", default=False)+++@contextmanager+def installs_held():+ """No migration attempt inside (a read-only diagnostic such as ``hermes doctor``, whose provider checks run+ the runtime resolver): the unknown-provider and host hints still name the install command."""+ token = _installs_held.set(True)+ try:+ yield+ finally:+ _installs_held.reset(token)def defer_startup_notice(message: str) -> None:@@ -986,6 +1000,8 @@ def recover_at_startup(*, say: Optional[Callable[[str], None]] = None) -> list[slogged and queued for the home's first agent.Returns installed plugin names."""from agent.safe_worker_policy import worker_config_snapshot+ if _installs_held.get():+ return []if worker_config_snapshot() is not None:# A frozen safe/ignore-user-config worker never reads the profile's config.yaml and never# installs customizations; the owner process runs this migration for the home.diff --git a/tests/hermes_cli/test_left_core_provider_runtime.py b/tests/hermes_cli/test_left_core_provider_runtime.pyindex 8c4c42aa494..31f34d40e91 100644--- a/tests/hermes_cli/test_left_core_provider_runtime.py+++ b/tests/hermes_cli/test_left_core_provider_runtime.py@@ -100,3 +100,19 @@ def test_a_route_configured_outside_the_main_model_installs_when_resolved(tmp_pa_copilot_home(tmp_path, monkeypatch, config)_resolve(requested="copilot")assert installs == [("github-copilot", True)]+++def test_doctor_installs_nothing_and_names_the_install(tmp_path, monkeypatch, installs, capsys):+ """`hermes doctor` is read-only: its auxiliary routing check resolves through the runtime resolver,+ which must not fetch the plugin there; the failed check names the install command instead."""+ from types import SimpleNamespace+ from hermes_cli import doctor+ from hermes_cli.doctor_config import _check_config_file+ home = _copilot_home(tmp_path, monkeypatch, "model:\n provider: nous\nauxiliary:\n vision:\n"+ " provider: copilot\n model: gpt-4.1\n")+ monkeypatch.setattr(doctor, "HERMES_HOME", home)+ monkeypatch.setattr(doctor, "DOCTOR_CHECKS", ((None, _check_config_file),))+ doctor.run_doctor(SimpleNamespace(fix=False, ack=None, live=False))+ assert installs == []+ assert not (home / "plugins" / "github-copilot").exists()+ assert "hermes plugins install github-copilot" in capsys.readouterr().out