The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(skills): pdf --flatten keeps form fields the JSON leaves out
Tekniumcfabecfa797a
diff --git a/skills/productivity/pdf/scripts/pdf_fill_form.py b/skills/productivity/pdf/scripts/pdf_fill_form.pyindex 37733e4e9f6..fb6865a3877 100644--- a/skills/productivity/pdf/scripts/pdf_fill_form.py+++ b/skills/productivity/pdf/scripts/pdf_fill_form.py@@ -66,9 +66,16 @@ def main() -> int:on_state = next((s for s in states if s != "/Off"), "/Yes")value = on_state if value else "/Off"fill[name] = value+ # Flattening bakes only the fields it is handed and the widgets are removed+ # afterwards, so fields the JSON leaves out are baked with their current value.+ to_write = fill+ if args.flatten:+ to_write = {name: info["/V"] for name, info in field_info.items()+ if info.get("/V") not in (None, "")}+ to_write.update(fill)for page in writer.pages:writer.update_page_form_field_values(- page, fill, flags=1 if args.flatten else 0,+ page, to_write, flags=1 if args.flatten else 0,auto_regenerate=False, flatten=args.flatten)root = writer._root_objectdiff --git a/skills/productivity/pdf/tests/test_pdf_skill.py b/skills/productivity/pdf/tests/test_pdf_skill.pyindex c9282f7def5..a29d58f70b1 100644--- a/skills/productivity/pdf/tests/test_pdf_skill.py+++ b/skills/productivity/pdf/tests/test_pdf_skill.py@@ -140,6 +140,21 @@ def test_form_fill_flatten_removes_widgets(form_pdf: Path, workdir: Path):assert "Ada" in (reader.pages[0].extract_text() or "")+def test_form_fill_flatten_keeps_fields_left_out_of_the_json(form_pdf: Path, workdir: Path):+ prefilled = workdir / "prefilled.pdf"+ first = workdir / "first.json"+ first.write_text(json.dumps({"surname": "KEEPME"}), encoding="utf-8")+ run("pdf_fill_form.py", str(form_pdf), "--fields-json", str(first), "-o", str(prefilled))+ partial = workdir / "partial.json"+ partial.write_text(json.dumps({"agree": True}), encoding="utf-8")+ flattened = workdir / "partial_flat.pdf"+ run("pdf_fill_form.py", str(prefilled), "--fields-json", str(partial),+ "-o", str(flattened), "--flatten")++ from pypdf import PdfReader+ assert "KEEPME" in (PdfReader(str(flattened)).pages[0].extract_text() or "")++def test_merge_split_rotate(report_pdf: Path, workdir: Path):merged = workdir / "merged.pdf"out = json.loads(run("pdf_merge.py", str(report_pdf), str(report_pdf),