The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(gateway): a busy-path reply never anchors on an internal wake's identity
Tekniumd3a3e204f5a7
diff --git a/gateway/run_busy.py b/gateway/run_busy.pyindex c4622a9a854..843d9cb9bb4 100644--- a/gateway/run_busy.py+++ b/gateway/run_busy.py@@ -565,14 +565,11 @@ class GatewayBusySessionMixin:@staticmethoddef _busy_reply_to(event: MessageEvent, reply_anchor):- # Telegram DM topics anchor on the thread; other Telegram threads send unanchored.- return (- reply_anchor- if event.source.platform == Platform.TELEGRAM- and event.source.chat_type == "dm"- and event.source.thread_id- else (None if event.source.platform == Platform.TELEGRAM and event.source.thread_id else event.message_id)- )+ # Telegram DM topics anchor on the thread; other Telegram threads send unanchored. An+ # internal wake's message_id is its producer identity, never a platform id (#139611).+ if event.source.platform == Platform.TELEGRAM and event.source.thread_id:+ return reply_anchor if event.source.chat_type == "dm" else None+ return None if getattr(event, "internal", False) else event.message_idasync def _send_busy_reply(self, event: MessageEvent, adapter, content: str, *, plain_anchor: bool = False) -> None:"""Send a busy-path reply anchored to the event (thread metadata included)."""diff --git a/tests/gateway/test_busy_reply_internal_anchor.py b/tests/gateway/test_busy_reply_internal_anchor.pynew file mode 100644index 00000000000..648cec9ed83--- /dev/null+++ b/tests/gateway/test_busy_reply_internal_anchor.py@@ -0,0 +1,52 @@+"""A busy-path reply to an internal wake never hands the wake's producer identity to the adapter.++An admitted automation wake carries its producer identity (a JSON triple such as+``["kanban-wake", route, uuid]``) in ``MessageEvent.message_id``. ``_reply_anchor_for_event``+already refuses to anchor on it, but the busy path's ``_busy_reply_to`` fell back to the raw+``event.message_id`` outside Telegram threads, so a drain notice for a plugin wake reached+Telegram's ``int()`` as ``reply_to`` (#139611).+"""++import pytest++from gateway.config import GatewayConfig, Platform+from gateway.platforms.event import MessageEvent+from gateway.run import GatewayRunner+from gateway.session import SessionSource++WAKE_ID = '["plugin","demo","agent:main:telegram:dm:42","0f1e2d3c4b5a69788796a5b4c3d2e1f0"]'+++class _Adapter:+ def __init__(self):+ self.sends = []++ async def _send_with_retry(self, **kwargs):+ self.sends.append(kwargs)+++def _runner():+ runner = object.__new__(GatewayRunner)+ runner.config = GatewayConfig()+ return runner++[email protected]("thread_id,chat_type", [(None, "dm"), ("7", "group"), ("7", "dm")])+async def test_busy_reply_to_an_internal_wake_is_unanchored(thread_id, chat_type):+ source = SessionSource(platform=Platform.TELEGRAM, chat_id="42", user_id="u1",+ chat_type=chat_type, thread_id=thread_id)+ event = MessageEvent(text="wake", source=source, message_id=WAKE_ID, internal=True,+ allow_gateway_control=False)+ adapter = _Adapter()+ await _runner()._send_busy_reply(event, adapter, "draining")+ assert adapter.sends[0]["reply_to"] is None+++async def test_busy_reply_to_a_human_message_still_anchors():+ source = SessionSource(platform=Platform.TELEGRAM, chat_id="42", user_id="u1", chat_type="dm")+ event = MessageEvent(text="hi", source=source, message_id="1234")+ adapter = _Adapter()+ await _runner()._send_busy_reply(event, adapter, "draining")+ assert adapter.sends[0]["reply_to"] == "1234"