The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
test(desktop): an idle native terminal tab keeps its saved scrollback after a shell's cursor query
emozillaee8d2b02d8bb
diff --git a/apps/desktop/src/app/right-sidebar/terminal/use-terminal-session.test.tsx b/apps/desktop/src/app/right-sidebar/terminal/use-terminal-session.test.tsxindex 1d0439f9cc1..c7f5da78d34 100644--- a/apps/desktop/src/app/right-sidebar/terminal/use-terminal-session.test.tsx+++ b/apps/desktop/src/app/right-sidebar/terminal/use-terminal-session.test.tsx@@ -69,7 +69,13 @@ vi.mock('@xterm/addon-fit', () => ({fit() {}}}))-vi.mock('@xterm/addon-serialize', () => ({ SerializeAddon: class {} }))+vi.mock('@xterm/addon-serialize', () => ({+ SerializeAddon: class {+ serialize() {+ return '$ make\r\nbuilt ok\r\n'+ }+ }+}))vi.mock('@xterm/addon-unicode11', () => ({ Unicode11Addon: class {} }))vi.mock('@xterm/addon-webgl', () => ({WebglAddon: class {@@ -378,3 +384,48 @@ it('native Desktop: a failed start shows main\'s error and Enter does not startexpect(start).toHaveBeenCalledTimes(1)expect(screen.getByText('closed')).toBeTruthy()})++// An idle tab never re-saves its scrollback (#61572): the live buffer holds the replayed history+// plus a fresh prompt. PowerShell (PSReadLine) and fish ask for the cursor position at startup, and+// xterm's reply reaches the shell through onData like typed input; counting that reply as activity+// re-saved those shells' idle tabs on every launch. Only keys, typing, composition, paste, drop and+// mouse input with mouse tracking on count.+it("native Desktop: xterm's reply to the shell's cursor query is not activity; typing is", async () => {+ let shellOutput: ((data: string) => void) | null = null+ const write = vi.fn(async () => true)++ delete window.document.documentElement.dataset.hermesDesktopHost+ ;(window as unknown as { hermesDesktop: unknown }).hermesDesktop = {+ terminal: {+ attach: vi.fn(async () => true),+ cwd: vi.fn(async () => null),+ dispose: vi.fn(async () => true),+ onData: vi.fn((_id: string, callback: (data: string) => void) => {+ shellOutput = callback++ return () => {}+ }),+ onExit: vi.fn(() => () => {}),+ resize: vi.fn(async () => true),+ start: vi.fn(async () => ({ id: 'pty-1', shell: 'pwsh.exe' })),+ write+ }+ }+ const id = createTerminal('/work')+ updateTerminalReviveBuffer(id, SAVED_HISTORY)+ const { container } = render(<Harness id={id} />)+ await waitFor(() => expect(shellOutput).not.toBeNull())+ const saved = () => $terminals.get().find(tab => tab.id === id)?.reviveBuffer++ act(() => shellOutput!('PS /work> \u001b[6n'))++ expect(write).toHaveBeenCalledWith('pty-1', '\u001b[1;1R')+ expect(saved()).toBe(SAVED_HISTORY)++ act(() => {+ container.querySelector('div')!.dispatchEvent(new Event('beforeinput'))+ shellOutput!('make\r\nbuilt ok\r\n')+ })++ await waitFor(() => expect(saved()).toContain('$ make'), { timeout: 2000 })+})