The agent that grows with you
Python aiai-agentai-agentsanthropicchatgptclaudeclaude-codecodexhermeshermes-agentllmnous-researchopenai
fix(gateway): the gateway route lists and runs a stalled room's Retry too
Tekniumfc73d805672f
diff --git a/gateway/session_hosted_controls.py b/gateway/session_hosted_controls.pyindex 028213e4050..fb94c393ee7 100644--- a/gateway/session_hosted_controls.py+++ b/gateway/session_hosted_controls.py@@ -2,6 +2,7 @@from gateway import hosted_room_driver as tasksfrom hermes_state_runtime import RuntimeStoreErrorfrom tui_gateway.hosted_room_driver import HostedRoomBinding+from tui_gateway.hosted_room_prepare_stall import RETRY_TASK_PREFIXfrom tui_gateway.hosted_room_service import attempt_action, task_member_id@@ -47,6 +48,10 @@ class HostedControls:return resultdef retry_room_task(self, room_id, *, member_id, task_id, execution_generation):+ if isinstance(task_id, str) and task_id.startswith(RETRY_TASK_PREFIX):+ # A stalled room preparation, not an attempt: the shared service retries it.+ return super().retry_room_task(+ room_id, task_id=task_id, member_id=member_id, execution_generation=execution_generation)with self._policy_lock:task, binding = self._control_task(room_id, member_id, task_id, execution_generation)# Unknown is not non-admission. Never advance its hosted generation@@ -69,7 +74,8 @@ class HostedControls:result = super().status(room_id)if room_id is None:return result- actions = [a for a in result['pending_actions'] if a['kind'] != 'retry']+ actions = [a for a in result['pending_actions']+ if a['kind'] != 'retry' or str(a.get('task_id', '')).startswith(RETRY_TASK_PREFIX)]for task in tasks.list_tasks(self.db_path, room_id=room_id):if task['status'] not in {'indeterminate', 'deferred'}:continuediff --git a/tests/gateway/test_hosted_room_handoff_send.py b/tests/gateway/test_hosted_room_handoff_send.pyindex 1aad21aaa24..e98ccad40b5 100644--- a/tests/gateway/test_hosted_room_handoff_send.py+++ b/tests/gateway/test_hosted_room_handoff_send.py@@ -9,12 +9,15 @@ from __future__ import annotationsimport sqlite3import threading++import pytestfrom pathlib import Pathfrom types import SimpleNamespacefrom gateway import hosted_room_driver, hosted_roomsfrom gateway.hosted_rooms_gateway_import import handoff_gateway_id, import_standalone_roomsfrom tests.waiting import wait_until+from gateway.session_hosted_controls import HostedControlsfrom tui_gateway.hosted_room_service import HostedRoomServiceMEMBERS = [{"member_id": "default", "profile": "default", "handle": "hermes"},@@ -47,8 +50,12 @@ class _RPC:return {"active": False, "task_id": None}-def _service(db_path: Path) -> tuple[HostedRoomService, _RPC]:- service = HostedRoomService(+class _GatewayRouteService(HostedControls, HostedRoomService):+ """The gateway route's control overrides (CanonicalHostedRoomService) over the shared service."""+++def _service(db_path: Path, cls: type[HostedRoomService] = HostedRoomService) -> tuple[HostedRoomService, _RPC]:+ service = cls(SimpleNamespace(_methods={}, _sessions={}, _sessions_lock=threading.Lock()), db_path=db_path)service.rpc = service.runtime.rpc = rpc = _RPC()service.local_profiles = lambda: ("default", "ops")@@ -114,9 +121,10 @@ def test_a_send_already_stored_is_answered_as_sent_when_preparing_the_room_failsassert _kinds(db, "room-1").count("message.user") == 2-def test_a_room_whose_members_cannot_be_woken_says_so_once_and_stops_retrying(tmp_path):[email protected]("route", [HostedRoomService, _GatewayRouteService], ids=["tui_gateway", "gateway"])+def test_a_room_whose_members_cannot_be_woken_says_so_once_and_stops_retrying(tmp_path, route):db = tmp_path / "state.db"- service, _ = _service(db)+ service, _ = _service(db, route)service.create_room(room_id="room-1", name="Room", members=MEMBERS)service.local_profiles = lambda: ("default", "dev", "ops")service.create_room(room_id="room-2", name="Other", members=[