Skip to content

The agent that grows with you

refactor(desktop): move filenameFromUrl out of main.ts

Tekniumff237a487adf
diff --git a/apps/desktop/electron/main.ts b/apps/desktop/electron/main.ts
index 880e2b03f7d..5de9f7917b3 100644
--- a/apps/desktop/electron/main.ts
+++ b/apps/desktop/electron/main.ts
@@ -650,6 +650,7 @@ import {
import { startUpdateRelaunchWaiter } from './updater/relaunch-waiter'
import { preflightStateDb } from './updater/state-db-preflight'
import { createStoreStrategy } from './updater/store-client'
+import { filenameFromUrl } from './url-filename'
import { isExternalVenvHolder, isHermesOwnedVenvDaemon } from './venv-holder-select'
import { fetchMarketplaceThemes, searchMarketplaceThemes } from './vscode-marketplace'
import { createWakeIndicatorWindowController } from './wake-indicator-window'
@@ -5470,17 +5471,6 @@ function extensionForMimeType(mimeType) {
return ''
}
-function filenameFromUrl(rawUrl, fallback = 'image') {
- try {
- const parsed = new URL(rawUrl)
- const base = path.basename(decodeURIComponent(parsed.pathname || ''))
-
- return base && base.includes('.') ? base : fallback
- } catch {
- return fallback
- }
-}
-
async function resourceBufferFromUrl(rawUrl) {
if (!rawUrl) {
throw new Error('Missing URL')
diff --git a/apps/desktop/electron/url-filename.ts b/apps/desktop/electron/url-filename.ts
new file mode 100644
index 00000000000..67b36a40de5
--- /dev/null
+++ b/apps/desktop/electron/url-filename.ts
@@ -0,0 +1,13 @@
+import path from 'node:path'
+
+/** The file name a URL's path ends in, or ``fallback`` when it names none. */
+export function filenameFromUrl(rawUrl: string, fallback: string = 'image'): string {
+ try {
+ const parsed = new URL(rawUrl)
+ const base = path.basename(decodeURIComponent(parsed.pathname || ''))
+
+ return base && base.includes('.') ? base : fallback
+ } catch {
+ return fallback
+ }
+}