Skip to content

Run Windows games on Apple Silicon — free, open source, with an open compatibility database that tells you what actually works.

Library never tells a user with a damaged environment to prepare a new one

Gauthier Piarrette2bee1a6a1ec6
diff --git a/Sources/HighballApp/AppState.swift b/Sources/HighballApp/AppState.swift
index 74a94b7..15ef7d4 100644
--- a/Sources/HighballApp/AppState.swift
+++ b/Sources/HighballApp/AppState.swift
@@ -3,6 +3,9 @@ import Foundation
import HighballKit
import Observation
+/// The three Settings tabs, so a deep link can select one.
+enum SettingsTab: Hashable { case environments, engine, troubleshooting }
+
@Observable @MainActor
final class AppState {
var engines: [InstalledEngine] = []
@@ -13,6 +16,9 @@ final class AppState {
/// Bottles with a delete in flight. Their rows show it and refuse a second click.
var deletingBottles: Set<String> = []
var selectedBottle: String?
+ /// Which Settings tab to show. A deep link (the library's "Open Troubleshooting") sets it
+ /// before opening the window; the TabView binds its selection to it.
+ var settingsTab: SettingsTab = .environments
var gamesByBottle: [String: [SteamGame]] = [:]
var gameDB = GameDB(directories: [])
diff --git a/Sources/HighballApp/L10n.swift b/Sources/HighballApp/L10n.swift
index 23f1a9a..84c188b 100644
--- a/Sources/HighballApp/L10n.swift
+++ b/Sources/HighballApp/L10n.swift
@@ -408,5 +408,8 @@ enum L10n {
"No engine is installed yet. Reinstall Highball, or restart it to finish setup.": "Aucun moteur n'est encore installé. Réinstallez Highball, ou relancez-le pour terminer la configuration.",
"Highball is already busy. Wait for the current step to finish, then try again — its progress is on the strip at the bottom of the window.": "Highball est déjà occupé. Attendez la fin de l'étape en cours, puis réessayez — sa progression est affichée en bas de la fenêtre.",
"No engine is installed yet. Restart Highball to finish setup.": "Aucun moteur n'est encore installé. Relancez Highball pour terminer la configuration.",
+ "An environment needs attention — Highball can't read its settings, so its games aren't showing.": "Un environnement nécessite votre attention — Highball ne peut pas lire ses réglages, donc ses jeux n'apparaissent pas.",
+ "Some environments need attention — Highball can't read their settings, so their games aren't showing.": "Certains environnements nécessitent votre attention — Highball ne peut pas lire leurs réglages, donc leurs jeux n'apparaissent pas.",
+ "Open Troubleshooting": "Ouvrir le dépannage",
]
}
diff --git a/Sources/HighballApp/LibraryView.swift b/Sources/HighballApp/LibraryView.swift
index 8a418b6..159e73a 100644
--- a/Sources/HighballApp/LibraryView.swift
+++ b/Sources/HighballApp/LibraryView.swift
@@ -11,6 +11,7 @@ typealias LibraryItem = HighballKit.LibraryItem
struct LibraryView: View {
@Environment(AppState.self) private var state
+ @Environment(\.openSettings) private var openSettings
@State private var search = ""
@State private var sourceFilter: LibrarySource?
@State private var installedOnly = false
@@ -102,6 +103,15 @@ struct LibraryView: View {
if state.busy {
Text(L("Highball is preparing your Windows environment. Your games will appear here."))
.foregroundStyle(.secondary)
+ } else if !state.damagedBottles.isEmpty {
+ // A present-but-unreadable environment must never look like a brand-new install:
+ // the games are likely still on disk, so point at recovery, not "prepare one".
+ Text(state.damagedBottles.count == 1
+ ? L("An environment needs attention — Highball can't read its settings, so its games aren't showing.")
+ : L("Some environments need attention — Highball can't read their settings, so their games aren't showing."))
+ .foregroundStyle(.secondary)
+ Button(L("Open Troubleshooting")) { state.settingsTab = .troubleshooting; openSettings() }
+ .buttonStyle(.borderedProminent).tint(HB.amber)
} else {
// An engine without an environment: an older install, or a stopped first run.
Text(L("One more step: Highball prepares a Windows environment for your games."))
diff --git a/Sources/HighballApp/SettingsView.swift b/Sources/HighballApp/SettingsView.swift
index 9415771..ec03d68 100644
--- a/Sources/HighballApp/SettingsView.swift
+++ b/Sources/HighballApp/SettingsView.swift
@@ -9,10 +9,13 @@ struct SettingsView: View {
var body: some View {
@Bindable var state = state
VStack(spacing: 0) {
- TabView {
+ TabView(selection: $state.settingsTab) {
EnvironmentsPane().tabItem { Label(L("Environments"), systemImage: "cylinder.split.1x2") }
+ .tag(SettingsTab.environments)
EnginePane().tabItem { Label(L("Engine"), systemImage: "gearshape.2") }
+ .tag(SettingsTab.engine)
TroubleshootingPane().tabItem { Label(L("Troubleshooting"), systemImage: "wrench.and.screwdriver") }
+ .tag(SettingsTab.troubleshooting)
}
// The strip lives on the main window; a compact echo here so a repair or a new
// environment started from Settings is not silent (review #14).