Skip to content

Run Windows games on Apple Silicon — free, open source, with an open compatibility database that tells you what actually works.

A play report's 'Played for N min through Highball' goes to the form's new Session field instead of Notes, so Notes stays free for the reporter's own words (highball#347: an edit to the prefilled Notes snapped back for udance4ever). highball-db's form has the field and its ingest script reads it, falling back to it as the notes when Notes is empty.

Gauthier Piarrettef3e4c8e96b2b
diff --git a/Sources/HighballKit/PlayReport.swift b/Sources/HighballKit/PlayReport.swift
index 36fef38..ce5a036 100644
--- a/Sources/HighballKit/PlayReport.swift
+++ b/Sources/HighballKit/PlayReport.swift
@@ -21,7 +21,9 @@ public enum PlayReport {
public static let template = "report.yml"
/// The issue URL for highball-db's report form, its fields prefilled by id. Query items use
- /// the form's field ids, which GitHub reads into the matching inputs.
+ /// the form's field ids, which GitHub reads into the matching inputs. The session line goes to
+ /// the form's own Session field, not Notes, so the reporter's words in Notes stay theirs
+ /// (highball#347: a prefilled Notes snapped back to the line when edited).
public static func url(title: String, appid: Int?, renderer: String?, chip: String, macos: String,
engine: String, minutes: Int, version: String? = nil, settings: String? = nil) -> URL {
var comps = URLComponents(string: "https://github.com/gauthierpiarrette/highball-db/issues/new")!
@@ -34,7 +36,7 @@ public enum PlayReport {
items += [URLQueryItem(name: "chip", value: chip),
URLQueryItem(name: "macos", value: macos),
URLQueryItem(name: "engine", value: engine),
- URLQueryItem(name: "notes", value: "Played for \(minutes) min through Highball.")]
+ URLQueryItem(name: "session", value: "Played for \(minutes) min through Highball.")]
comps.queryItems = items
return comps.url!
}
diff --git a/Tests/HighballKitTests/PlayReportTests.swift b/Tests/HighballKitTests/PlayReportTests.swift
index ffd7f2f..8207181 100644
--- a/Tests/HighballKitTests/PlayReportTests.swift
+++ b/Tests/HighballKitTests/PlayReportTests.swift
@@ -16,7 +16,8 @@ final class PlayReportTests: XCTestCase {
XCTAssertEqual(q["chip"], "Apple M1 Pro")
XCTAssertEqual(q["macos"], "26.6.2")
XCTAssertEqual(q["engine"], "x64-sikarugir10.0_6-r1")
- XCTAssertEqual(q["notes"], "Played for 23 min through Highball.")
+ XCTAssertEqual(q["session"], "Played for 23 min through Highball.")
+ XCTAssertNil(q["notes"], "Notes stays empty for the reporter's own words (highball#347)")
XCTAssertEqual(q["version"], "0.9.6")
XCTAssertNil(q["rating"], "the rating is the player's to give")
}