A modern and easy to use dashboard. 80+ integrations. 20K+ icons built in. Authentication out of the box. No YAML, drag and drop configuration.
fix(synology): submit login parameters in form body (#7229)
Thomas143078080161
diff --git a/packages/integrations/src/synology/synology-client.ts b/packages/integrations/src/synology/synology-client.tsindex e58e752e7..05e2df405 100644--- a/packages/integrations/src/synology/synology-client.ts+++ b/packages/integrations/src/synology/synology-client.ts@@ -305,9 +305,6 @@ export class SynologyClient {private async loginAsync(): Promise<StoredSession> {const authDefinition = await this.getApiDefinitionAsync(AUTH_API_NAME);const loginUrl = new URL(`${this.baseUrl}/webapi/${authDefinition.cgiPath}`);- loginUrl.searchParams.set("api", AUTH_API_NAME);- loginUrl.searchParams.set("version", String(authDefinition.maxVersion));- loginUrl.searchParams.set("method", "login");const safeLoginUrl = loginUrl.toString();const response = await fetchWithTrustedCertificatesAsync(loginUrl, {@@ -317,6 +314,9 @@ export class SynologyClient {"Content-Type": "application/x-www-form-urlencoded",},body: new URLSearchParams({+ api: AUTH_API_NAME,+ version: String(authDefinition.maxVersion),+ method: "login",account: this.username,passwd: this.password,session: AUTH_SESSION_NAME,diff --git a/packages/integrations/src/synology/test/synology-integration.spec.ts b/packages/integrations/src/synology/test/synology-integration.spec.tsindex 60e334fe4..99c8ac864 100644--- a/packages/integrations/src/synology/test/synology-integration.spec.ts+++ b/packages/integrations/src/synology/test/synology-integration.spec.ts@@ -182,6 +182,13 @@ const upgradeCheckResponse = {const toUrlString = (url: unknown): string => String(url);+const getRequestParameters = (url: string, init?: Parameters<typeof fetchWithTrustedCertificatesAsync>[1]) => {+ if (typeof init?.body === "string") {+ return new URLSearchParams(init.body);+ }+ return new URL(url).searchParams;+};+const getApiFromUrl = (url: string) => {const parsedUrl = new URL(url);return parsedUrl.searchParams.get("api");@@ -208,10 +215,11 @@ const mockSuccessfulFlow = (options?: {storageV2?: { success: boolean; data: z.input<typeof synologyStorageV2DataSchema> };storageLoadInfo?: typeof storageLoadInfoResponse;}) => {- mockFetch.mockImplementation((url) => {+ mockFetch.mockImplementation((url, init) => {const urlString = toUrlString(url);- const apiName = getApiFromUrl(urlString);- const method = getMethodFromUrl(urlString);+ const parameters = getRequestParameters(urlString, init);+ const apiName = parameters.get("api");+ const method = parameters.get("method");const type = getTypeFromUrl(urlString);if (apiName === "SYNO.API.Info" && method === "query") {@@ -565,10 +573,11 @@ describe("SynologyIntegration.listStorageVolumesAsync", () => {describe("SynologyIntegration authentication", () => {test("rejects two-factor authentication during login", async () => {- mockFetch.mockImplementation((url) => {+ mockFetch.mockImplementation((url, init) => {const urlString = toUrlString(url);- const apiName = getApiFromUrl(urlString);- const method = getMethodFromUrl(urlString);+ const parameters = getRequestParameters(urlString, init);+ const apiName = parameters.get("api");+ const method = parameters.get("method");if (apiName === "SYNO.API.Info" && method === "query") {const query = new URL(urlString).searchParams.get("query") ?? "SYNO.API.Auth";@@ -596,8 +605,9 @@ describe("SynologyIntegration authentication", () => {test("does not leak credentials in login error URLs", async () => {mockFetch.mockImplementation((url, init) => {const urlString = toUrlString(url);- const apiName = getApiFromUrl(urlString);- const method = getMethodFromUrl(urlString);+ const parameters = getRequestParameters(urlString, init);+ const apiName = parameters.get("api");+ const method = parameters.get("method");if (apiName === "SYNO.API.Info" && method === "query") {const query = new URL(urlString).searchParams.get("query") ?? "SYNO.API.Auth";