Skip to content

A modern and easy to use dashboard. 80+ integrations. 20K+ icons built in. Authentication out of the box. No YAML, drag and drop configuration.

fix(releases): add required octokit throttling rate limit handlers (#6338)

Thomas2d450239ac52
diff --git a/packages/api/src/router/widgets/releases.ts b/packages/api/src/router/widgets/releases.ts
index 84e903627..d234a75c1 100644
--- a/packages/api/src/router/widgets/releases.ts
+++ b/packages/api/src/router/widgets/releases.ts
@@ -3,6 +3,7 @@ import { escapeForRegEx } from "@tiptap/react";
import { z } from "zod/v4";
import { decryptSecret } from "@homarr/common/server";
+import { createLogger } from "@homarr/core/infrastructure/logs";
import { eq } from "@homarr/db";
import { boards, items, widgetSecrets } from "@homarr/db/schema";
import { releaseProviderKinds } from "@homarr/definitions";
@@ -11,6 +12,8 @@ import { releasesRequestHandler } from "@homarr/request-handler/releases";
import { createTRPCRouter, publicProcedure } from "../../trpc";
import { throwIfActionForbiddenAsync } from "../board/board-access";
+const logger = createLogger({ module: "releasesRouter" });
+
const formatVersionFilterRegex = (versionFilter: z.infer<typeof releaseVersionFilterSchema> | undefined) => {
if (!versionFilter) return undefined;
@@ -71,13 +74,13 @@ export const releasesRouter = createTRPCRouter({
for (const secret of secrets) {
try {
tokensByProvider.set(secret.kind, decryptSecret(secret.value));
- } catch {
- // Skip corrupt secrets
+ } catch (error) {
+ logger.warn("Failed to decrypt widget secret", { itemId: input.itemId, kind: secret.kind, error });
}
}
}
- } catch {
- // Access denied or table not yet migrated -- proceed without tokens
+ } catch (error) {
+ logger.warn("Failed to load release widget tokens", { itemId: input.itemId, error });
}
}
diff --git a/packages/request-handler/src/release-providers.ts b/packages/request-handler/src/release-providers.ts
index d4a9dd2b3..5bfde69b9 100644
--- a/packages/request-handler/src/release-providers.ts
+++ b/packages/request-handler/src/release-providers.ts
@@ -134,7 +134,33 @@ const getGithubApi = (baseUrl: string, userAgent: string, token?: string) =>
baseUrl,
auth: token,
request: { fetch: fetchWithTrustedCertificatesAsync },
- throttle: { enabled: true },
+ throttle: {
+ enabled: true,
+ onRateLimit: (
+ retryAfter: number,
+ options: { url?: string; method?: string },
+ _octokit: unknown,
+ retryCount: number,
+ ) => {
+ logger.warn(`GitHub rate limit exceeded, retrying after ${retryAfter}s (attempt ${retryCount + 1})`, {
+ url: options.url,
+ method: options.method,
+ });
+ return retryCount < 1;
+ },
+ onSecondaryRateLimit: (
+ retryAfter: number,
+ options: { url?: string; method?: string },
+ _octokit: unknown,
+ retryCount: number,
+ ) => {
+ logger.warn(`GitHub secondary rate limit exceeded, retrying after ${retryAfter}s (attempt ${retryCount + 1})`, {
+ url: options.url,
+ method: options.method,
+ });
+ return retryCount < 1;
+ },
+ },
userAgent,
});