Skip to content

A modern and easy to use dashboard. 80+ integrations. 20K+ icons built in. Authentication out of the box. No YAML, drag and drop configuration.

revert: restore previous ping behavior (#7189)

Thomas85c28fceef0e
diff --git a/packages/ping/src/index.ts b/packages/ping/src/index.ts
index e710904f2..124acb825 100644
--- a/packages/ping/src/index.ts
+++ b/packages/ping/src/index.ts
@@ -9,21 +9,15 @@ import { ErrorWithMetadata } from "@homarr/core/infrastructure/logs/error";
const logger = createLogger({ module: "ping" });
export const sendPingRequestAsync = async (url: string) => {
- let dispatcher: UndiciHttpAgent | undefined;
-
try {
- dispatcher = new UndiciHttpAgent({
- connect: {
- rejectUnauthorized: false, // Ping should always work, even with untrusted certificates
- },
- });
const start = performance.now();
return await withTimeoutAsync(async (signal) => {
return await fetch(url, {
- // Any response proves reachability; do not download a page or probe a redirect target.
- method: "HEAD",
- redirect: "manual",
- dispatcher,
+ dispatcher: new UndiciHttpAgent({
+ connect: {
+ rejectUnauthorized: false, // Ping should always work, even with untrusted certificates
+ },
+ }),
signal,
});
}).then((response) => {
@@ -36,7 +30,5 @@ export const sendPingRequestAsync = async (url: string) => {
return {
error: extractErrorMessage(error),
};
- } finally {
- await dispatcher?.destroy();
}
};
diff --git a/packages/widgets/src/app/ping/ping-indicator.tsx b/packages/widgets/src/app/ping/ping-indicator.tsx
index eef2c95b8..50ce5272a 100644
--- a/packages/widgets/src/app/ping/ping-indicator.tsx
+++ b/packages/widgets/src/app/ping/ping-indicator.tsx
@@ -17,7 +17,7 @@ export const PingIndicator = ({ appId }: PingIndicatorProps) => {
if (!pingResult) return <PingDot icon={IconMinus} color="gray" tooltip={`${t("action.loading")}…`} />;
- const isError = "error" in pingResult;
+ const isError = "error" in pingResult || pingResult.statusCode >= 500;
return (
<PingDot