A modern and easy to use dashboard. 80+ integrations. 20K+ icons built in. Authentication out of the box. No YAML, drag and drop configuration.
fix: accept direct icon URLs
Thomasedb56f3fcdea
diff --git a/apps/docs/docs/advanced/icons/index.mdx b/apps/docs/docs/advanced/icons/index.mdxindex 2876559ac..b73d49e02 100644--- a/apps/docs/docs/advanced/icons/index.mdx+++ b/apps/docs/docs/advanced/icons/index.mdx@@ -31,4 +31,4 @@ Icons that are high quality and printable ([SVG](https://wikipedia.org/wiki/Scal### Using external iconsIf you don't find the icon you're looking for on Dashboard Icons or wish to use a different source, you can simply enter a URL that points to an icon.-It is important that the URL directly points to the file without any advertisements or elements around it.+Direct HTTP(S) image URLs are used as entered instead of being searched in the built-in repositories. It is important that the URL directly points to the file without any advertisements or elements around it.diff --git a/apps/docs/docs/management/apps/index.mdx b/apps/docs/docs/management/apps/index.mdxindex c5c0a2ad7..35c02a4fc 100644--- a/apps/docs/docs/management/apps/index.mdx+++ b/apps/docs/docs/management/apps/index.mdx@@ -28,7 +28,7 @@ The name must be at least one character long and can be chosen freely.### Icon URLThis is the URL to the icon that will be displayed on the app widget.-It can be a url to an image in the internet, one from the included icon repositories or a local file uploaded through the upload button.+You can paste a direct HTTP(S) URL to an image, search the included icon repositories by name, or upload a local file through the upload button. Direct image URLs are used as entered and are not searched in the icon repositories.@@ -50,4 +50,4 @@ It's useful when you want to ping the service internally for example with a custOn the apps management page you find all apps that exist in your Homarr instance. You can edit and delete them.-\ No newline at end of file+diff --git a/packages/forms-collection/src/icon-picker/icon-picker.tsx b/packages/forms-collection/src/icon-picker/icon-picker.tsxindex 058e75bd0..4af6f1bd0 100644--- a/packages/forms-collection/src/icon-picker/icon-picker.tsx+++ b/packages/forms-collection/src/icon-picker/icon-picker.tsx@@ -165,8 +165,18 @@ export const IconPicker = ({leftSection={leftSection}value={inputValue}onChange={(event) => {- combobox.openDropdown();- setQuery(event.currentTarget.value);+ const nextValue = event.currentTarget.value;+ const trimmedValue = nextValue.trim();+ if (/^https?:\/\/[^\s/]+(?:\/\S*)?$/i.test(trimmedValue)) {+ startTransition(() => {+ setValue(trimmedValue);+ setQuery("");+ combobox.closeDropdown();+ });+ } else {+ combobox.openDropdown();+ setQuery(nextValue);+ }}}onClick={() => combobox.openDropdown()}onFocus={(event) => {