A continuation of HomeBox the inventory and organization system built for the Home User
Address code review feedback: restrict trace propagation, document payload limit
copilot-swe-agent[bot]163a751a18de
diff --git a/.scaffold/go.sum b/.scaffold/go.sumindex 36f3018c..823dee25 100644--- a/.scaffold/go.sum+++ b/.scaffold/go.sum@@ -8,7 +8,7 @@ github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIgithub.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=-github.com/sysadminsmedia/homebox/backend v0.0.0-20251228172914-2a6773d1d610 h1:kNLtnxaPaOryBUZ7RgUHPQVWxIExXYR/q9pYCbum5Vk=-github.com/sysadminsmedia/homebox/backend v0.0.0-20251228172914-2a6773d1d610/go.mod h1:9zHHw5TNttw5Kn4Wks+SxwXmJPz6PgGNbnB4BtF1Z4c=+github.com/sysadminsmedia/homebox/backend v0.0.0-20260120143742-9772c7d6f942 h1:1WVSCJyDdBu9vdJ0zRH8JQq/ePYpH2lqsO0gL9MKlJc=+github.com/sysadminsmedia/homebox/backend v0.0.0-20260120143742-9772c7d6f942/go.mod h1:9m2dzALElZA+1nwuQOUY7gYU1/eSMIcgc+FGPTN3rPg=gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=diff --git a/backend/internal/sys/otel/proxy.go b/backend/internal/sys/otel/proxy.goindex 08080966..969f80b9 100644--- a/backend/internal/sys/otel/proxy.go+++ b/backend/internal/sys/otel/proxy.go@@ -48,6 +48,10 @@ type TelemetryPayload struct {Spans []FrontendSpan `json:"spans"`}+// MaxTelemetryPayloadSize is the maximum size of telemetry payloads accepted by the proxy.+// This prevents denial-of-service attacks through excessively large payloads.+const MaxTelemetryPayloadSize = 1024 * 1024 // 1MB+// ProxyHandler handles telemetry data from the frontend.// This creates new spans in the backend that represent frontend activity,// allowing for distributed tracing across the full stack.@@ -64,8 +68,8 @@ func (p *Provider) ProxyHandler() http.HandlerFunc {return}- // Read and parse the payload- body, err := io.ReadAll(io.LimitReader(r.Body, 1024*1024)) // 1MB limit+ // Read and parse the payload with size limit+ body, err := io.ReadAll(io.LimitReader(r.Body, MaxTelemetryPayloadSize))if err != nil {log.Error().Err(err).Msg("failed to read telemetry payload")http.Error(w, "Failed to read request body", http.StatusBadRequest)diff --git a/frontend/lib/otel/index.ts b/frontend/lib/otel/index.tsindex bbefa94e..9a0506dc 100644--- a/frontend/lib/otel/index.ts+++ b/frontend/lib/otel/index.ts@@ -20,10 +20,8 @@ export interface OTelConfig {enabled: boolean;serviceName: string;serviceVersion: string;- // If true, sends telemetry through the backend proxy+ // Always use backend proxy for frontend telemetry (required for authentication)useBackendProxy: boolean;- // Endpoint for direct OTLP export (when not using backend proxy)- endpoint?: string;// Sampling rate (0.0 to 1.0)sampleRate: number;// Enable console logging for debugging@@ -185,19 +183,8 @@ export function initializeOTel(config: Partial<OTelConfig> = {}): void {resource,});- // Configure exporter- let exporter: SpanExporter;- if (finalConfig.useBackendProxy) {- exporter = new BackendProxyExporter("/api/v1/telemetry", finalConfig.debug);- } else if (finalConfig.endpoint) {- // Use OTLP HTTP exporter for direct export- // Dynamic import to avoid bundling when not used- console.warn("[OTel] Direct OTLP export not implemented, using backend proxy");- exporter = new BackendProxyExporter("/api/v1/telemetry", finalConfig.debug);- } else {- console.warn("[OTel] No exporter configured, tracing disabled");- return;- }+ // Configure exporter - always use backend proxy for authentication+ const exporter: SpanExporter = new BackendProxyExporter("/api/v1/telemetry", finalConfig.debug);// Use batch processor for better performanceprovider.addSpanProcessor(new BatchSpanProcessor(exporter));@@ -211,7 +198,9 @@ export function initializeOTel(config: Partial<OTelConfig> = {}): void {registerInstrumentations({instrumentations: [new FetchInstrumentation({- propagateTraceHeaderCorsUrls: [/.*/], // Propagate to all URLs+ // Only propagate trace headers to same-origin requests to prevent leaking+ // trace information to external domains. The pattern matches the current origin.+ propagateTraceHeaderCorsUrls: [new RegExp(`^${window.location.origin}`)],clearTimingResources: true,applyCustomAttributesOnSpan: (span, request) => {// Add custom attributes to fetch spans