Skip to content

A continuation of HomeBox the inventory and organization system built for the Home User

fix: assign extension if not set (#161)

Hayden73c42f47844c
diff --git a/backend/app/api/handlers/v1/v1_ctrl_items_attachments.go b/backend/app/api/handlers/v1/v1_ctrl_items_attachments.go
index e776e9ac..4eae453d 100644
--- a/backend/app/api/handlers/v1/v1_ctrl_items_attachments.go
+++ b/backend/app/api/handlers/v1/v1_ctrl_items_attachments.go
@@ -4,6 +4,8 @@ import (
"errors"
"fmt"
"net/http"
+ "path/filepath"
+ "strings"
"github.com/hay-kot/homebox/backend/internal/core/services"
"github.com/hay-kot/homebox/backend/internal/data/ent/attachment"
@@ -113,7 +115,15 @@ func (ctrl *V1Controller) HandleItemAttachmentDownload() server.HandlerFunc {
return validate.NewRequestError(err, http.StatusInternalServerError)
}
- w.Header().Set("Content-Disposition", fmt.Sprintf("attachment; filename=\"%s\"", doc.Title))
+ ext := filepath.Ext(doc.Path)
+
+ title := doc.Title
+
+ if !strings.HasSuffix(doc.Title, ext) {
+ title = doc.Title + ext
+ }
+
+ w.Header().Set("Content-Disposition", fmt.Sprintf("attachment; filename=\"%s\"", title))
w.Header().Set("Content-Type", "application/octet-stream")
http.ServeFile(w, r, doc.Path)
return nil