Skip to content

A continuation of HomeBox the inventory and organization system built for the Home User

fix: hardcoded frontend strings (#1311)

An!a50370f06ae9
diff --git a/frontend/components/Collection/Selector.vue b/frontend/components/Collection/Selector.vue
index 78085659..b1e257d0 100644
--- a/frontend/components/Collection/Selector.vue
+++ b/frontend/components/Collection/Selector.vue
@@ -7,8 +7,8 @@
:aria-expanded="open"
:size="sidebar.state.value === 'collapsed' ? 'icon' : undefined"
:class="sidebar.state.value === 'collapsed' ? 'size-10' : 'w-full justify-between drop-shadow-md'"
- aria-label="Collections"
- title="Collections"
+ :aria-label="t('components.collection.selector.select_collection')"
+ :title="t('components.collection.selector.select_collection')"
>
<template v-if="sidebar.state.value === 'collapsed'">
<MdiHomeGroup class="size-5" />
diff --git a/frontend/components/Item/BarcodeModal.vue b/frontend/components/Item/BarcodeModal.vue
index a489ca34..7d10f8cc 100644
--- a/frontend/components/Item/BarcodeModal.vue
+++ b/frontend/components/Item/BarcodeModal.vue
@@ -100,7 +100,9 @@
</BaseCard>
<DialogFooter>
- <Button type="import" :disabled="selectedRow === -1" @click="createItem"> Import selected </Button>
+ <Button type="button" :disabled="selectedRow === -1" @click="createItem">
+ {{ $t("components.item.product_import.import_selected") }}
+ </Button>
</DialogFooter>
</DialogContent>
</Dialog>
diff --git a/frontend/components/Maintenance/ListView.vue b/frontend/components/Maintenance/ListView.vue
index 5f84a733..1b8ae296 100644
--- a/frontend/components/Maintenance/ListView.vue
+++ b/frontend/components/Maintenance/ListView.vue
@@ -203,7 +203,7 @@
<Currency :amount="e.cost" />
</Badge>
</TooltipTrigger>
- <TooltipContent> Cost </TooltipContent>
+ <TooltipContent> {{ $t("maintenance.modal.cost") }} </TooltipContent>
</Tooltip>
</TooltipProvider>
</div>
diff --git a/frontend/components/Search/Filter.vue b/frontend/components/Search/Filter.vue
index fdb92940..657d1d2f 100644
--- a/frontend/components/Search/Filter.vue
+++ b/frontend/components/Search/Filter.vue
@@ -8,7 +8,7 @@
</PopoverTrigger>
<PopoverContent class="z-40 p-0">
<div class="p-4 shadow-sm">
- <Input v-model="search" type="text" placeholder="Search…" />
+ <Input v-model="search" type="text" :placeholder="$t('components.search.filter.search_placeholder')" />
</div>
<div class="max-h-72 divide-y overflow-y-auto">
<Label
diff --git a/frontend/components/global/CopyText.vue b/frontend/components/global/CopyText.vue
index ee825ec9..27fe828e 100644
--- a/frontend/components/global/CopyText.vue
+++ b/frontend/components/global/CopyText.vue
@@ -50,7 +50,7 @@
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
- <AlertDialogAction>Continue</AlertDialogAction>
+ <AlertDialogAction>{{ $t("components.global.copy_text.continue") }}</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
diff --git a/frontend/locales/en.json b/frontend/locales/en.json
index f1c20463..d522fb6d 100644
--- a/frontend/locales/en.json
+++ b/frontend/locales/en.json
@@ -123,6 +123,7 @@
},
"global": {
"copy_text": {
+ "continue": "Continue",
"documentation": "documentation",
"failed_to_copy": "Failed to copy text to clipboard",
"https_required": "because HTTPS is required",
@@ -214,6 +215,7 @@
"error_exception": "Exception occured while retrieving item barcode: ",
"error_invalid_barcode": "Invalid barcode provided",
"error_not_found": "No product found with given barcode.",
+ "import_selected": "Import selected",
"search_item": "Search product",
"title": "Import product"
},
@@ -301,6 +303,11 @@
"no_results": "No results found.",
"shortcut_hint": "Use the number keys to quickly select an action."
},
+ "search": {
+ "filter": {
+ "search_placeholder": "Search…"
+ }
+ },
"tag": {
"create_modal": {
"tag_color": "Tag Color",
@@ -511,6 +518,7 @@
"view_image": "View Image"
},
"edit_details": "Edit Details",
+ "field": "Field",
"field_selector": "Field Selector",
"field_value": "Field Value",
"first": "First",
@@ -550,7 +558,9 @@
"reset_search": "Reset Search",
"results": "{ total } Results",
"select_field": "Select a field",
+ "select_value": "Select a value",
"serial_number": "Serial Number",
+ "show_empty": "Show Empty",
"show_advanced_view_options": "Show Advanced View Options",
"sold_at": "Sold At",
"sold_details": "Sold Details",
diff --git a/frontend/pages/item/[id]/index.vue b/frontend/pages/item/[id]/index.vue
index cf193b80..4712bcbd 100644
--- a/frontend/pages/item/[id]/index.vue
+++ b/frontend/pages/item/[id]/index.vue
@@ -771,7 +771,7 @@
<div class="mt-2 flex flex-wrap items-center justify-between gap-4">
<Label class="flex cursor-pointer items-center gap-2">
<Switch v-model="preferences.showEmpty" />
- Show Empty
+ {{ $t("items.show_empty") }}
</Label>
<div class="space-x-1">
<CopyText :text="currentUrl" :icon-size="16" />
diff --git a/frontend/pages/item/[id]/index/edit.vue b/frontend/pages/item/[id]/index/edit.vue
index fd9fba17..1c77eb95 100644
--- a/frontend/pages/item/[id]/index/edit.vue
+++ b/frontend/pages/item/[id]/index/edit.vue
@@ -494,7 +494,7 @@
const { error } = await api.items.update(itemId.value, payload);
if (error) {
- toast.error("Failed to save item");
+ toast.error(t("items.toast.failed_save"));
return;
}
diff --git a/frontend/pages/items.vue b/frontend/pages/items.vue
index 8e5ca838..26a1772a 100644
--- a/frontend/pages/items.vue
+++ b/frontend/pages/items.vue
@@ -481,7 +481,7 @@
<p>{{ $t("items.custom_fields") }}</p>
<div v-for="(f, idx) in fieldTuples" :key="idx" class="flex flex-wrap gap-2">
<div class="flex w-full flex-col gap-1 md:w-auto md:grow">
- <Label> Field </Label>
+ <Label> {{ $t("items.field") }} </Label>
<Select v-model="fieldTuples[idx]![0]" @update:model-value="fetchValues(f[0])">
<SelectTrigger>
<SelectValue :placeholder="$t('items.select_field')" />
@@ -495,7 +495,7 @@
<Label> {{ $t("items.field_value") }} </Label>
<Select v-model="fieldTuples[idx]![1]">
<SelectTrigger>
- <SelectValue placeholder="Select a value" />
+ <SelectValue :placeholder="$t('items.select_value')" />
</SelectTrigger>
<SelectContent>
<SelectItem v-for="value in fieldValuesCache[f[0]]" :key="value" :value="value">