Skip to content

A continuation of HomeBox the inventory and organization system built for the Home User

fix: prevent javascript: and data: links

Matthew Kilgored76b1c9b94e9
diff --git a/frontend/composables/utils.test.ts b/frontend/composables/utils.test.ts
index 9cbc3b03..f0d6a15c 100644
--- a/frontend/composables/utils.test.ts
+++ b/frontend/composables/utils.test.ts
@@ -29,4 +29,18 @@ describe("maybeURL works as expected", () => {
expect(result.url).toBe("");
expect(result.text).toBe("");
});
+
+ test("javascript scheme in special syntax is rejected", () => {
+ const result = maybeUrl("[Click Me](javascript:alert(1))");
+ expect(result.isUrl).toBe(false);
+ expect(result.url).toBe("");
+ expect(result.text).toBe("");
+ });
+
+ test("data scheme in special syntax is rejected", () => {
+ const result = maybeUrl("[Click Me](data:text/html,<script>alert(1)</script>)");
+ expect(result.isUrl).toBe(false);
+ expect(result.url).toBe("");
+ expect(result.text).toBe("");
+ });
});
diff --git a/frontend/composables/utils.ts b/frontend/composables/utils.ts
index 7d964155..a7cf62c0 100644
--- a/frontend/composables/utils.ts
+++ b/frontend/composables/utils.ts
@@ -153,9 +153,13 @@ export type MaybeUrlResult = {
text: string;
};
+function isHttpUrl(str: string): boolean {
+ return str.startsWith("http://") || str.startsWith("https://");
+}
+
export function maybeUrl(str: string): MaybeUrlResult {
const result: MaybeUrlResult = {
- isUrl: str.startsWith("http://") || str.startsWith("https://"),
+ isUrl: isHttpUrl(str),
url: "",
text: "",
};
@@ -167,9 +171,15 @@ export function maybeUrl(str: string): MaybeUrlResult {
if (str.startsWith("[")) {
const match = str.match(/\[(.*)\]\((.*)\)/);
if (match && match.length === 3) {
- result.isUrl = true;
- result.text = match[1]!;
- result.url = match[2]!;
+ // Only http(s) may become a clickable link; any other scheme
+ // (javascript:, data:, ...) must stay plain text — the result is
+ // bound directly to an anchor href.
+ const url = match[2]!.trim();
+ if (isHttpUrl(url)) {
+ result.isUrl = true;
+ result.text = match[1]!;
+ result.url = url;
+ }
}
} else {
result.url = str;