Skip to content

Self-hosted homelab infrastructure visualizer — interactive network diagram with live status monitoring

fix(detail-panel): replace pixel math and fixed tooltip in ServiceBadge

Pouzor1d6127fed30b
diff --git a/frontend/src/components/panels/DetailPanel.tsx b/frontend/src/components/panels/DetailPanel.tsx
index ce832f1..6bc8c5a 100644
--- a/frontend/src/components/panels/DetailPanel.tsx
+++ b/frontend/src/components/panels/DetailPanel.tsx
@@ -660,10 +660,10 @@ const CATEGORY_COLORS: Record<string, string> = {
}
function ServiceBadge({ svc, host, onEdit, onRemove }: { svc: ServiceInfo; host?: string; onEdit: () => void; onRemove: () => void }) {
- const url = getServiceUrl(svc, host);
- const color = CATEGORY_COLORS[svc.category ?? ''] ?? '#8b949e';
- const hasPort = svc.port != null;
- const portLabel = hasPort ? String(svc.port) : '';
+ const url = getServiceUrl(svc, host)
+ const color = CATEGORY_COLORS[svc.category ?? ''] ?? '#8b949e'
+ const hasPort = svc.port != null
+ const portLabel = hasPort ? String(svc.port) : ''
const pathLabel = svc.path?.trim() ? svc.path.trim() : ''
return (
diff --git a/frontend/src/components/panels/__tests__/DetailPanel.test.tsx b/frontend/src/components/panels/__tests__/DetailPanel.test.tsx
index e90c400..52c3c5f 100644
--- a/frontend/src/components/panels/__tests__/DetailPanel.test.tsx
+++ b/frontend/src/components/panels/__tests__/DetailPanel.test.tsx
@@ -445,4 +445,46 @@ describe('DetailPanel', () => {
expect(screen.getByText(/192\.168\.1\.10, 192\.168\.1\.11/)).toBeDefined()
})
})
+
+ describe('ServiceBadge rendering', () => {
+ it('renders service name and port/protocol label', () => {
+ setupStore({ services: [{ port: 8080, protocol: 'tcp', service_name: 'nginx', path: '' }] })
+ render(<DetailPanel onEdit={vi.fn()} />)
+ expect(screen.getByText('nginx')).toBeDefined()
+ expect(screen.getByText('8080/tcp')).toBeDefined()
+ })
+
+ it('renders path label when path is set', () => {
+ setupStore({ services: [{ port: 80, protocol: 'tcp', service_name: 'web', path: '/admin' }] })
+ render(<DetailPanel onEdit={vi.fn()} />)
+ expect(screen.getByText('/admin')).toBeDefined()
+ })
+
+ it('renders no path text when path is empty', () => {
+ setupStore({ services: [{ port: 80, protocol: 'tcp', service_name: 'web', path: '' }] })
+ render(<DetailPanel onEdit={vi.fn()} />)
+ expect(screen.queryByText('/')).toBeNull()
+ })
+
+ it('renders port/protocol omitted when port is absent', () => {
+ setupStore({ services: [{ protocol: 'tcp', service_name: 'health', path: '' }] })
+ render(<DetailPanel onEdit={vi.fn()} />)
+ expect(screen.getByText('health')).toBeDefined()
+ expect(screen.queryByText(/\/tcp/)).toBeNull()
+ })
+
+ it('renders service name as link when ip and port are set', () => {
+ setupStore({ ip: '192.168.1.10', services: [{ port: 8080, protocol: 'tcp', service_name: 'nginx', path: '' }] })
+ render(<DetailPanel onEdit={vi.fn()} />)
+ const link = screen.getByRole('link', { name: 'nginx' })
+ expect(link.getAttribute('href')).toContain('192.168.1.10')
+ expect(link.getAttribute('target')).toBe('_blank')
+ })
+
+ it('renders service name as plain text when no url can be built', () => {
+ setupStore({ ip: undefined, services: [{ protocol: 'tcp', service_name: 'health', path: '' }] })
+ render(<DetailPanel onEdit={vi.fn()} />)
+ expect(screen.getByText('health').tagName).not.toBe('A')
+ })
+ })
})