Skip to content

Self-hosted homelab infrastructure visualizer — interactive network diagram with live status monitoring

fix: harden network and MCP security boundaries

Giovanni Ferri97d11641b9c1
diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 0000000..0d7b5f9
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1,17 @@
+.git
+.gitignore
+.env
+.env.*
+**/.env
+**/.env.*
+*.db
+*.sqlite
+*.sqlite3
+data/
+uploads/
+node_modules/
+__pycache__/
+*.py[cod]
+.pytest_cache/
+.mypy_cache/
+.ruff_cache/
\ No newline at end of file
diff --git a/.env.example b/.env.example
index da5b10c..b61ceb5 100644
--- a/.env.example
+++ b/.env.example
@@ -1,6 +1,6 @@
# Backend - server-side only (NEVER commit .env)
# Generate: python3 -c "import secrets; print(secrets.token_hex(32))"
-SECRET_KEY=change_me_in_production
+SECRET_KEY=
SQLITE_PATH=./data/homelab.db
# Uploaded media (floor plans) folder. Optional — defaults to <SQLITE_PATH dir>/uploads,
# which sits on the same persistent volume as the DB.
@@ -15,14 +15,13 @@ CORS_ORIGINS=["http://localhost:5173","http://localhost:3000"]
# Auth — local mode is the backward-compatible default.
AUTH_MODE=local
-# Local credentials: admin / admin by default.
-# ⚠️ Change before exposing on a network.
+# Local credentials: set both values before starting the backend.
# Generate a new hash: python3 -c "import bcrypt; print(bcrypt.hashpw(b'yourpassword', bcrypt.gensalt()).decode())"
# ⚠️ Keep the single quotes around the hash — bcrypt hashes contain \$ which Docker misinterprets without them.
# podman-compose does not strip those quotes the way Docker Compose does, so the
# backend unwraps one matched pair itself — quoted or not, both work everywhere.
-AUTH_USERNAME=admin
-AUTH_PASSWORD_HASH='$2b$12$RtMbyw17l4N5UGzeXMNAWuzCaVV.XFBY7ZetWheQhxcBDcxahapkG'
+AUTH_USERNAME=
+AUTH_PASSWORD_HASH=
# OpenID Connect (optional alternative to local auth).
# Set AUTH_MODE=oidc and configure every value below. The callback must be
@@ -58,8 +57,8 @@ STATUS_CHECKER_INTERVAL=60
# MCP_API_KEY: authenticates AI clients (Claude Code, etc.) → MCP server
# MCP_SERVICE_KEY: authenticates MCP server → backend (never exposed externally)
# Generate keys: python3 -c "import secrets; print(secrets.token_hex(32))"
-MCP_API_KEY=mcp_sk_changeme
-MCP_SERVICE_KEY=svc_changeme
+MCP_API_KEY=
+MCP_SERVICE_KEY=
# Live view — read-only public canvas at /view?key=<value>
# Off by default. Set to a random secret to enable.
diff --git a/Dockerfile.backend b/Dockerfile.backend
index 82bb73f..dc7c299 100644
--- a/Dockerfile.backend
+++ b/Dockerfile.backend
@@ -14,6 +14,12 @@ COPY VERSION /app/VERSION
# Create data directory (volume mount point)
RUN mkdir -p /app/data
+# The application does not need root after image setup. Running as a dedicated
+# user also prevents a backend compromise from writing over the application code.
+RUN useradd --system --create-home --uid 10001 app \
+ && chown -R app:app /app
+USER app
+
EXPOSE 8000
CMD ["uvicorn", "app.main:app", "--host", "0.0.0.0", "--port", "8000"]
diff --git a/INSTALLATION.md b/INSTALLATION.md
index ac4e7ea..7d2cbb9 100644
--- a/INSTALLATION.md
+++ b/INSTALLATION.md
@@ -388,11 +388,11 @@ All configuration is done via `.env` (copied from `.env.example`):
```env
# Generate with: python3 -c "import secrets; print(secrets.token_hex(32))"
-SECRET_KEY=change_me_in_production
+SECRET_KEY=<random-secret-at-least-32-bytes>
-# Auth — default: admin / admin
-AUTH_USERNAME=admin
-AUTH_PASSWORD_HASH='$2b$12$...' # bcrypt hash — keep single quotes
+# Auth — set a username and a bcrypt hash for your own password.
+AUTH_USERNAME=<your-username>
+AUTH_PASSWORD_HASH='<bcrypt-hash>' # keep single quotes
# CIDR ranges to scan
SCANNER_RANGES=["192.168.1.0/24"]
diff --git a/backend/app/api/routes/proxmox.py b/backend/app/api/routes/proxmox.py
index f0e5514..7022a9d 100644
--- a/backend/app/api/routes/proxmox.py
+++ b/backend/app/api/routes/proxmox.py
@@ -59,18 +59,35 @@ _PVE_IEEE_PREFIX = "pve-"
def _resolve_credentials(payload: ProxmoxConnectionRequest) -> tuple[str, str]:
- """Pick the API token: request body first, else server env config.
+ """Resolve credentials without sending server secrets to custom hosts.
- Raises HTTP 400 when neither carries a token.
+ Environment credentials are only valid for the configured Proxmox endpoint.
+ A custom endpoint must provide both token fields explicitly.
"""
- token_id = payload.token_id or settings.proxmox_token_id
- token_secret = payload.token_secret or settings.proxmox_token_secret
- if not token_id or not token_secret:
+ has_request_token = bool(payload.token_id or payload.token_secret)
+ if has_request_token:
+ if not payload.token_id or not payload.token_secret:
+ raise HTTPException(status_code=400, detail="Provide both Proxmox token fields")
+ return payload.token_id, payload.token_secret
+
+ configured_host = settings.proxmox_host.strip().rstrip(".").lower()
+ request_host = payload.host.strip().rstrip(".").lower()
+ if (
+ not configured_host
+ or request_host != configured_host
+ or payload.port != settings.proxmox_port
+ or payload.verify_tls != settings.proxmox_verify_tls
+ ):
+ raise HTTPException(
+ status_code=400,
+ detail="Custom Proxmox hosts require an explicit API token",
+ )
+ if not settings.proxmox_token_id or not settings.proxmox_token_secret:
raise HTTPException(
status_code=400,
detail="No Proxmox API token provided and none configured on the server.",
)
- return token_id, token_secret
+ return settings.proxmox_token_id, settings.proxmox_token_secret
@router.post("/test-connection", response_model=ProxmoxTestConnectionResponse)
diff --git a/backend/app/api/routes/scan.py b/backend/app/api/routes/scan.py
index b6d970f..37a4afa 100644
--- a/backend/app/api/routes/scan.py
+++ b/backend/app/api/routes/scan.py
@@ -311,7 +311,17 @@ async def rescan_device(
if device.status == "hidden":
raise HTTPException(status_code=409, detail="Device is hidden")
- target = f"{device.ip}/32"
+ device_ips = []
+ for candidate in _ip_tokens(device.ip):
+ try:
+ device_ips.append(str(ipaddress.ip_address(candidate)))
+ except ValueError:
+ continue
+ if not device_ips:
+ raise HTTPException(status_code=409, detail="Device has no valid IP address to scan")
+ # A row may retain multiple observed addresses. The deep-rescan operation
+ # targets the first valid address, matching the scanner's single-host API.
+ target = f"{device_ips[0]}/32"
running = (await db.execute(
select(ScanRun).where(ScanRun.status == "running", ScanRun.kind == "device")
)).scalars().all()
diff --git a/backend/app/services/scanner.py b/backend/app/services/scanner.py
index 7f49ff6..e66c7fa 100644
--- a/backend/app/services/scanner.py
+++ b/backend/app/services/scanner.py
@@ -26,6 +26,13 @@ from app.services.mac_utils import normalize_mac
logger = logging.getLogger(__name__)
+
+def _normalized_ip(value: str) -> str | None:
+ try:
+ return str(ipaddress.ip_address(value.strip()))
+ except ValueError:
+ return None
+
# Run IDs that have been requested to cancel (thread-safe via lock)
_cancelled_runs: set[str] = set()
_cancelled_lock = threading.Lock()
@@ -336,7 +343,15 @@ def _nmap_scan_single(
fails (e.g. a TLS port stalls plaintext probes), the Pass A ports
are kept with empty banners instead of the whole host being lost.
"""
- ip = host_dict["ip"]
+ raw_ip = host_dict.get("ip")
+ if not isinstance(raw_ip, str):
+ logger.warning("[Phase 2] refusing invalid single-IP target %r", raw_ip)
+ return host_dict
+ try:
+ ip = str(ipaddress.ip_address(raw_ip))
+ except ValueError:
+ logger.warning("[Phase 2] refusing invalid single-IP target %r", raw_ip)
+ return host_dict
logger.info("[Phase 2] Scanning %s ...", ip)
if not _NMAP_AVAILABLE:
@@ -946,8 +961,18 @@ async def run_device_scan(
if device is None or not device.ip:
raise ValueError("Device has no IP to scan")
+ device_ip = next(
+ (
+ normalized
+ for candidate in ip_tokens(device.ip)
+ if (normalized := _normalized_ip(candidate)) is not None
+ ),
+ None,
+ )
+ if device_ip is None:
+ raise ValueError("Device has no valid IP to scan")
host: dict[str, Any] = {
- "ip": device.ip,
+ "ip": device_ip,
"mac": device.mac,
"hostname": device.hostname,
"os": device.os,
diff --git a/install.sh b/install.sh
index 7cbf5ae..27aa185 100755
--- a/install.sh
+++ b/install.sh
@@ -35,6 +35,28 @@ else
curl -fsSL "${RAW}/.env.example" -o .env.example
fi
+if [ "${STANDALONE}" -eq 0 ]; then
+ if [ ! -f .env ]; then
+ cp .env.example .env
+ fi
+ missing=0
+ for key in SECRET_KEY AUTH_PASSWORD_HASH MCP_API_KEY MCP_SERVICE_KEY; do
+ value=$(grep -E "^${key}=" .env | head -n 1 | cut -d= -f2- || true)
+ if [ -z "${value}" ]; then
+ echo " Missing required security setting: ${key}"
+ missing=1
+ fi
+ done
+ if grep -Eq 'change_me_in_production|mcp_sk_changeme|svc_changeme|RtMbyw17l4N5UGzeXMNAWuzCaVV.XFBY7ZetWheQhxcBDcxahapkG' .env; then
+ echo " Refusing to start with a known default credential."
+ missing=1
+ fi
+ if [ "${missing}" -ne 0 ]; then
+ echo " Configure .env and rerun this installer. No services were started."
+ exit 1
+ fi
+fi
+
if [ "${IS_UPDATE}" -eq 1 ]; then
echo ""
echo " docker-compose.yml updated."
@@ -48,13 +70,8 @@ else
echo " Run:"
echo " cd ${INSTALL_DIR} && docker compose up -d"
else
- if [ ! -f .env ]; then
- cp .env.example .env
- fi
echo ""
- echo " Edit .env if needed (default login: admin / admin):"
- echo " - Set SECRET_KEY to a random string"
- echo " - Change AUTH_PASSWORD_HASH before exposing on a network"
+ echo " Security settings loaded from .env."
echo ""
echo " Run:"
echo " cd ${INSTALL_DIR} && docker compose up -d"
diff --git a/mcp/.env.example b/mcp/.env.example
index 104ba2e..1bf5963 100644
--- a/mcp/.env.example
+++ b/mcp/.env.example
@@ -2,11 +2,11 @@
# Authenticates AI clients (Claude Code, Claude Desktop, etc.) → MCP server
# Generate: python3 -c "import secrets; print('mcp_sk_' + secrets.token_hex(24))"
-MCP_API_KEY=mcp_sk_changeme
+MCP_API_KEY=
# Authenticates MCP server → backend (must match MCP_SERVICE_KEY in backend .env)
# Generate: python3 -c "import secrets; print('svc_' + secrets.token_hex(24))"
-MCP_SERVICE_KEY=svc_changeme
+MCP_SERVICE_KEY=
# Backend URL — use http://backend:8000 in Docker, http://localhost:8000 for local dev
BACKEND_URL=http://localhost:8000
diff --git a/mcp/Dockerfile.mcp b/mcp/Dockerfile.mcp
index 6065594..5b73c73 100644
--- a/mcp/Dockerfile.mcp
+++ b/mcp/Dockerfile.mcp
@@ -7,4 +7,8 @@ RUN pip install --no-cache-dir -r requirements.txt
COPY app/ ./app/
+RUN useradd --system --create-home --uid 10001 app \
+ && chown -R app:app /app
+USER app
+
CMD ["uvicorn", "app.main:app", "--host", "0.0.0.0", "--port", "8001"]
diff --git a/mcp/app/backend_client.py b/mcp/app/backend_client.py
index 2ab3b56..64793d4 100644
--- a/mcp/app/backend_client.py
+++ b/mcp/app/backend_client.py
@@ -1,4 +1,5 @@
import json
+import re
import httpx
@@ -26,6 +27,13 @@ class BackendError(RuntimeError):
_MAX_DETAIL = 500
+def safe_id(value: str, *, field: str = "id") -> str:
+ """Allow only one backend identifier path segment."""
+ if not isinstance(value, str) or not re.fullmatch(r"[A-Za-z0-9_-]+", value):
+ raise ValueError(f"Invalid {field}")
+ return value
+
+
def _detail_of(resp: httpx.Response) -> str:
"""The backend's explanation for a failed response, as a single string.
diff --git a/mcp/app/config.py b/mcp/app/config.py
index f6adf81..c370409 100644
--- a/mcp/app/config.py
+++ b/mcp/app/config.py
@@ -2,8 +2,8 @@ from pydantic_settings import BaseSettings
class Settings(BaseSettings):
- mcp_api_key: str = "mcp_sk_changeme" # AI client → MCP server
- mcp_service_key: str = "svc_changeme" # MCP server → backend
+ mcp_api_key: str = "" # AI client → MCP server
+ mcp_service_key: str = "" # MCP server → backend
backend_url: str = "http://backend:8000"
model_config = {"env_file": ".env", "extra": "ignore"}
diff --git a/mcp/app/devices.py b/mcp/app/devices.py
index c9e6fb5..e8e5953 100644
--- a/mcp/app/devices.py
+++ b/mcp/app/devices.py
@@ -10,7 +10,7 @@ from typing import Any
from mcp.types import Tool
-from .backend_client import backend
+from .backend_client import backend, safe_id
# Fields shared by create and update, mirroring InventoryDeviceCreate /
# InventoryDeviceUpdate (backend/app/schemas/scan.py). `_dispatch` forwards args
@@ -133,10 +133,10 @@ async def dispatch_device(name: str, args: dict) -> Any:
if name == "update_device":
body = {k: v for k, v in args.items() if k != "id"}
- return await backend.patch(f"/api/v1/scan/pending/{args['id']}", body)
+ return await backend.patch(f"/api/v1/scan/pending/{safe_id(args['id'], field='device id')}", body)
if name == "delete_device":
- return await backend.delete(f"/api/v1/scan/pending/{args['id']}")
+ return await backend.delete(f"/api/v1/scan/pending/{safe_id(args['id'], field='device id')}")
if name == "bulk_approve_devices":
approval: dict[str, Any] = {"device_ids": args["device_ids"]}
@@ -152,10 +152,10 @@ async def dispatch_device(name: str, args: dict) -> Any:
if name == "rescan_device":
options = {k: v for k, v in args.items() if k != "id"}
- return await backend.post(f"/api/v1/scan/pending/{args['id']}/rescan", options)
+ return await backend.post(f"/api/v1/scan/pending/{safe_id(args['id'], field='device id')}/rescan", options)
if name == "list_proxmox_children":
- return await backend.get(f"/api/v1/scan/pending/{args['id']}/proxmox-children")
+ return await backend.get(f"/api/v1/scan/pending/{safe_id(args['id'], field='device id')}/proxmox-children")
if name == "get_scan_config":
return await backend.get("/api/v1/scan/config")
diff --git a/mcp/app/documents.py b/mcp/app/documents.py
index 1d31d5b..50dcdae 100644
--- a/mcp/app/documents.py
+++ b/mcp/app/documents.py
@@ -16,7 +16,7 @@ from urllib.parse import urlencode
from mcp.types import Tool
-from .backend_client import backend
+from .backend_client import backend, safe_id
# Kept in sync with DOCUMENT_KINDS (backend/app/services/doc_tree.py), which is
# itself the DocKind union in frontend/src/documentation/types.ts.
@@ -141,16 +141,16 @@ async def dispatch_document(name: str, args: dict) -> Any:
return await backend.get(path)
if name == "read_document":
- return await backend.get(f"/api/v1/documents/{args['id']}")
+ return await backend.get(f"/api/v1/documents/{safe_id(args['id'], field='document id')}")
if name == "list_document_revisions":
- return await backend.get(f"/api/v1/documents/{args['document_id']}/revisions")
+ return await backend.get(f"/api/v1/documents/{safe_id(args['document_id'], field='document id')}/revisions")
if name == "read_document_revision":
- return await backend.get(f"/api/v1/documents/revisions/{args['revision_id']}")
+ return await backend.get(f"/api/v1/documents/revisions/{safe_id(args['revision_id'], field='revision id')}")
if name == "document_backlinks":
- return await backend.get(f"/api/v1/documents/{args['document_id']}/backlinks")
+ return await backend.get(f"/api/v1/documents/{safe_id(args['document_id'], field='document id')}/backlinks")
if name == "create_document":
return await backend.post("/api/v1/documents", args)
@@ -161,10 +161,10 @@ async def dispatch_document(name: str, args: dict) -> Any:
# client asked for. The backend ignores the reason when the body is
# unchanged, so a starred flag still snapshots nothing.
body["revision_reason"] = _MCP_REASON
- return await backend.patch(f"/api/v1/documents/{args['id']}", body)
+ return await backend.patch(f"/api/v1/documents/{safe_id(args['id'], field='document id')}", body)
if name == "restore_document_revision":
- path = f"/api/v1/documents/{args['document_id']}/revisions/{args['revision_id']}/restore"
+ path = f"/api/v1/documents/{safe_id(args['document_id'], field='document id')}/revisions/{safe_id(args['revision_id'], field='revision id')}/restore"
return await backend.post(path, {})
raise ValueError(f"Unknown documentation tool: {name}")
diff --git a/mcp/app/racks.py b/mcp/app/racks.py
index 22855e6..4582671 100644
--- a/mcp/app/racks.py
+++ b/mcp/app/racks.py
@@ -22,7 +22,7 @@ from urllib.parse import quote
from mcp.types import Tool
-from .backend_client import backend
+from .backend_client import backend, safe_id
from .faceplates import (
FACEPLATES,
RACK_COLUMNS,
@@ -65,7 +65,7 @@ def _savable(row: dict[str, Any]) -> dict[str, Any]:
async def _load_state(design_id: str) -> dict[str, Any]:
- return cast(dict[str, Any], await backend.get(f"/api/v1/racks?design_id={quote(design_id)}"))
+ return cast(dict[str, Any], await backend.get(f"/api/v1/racks?design_id={quote(safe_id(design_id, field='design id'))}"))
async def _save_state(design_id: str, state: dict[str, Any]) -> dict[str, Any]:
@@ -393,7 +393,7 @@ async def dispatch_rack(name: str, args: dict) -> Any:
}
if name == "list_rack_inventory":
- data = cast(dict[str, Any], await backend.get(f"/api/v1/racks/inventory?design_id={quote(design_id)}"))
+ data = cast(dict[str, Any], await backend.get(f"/api/v1/racks/inventory?design_id={quote(safe_id(design_id, field='design id'))}"))
return [_slim_inventory_item(item) for item in data.get("items", [])]
# --- Writes -------------------------------------------------------------
@@ -673,7 +673,7 @@ async def _mount_device(design_id: str, args: dict[str, Any]) -> dict[str, Any]:
rack = _rack_or_raise(state, args["rack_id"])
inventory = cast(
- dict[str, Any], await backend.get(f"/api/v1/racks/inventory?design_id={quote(design_id)}")
+ dict[str, Any], await backend.get(f"/api/v1/racks/inventory?design_id={quote(safe_id(design_id, field='design id'))}")
)
item = next(
(i for i in inventory.get("items", []) if i["id"] == args["inventory_device_id"]), None
diff --git a/mcp/app/resources.py b/mcp/app/resources.py
index ed118a6..986d094 100644
--- a/mcp/app/resources.py
+++ b/mcp/app/resources.py
@@ -2,7 +2,7 @@ import json
from mcp.server import Server
from mcp.server.lowlevel.helper_types import ReadResourceContents
from mcp.types import Resource, ResourceTemplate
-from .backend_client import backend
+from .backend_client import backend, safe_id
RESOURCE_LIST = [
Resource(uri="homelable://canvas", name="Canvas", description="Full canvas state (nodes + edges + viewport)", mimeType="application/json"),
@@ -54,12 +54,12 @@ async def read_resource(uri: str) -> list[ReadResourceContents]:
uri = str(uri)
if uri.startswith("homelable://nodes/") and uri != "homelable://nodes/":
node_id = uri.split("/")[-1]
- data = await backend.get(f"/api/v1/nodes/{node_id}")
+ data = await backend.get(f"/api/v1/nodes/{safe_id(node_id, field='node id')}")
return [_json_contents(data)]
if uri.startswith("homelable://documents/") and uri != "homelable://documents/":
document_id = uri.split("/")[-1]
- data = await backend.get(f"/api/v1/documents/{document_id}")
+ data = await backend.get(f"/api/v1/documents/{safe_id(document_id, field='document id')}")
return [_json_contents(data)]
if uri not in ROUTES:
diff --git a/mcp/app/tools.py b/mcp/app/tools.py
index b34706e..0711836 100644
--- a/mcp/app/tools.py
+++ b/mcp/app/tools.py
@@ -2,7 +2,7 @@ import json
from urllib.parse import quote
from mcp.server import Server
from mcp.types import Tool, TextContent
-from .backend_client import backend
+from .backend_client import backend, safe_id
from .devices import DEVICE_TOOL_NAMES, DEVICE_TOOLS, dispatch_device
from .documents import DOC_TOOL_NAMES, DOC_TOOLS, dispatch_document
from .racks import RACK_TOOL_NAMES, RACK_TOOLS, dispatch_rack
@@ -420,39 +420,39 @@ async def _dispatch(name: str, args: dict) -> dict:
return await backend.post("/api/v1/nodes", args)
if name == "update_node":
- node_id = args.pop("id")
- return await backend.patch(f"/api/v1/nodes/{node_id}", args)
+ node_id = safe_id(args.pop("id"), field="node id")
+ return await backend.patch(f"/api/v1/nodes/{safe_id(node_id, field='node id')}", args)
if name == "delete_node":
- return await backend.delete(f"/api/v1/nodes/{args['id']}")
+ return await backend.delete(f"/api/v1/nodes/{safe_id(args['id'], field='node id')}")
if name == "create_edge":
return await backend.post("/api/v1/edges", args)
if name == "update_edge":
- edge_id = args.pop("id")
+ edge_id = safe_id(args.pop("id"), field="edge id")
return await backend.patch(f"/api/v1/edges/{edge_id}", args)
if name == "list_edges":
return await backend.get("/api/v1/edges")
if name == "delete_edge":
- return await backend.delete(f"/api/v1/edges/{args['id']}")
+ return await backend.delete(f"/api/v1/edges/{safe_id(args['id'], field='edge id')}")
if name == "trigger_scan":
body = {"ranges": args["ranges"]} if "ranges" in args else {}
return await backend.post("/api/v1/scan/trigger", body)
if name == "approve_device":
- device_id = args.pop("id")
+ device_id = safe_id(args.pop("id"), field="device id")
return await backend.post(f"/api/v1/scan/pending/{device_id}/approve", args)
if name == "hide_device":
- return await backend.post(f"/api/v1/scan/pending/{args['id']}/hide", {})
+ return await backend.post(f"/api/v1/scan/pending/{safe_id(args['id'], field='device id')}/hide", {})
if name == "get_canvas":
design_id = args.get("design_id")
- path = f"/api/v1/canvas?design_id={design_id}" if design_id else "/api/v1/canvas"
+ path = f"/api/v1/canvas?design_id={quote(safe_id(design_id, field='design id'))}" if design_id else "/api/v1/canvas"
raw = await backend.get(path)
return _slim_canvas(raw)
@@ -467,7 +467,7 @@ async def _dispatch(name: str, args: dict) -> dict:
node_id = args.get("id")
label = args.get("label")
if node_id:
- return await backend.get(f"/api/v1/nodes/{node_id}")
+ return await backend.get(f"/api/v1/nodes/{safe_id(node_id, field='node id')}")
if label:
return await backend.get(f"/api/v1/nodes?label={quote(label)}")
raise ValueError("get_node requires either 'id' or 'label'")
@@ -493,7 +493,7 @@ async def _dispatch(name: str, args: dict) -> dict:
return await backend.get("/api/v1/scan/hidden")
if name == "restore_device":
- return await backend.post(f"/api/v1/scan/pending/{args['id']}/restore", {})
+ return await backend.post(f"/api/v1/scan/pending/{safe_id(args['id'], field='device id')}/restore", {})
if name == "create_zone":
colors = {k: args.pop(k) for k in list(_ZONE_COLOR_FIELDS) if k in args}
@@ -542,7 +542,7 @@ async def _dispatch(name: str, args: dict) -> dict:
continue
# The canvas stores a child's position relative to its parent, so
# rebase or the node jumps by the zone's offset on the next load.
- await backend.patch(f"/api/v1/nodes/{node_id}", {
+ await backend.patch(f"/api/v1/nodes/{safe_id(node_id, field='node id')}", {
"parent_id": zone_id,
"pos_x": (node.get("pos_x") or 0) - (zone.get("pos_x") or 0),
"pos_y": (node.get("pos_y") or 0) - (zone.get("pos_y") or 0),
@@ -561,7 +561,7 @@ async def _dispatch(name: str, args: dict) -> dict:
skipped.append(node_id)
continue
# Zone-relative → absolute, so the node stays where it looks.
- await backend.patch(f"/api/v1/nodes/{node_id}", {
+ await backend.patch(f"/api/v1/nodes/{safe_id(node_id, field='node id')}", {
"parent_id": None,
"pos_x": (node.get("pos_x") or 0) + (zone.get("pos_x") or 0),
"pos_y": (node.get("pos_y") or 0) + (zone.get("pos_y") or 0),
@@ -576,6 +576,6 @@ async def _dispatch(name: str, args: dict) -> dict:
return await backend.post("/api/v1/designs", args)
if name == "delete_design":
- return await backend.delete(f"/api/v1/designs/{args['design_id']}")
+ return await backend.delete(f"/api/v1/designs/{safe_id(args['design_id'], field='design id')}")
raise ValueError(f"Unknown tool: {name}")