Self-hosted homelab infrastructure visualizer — interactive network diagram with live status monitoring
TypeScript diagramhomelabhomelab-infrastructure-observabilitynetworkproxmox-veself-hostedzigbeezwavezwave-js
fix: removed setState within an effect, responsibility moved to parent key
findtheloraxf6de7d177022
diff --git a/frontend/src/App.tsx b/frontend/src/App.tsxindex fdd1b1c..2a2717b 100644--- a/frontend/src/App.tsx+++ b/frontend/src/App.tsx@@ -422,6 +422,7 @@ export default function App() {</div><NodeModal+ key={addNodeOpen ? 'add-open' : 'add-closed'}open={addNodeOpen}onClose={() => setAddNodeOpen(false)}onSubmit={handleAddNode}diff --git a/frontend/src/components/modals/NodeModal.tsx b/frontend/src/components/modals/NodeModal.tsxindex 0895f77..5caa1cd 100644--- a/frontend/src/components/modals/NodeModal.tsx+++ b/frontend/src/components/modals/NodeModal.tsx@@ -1,4 +1,4 @@-import { createElement, useEffect, useState } from 'react'+import { createElement, useState } from 'react'import { RotateCcw, ChevronDown } from 'lucide-react'import { Dialog, DialogContent, DialogHeader, DialogTitle } from '@/components/ui/dialog'import { Button } from '@/components/ui/button'@@ -48,14 +48,6 @@ export function NodeModal({ open, onClose, onSubmit, initial, title = 'Add Node'const [iconPickerOpen, setIconPickerOpen] = useState(false)const [labelError, setLabelError] = useState(false)- useEffect(() => {- if (!open) return- setForm({ ...DEFAULT_DATA, ...initial })- setIconSearch('')- setIconPickerOpen(false)- setLabelError(false)- }, [open, initial])-const set = (key: keyof NodeData, value: unknown) =>setForm((f) => ({ ...f, [key]: value }))diff --git a/frontend/src/components/modals/__tests__/NodeModal.test.tsx b/frontend/src/components/modals/__tests__/NodeModal.test.tsxindex ffe9b2c..7a8eee7 100644--- a/frontend/src/components/modals/__tests__/NodeModal.test.tsx+++ b/frontend/src/components/modals/__tests__/NodeModal.test.tsx@@ -134,12 +134,12 @@ describe('NodeModal', () => {const onClose = vi.fn()const onSubmit = vi.fn()- const { rerender } = render(<NodeModal open onClose={onClose} onSubmit={onSubmit} />)+ const { rerender } = render(<NodeModal key="open-1" open onClose={onClose} onSubmit={onSubmit} />)fireEvent.change(screen.getByPlaceholderText('My Server'), { target: { value: 'Temp Node' } })fireEvent.change(screen.getByPlaceholderText('server.lan'), { target: { value: 'temp.local' } })- rerender(<NodeModal open={false} onClose={onClose} onSubmit={onSubmit} />)- rerender(<NodeModal open onClose={onClose} onSubmit={onSubmit} />)+ rerender(<NodeModal key="closed" open={false} onClose={onClose} onSubmit={onSubmit} />)+ rerender(<NodeModal key="open-2" open onClose={onClose} onSubmit={onSubmit} />)expect((screen.getByPlaceholderText('My Server') as HTMLInputElement).value).toBe('')expect((screen.getByPlaceholderText('server.lan') as HTMLInputElement).value).toBe('')