Skip to content

Open-Source API Development Ecosystem • https://hoppscotch.io • Offline, On-Prem & Cloud • Web, Desktop & CLI • Open-Source Alternative to Postman, Insomnia

fix: enforce type checking on commit time

Andrew Bastin2a67e98588dd
diff --git a/package.json b/package.json
index 333dee4ee..670f6e53e 100644
--- a/package.json
+++ b/package.json
@@ -12,8 +12,9 @@
"generate": "pnpm -r do-build-prod",
"start": "pnpm -r do-prod-start",
"lint": "pnpm -r do-lint",
+ "typecheck": "pnpm -r do-typecheck",
"lintfix": "pnpm -r do-lintfix",
- "pre-commit": "pnpm -r do-lint",
+ "pre-commit": "pnpm -r do-lint && pnpm -r do-typecheck",
"test": "pnpm -r do-test"
},
"workspaces": [
diff --git a/packages/hoppscotch-app/package.json b/packages/hoppscotch-app/package.json
index 5c6fffc79..53cdba57a 100644
--- a/packages/hoppscotch-app/package.json
+++ b/packages/hoppscotch-app/package.json
@@ -25,6 +25,7 @@
"lintfix": "pnpm run lintfix:script && pnpm run lintfix:style",
"test": "jest",
"do-dev": "pnpm run dev",
+ "do-typecheck": "pnpx tsc --noEmit",
"do-build-prod": "pnpm run generate",
"do-prod-start": "pnpm run start",
"do-lint": "pnpm run lint",
@@ -146,6 +147,7 @@
"@types/httpsnippet": "^1.23.1",
"@types/lodash": "^4.14.179",
"@types/lossless-json": "^1.0.1",
+ "@types/paho-mqtt": "^1.0.6",
"@types/postman-collection": "^3.5.7",
"@types/splitpanes": "^2.2.1",
"@types/uuid": "^8.3.4",
diff --git a/packages/hoppscotch-app/tsconfig.json b/packages/hoppscotch-app/tsconfig.json
index eb87b6222..605de6831 100644
--- a/packages/hoppscotch-app/tsconfig.json
+++ b/packages/hoppscotch-app/tsconfig.json
@@ -8,6 +8,7 @@
"esModuleInterop": true,
"allowJs": true,
"sourceMap": true,
+ "skipLibCheck": true,
"strict": true,
"noEmit": true,
"baseUrl": ".",
diff --git a/packages/hoppscotch-app/types/socket-io-2.d.ts b/packages/hoppscotch-app/types/socket-io-2.d.ts
new file mode 100644
index 000000000..7302c5400
--- /dev/null
+++ b/packages/hoppscotch-app/types/socket-io-2.d.ts
@@ -0,0 +1,7 @@
+// NOTE: This is an implementation just for shutting up
+// tsc, this is really annoying (and maybe dangerous)
+// We don't have access to the 2.4.0 typings, hence we make do with this,
+// Check docs before you correct types again as you need
+declare module "socket.io-client-v2" {
+ export type Socket = any
+}
diff --git a/packages/hoppscotch-data/package.json b/packages/hoppscotch-data/package.json
index c59ac930f..c8538ac33 100644
--- a/packages/hoppscotch-data/package.json
+++ b/packages/hoppscotch-data/package.json
@@ -9,7 +9,8 @@
],
"scripts": {
"build": "tsup src --dts",
- "prepare": "tsup src --dts"
+ "prepare": "tsup src --dts",
+ "do-typecheck": "pnpx tsc --noEmit"
},
"exports": {
".": "./dist/index.js",
diff --git a/packages/hoppscotch-data/tsconfig.json b/packages/hoppscotch-data/tsconfig.json
index 0e105b88c..3f59b51f8 100644
--- a/packages/hoppscotch-data/tsconfig.json
+++ b/packages/hoppscotch-data/tsconfig.json
@@ -7,6 +7,7 @@
"esModuleInterop": true,
"strict": true,
"strictNullChecks": true,
+ "skipLibCheck": true,
"resolveJsonModule": true
}
}
diff --git a/packages/hoppscotch-js-sandbox/package.json b/packages/hoppscotch-js-sandbox/package.json
index 69d2bd45d..e7771c286 100644
--- a/packages/hoppscotch-js-sandbox/package.json
+++ b/packages/hoppscotch-js-sandbox/package.json
@@ -20,6 +20,7 @@
"prepublish": "pnpm run build",
"do-lint": "pnpm run lint",
"do-lintfix": "pnpm run lintfix",
+ "do-typecheck": "pnpx tsc --noEmit",
"do-build-prod": "pnpm run build",
"do-test": "pnpm run test"
},
diff --git a/packages/hoppscotch-js-sandbox/tsconfig.json b/packages/hoppscotch-js-sandbox/tsconfig.json
index 2bacfb49c..8eb23a6d1 100644
--- a/packages/hoppscotch-js-sandbox/tsconfig.json
+++ b/packages/hoppscotch-js-sandbox/tsconfig.json
@@ -3,6 +3,7 @@
"target": "ES6",
"module": "ESNext",
"moduleResolution": "Node",
+ "skipLibCheck": true,
"lib": ["ESNext", "ESNext.AsyncIterable", "DOM"],
"esModuleInterop": true,
"strict": true,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 8f1ee71ca..5879330f3 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -107,6 +107,7 @@ importers:
'@types/httpsnippet': ^1.23.1
'@types/lodash': ^4.14.179
'@types/lossless-json': ^1.0.1
+ '@types/paho-mqtt': ^1.0.6
'@types/postman-collection': ^3.5.7
'@types/splitpanes': ^2.2.1
'@types/uuid': ^8.3.4
@@ -301,6 +302,7 @@ importers:
'@types/httpsnippet': 1.23.1
'@types/lodash': 4.14.179
'@types/lossless-json': 1.0.1
+ '@types/paho-mqtt': 1.0.6
'@types/postman-collection': 3.5.7
'@types/splitpanes': 2.2.1
'@types/uuid': 8.3.4
@@ -5021,6 +5023,10 @@ packages:
'@types/webpack': 4.41.28
dev: true
+ /@types/paho-mqtt/1.0.6:
+ resolution: {integrity: sha512-d6CXsdv2fEruyZLe5DUtgGsF8ROp0358OrEmVgqtFxO/kiCvP9KhYen9N6ReKBkMdR/d0parLQq6DMn2qe6d9Q==}
+ dev: true
+
/@types/parse-json/4.0.0:
resolution: {integrity: sha512-//oorEZjL6sbPcKUaCdIGlIUeH26mgzimjBB77G6XRgnDl/L5wOnpyBGRe/Mmf5CVW3PwEBE1NjiMZ/ssFh4wA==}