Open-Source API Development Ecosystem • https://hoppscotch.io • Offline, On-Prem & Cloud • Web, Desktop & CLI • Open-Source Alternative to Postman, Insomnia
TypeScript apiapi-clientapi-restapi-testingdeveloper-toolsgraphqlhttphttp-clientpwarestrest-apispatestingtesting-toolstoolsvuevuejswebsocket
refactor: removing Redis from pubsub in sh-backend (HBE-178) (#49)
Balu Babu3df04922754e
diff --git a/packages/hoppscotch-backend/src/pubsub/pubsub.service.ts b/packages/hoppscotch-backend/src/pubsub/pubsub.service.tsindex bec396028..a69ec3b42 100644--- a/packages/hoppscotch-backend/src/pubsub/pubsub.service.ts+++ b/packages/hoppscotch-backend/src/pubsub/pubsub.service.ts@@ -1,33 +1,8 @@import { OnModuleInit } from '@nestjs/common';import { Injectable } from '@nestjs/common';-import { default as Redis, RedisOptions } from 'ioredis';--import { RedisPubSub } from 'graphql-redis-subscriptions';import { PubSub as LocalPubSub } from 'graphql-subscriptions';import { TopicDef } from './topicsDefs';-/**- * RedisPubSub uses JSON parsing for back and forth conversion, which loses Date objects, hence this reviver brings them back- * This function implementation should function like the JSON.parse reviver function- * @param key The key being parsed- * @param value The value being parsed- * @returns The updated value for the key- */-const dateReviver = (key: string, value: unknown) => {- const isISO8601Z =- /^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2}(?:\.\d*)?)Z$/;-- if (typeof value === 'string' && isISO8601Z.test(value)) {- const tempDateNumber = Date.parse(value);-- if (!isNaN(tempDateNumber)) {- return new Date(tempDateNumber);- }- }-- return value;-};-/** Figure out which PubSub to use (simple/local for dev and Redis for production)* and expose it@@ -35,40 +10,16 @@ const dateReviver = (key: string, value: unknown) => {@Injectable()export class PubSubService implements OnModuleInit {- private pubsub: RedisPubSub | LocalPubSub;+ private pubsub: LocalPubSub;onModuleInit() {- if (process.env.PRODUCTION === 'false') {- console.log('Initialize PubSub in development mode');-- this.pubsub = new LocalPubSub();- } else {- console.log('Initialize PubSub in production mode');- console.log(- `REDIS_IP: ${process.env.REDIS_IP}, REDIS_PORT: ${process.env.REDIS_PORT}`,- );-- const redisOptions: RedisOptions = {- port: parseInt(process.env.REDIS_PORT || '6379'),- host: process.env.REDIS_IP,- retryStrategy: (times: number) => {- return Math.min(times * 50, 2000);- },- };+ console.log('Initialize PubSub');- this.pubsub = new RedisPubSub({- publisher: new Redis(redisOptions),- subscriber: new Redis(redisOptions),- reviver: dateReviver,- });- }+ this.pubsub = new LocalPubSub();}- asyncIterator<T>(- topic: string | string[],- options?: unknown,- ): AsyncIterator<T> {- return this.pubsub.asyncIterator(topic, options);+ asyncIterator<T>(topic: string | string[]): AsyncIterator<T> {+ return this.pubsub.asyncIterator(topic);}async publish<T extends keyof TopicDef>(topic: T, payload: TopicDef[T]) {