Skip to content

Send and receive SMS messages using your Android phone programmatically via a simple HTTP API

feat(handlers): replace 1s hack with rate-based delay for bulk send

Acho Arnold8fb277ffe37a
diff --git a/api/pkg/handlers/message_handler.go b/api/pkg/handlers/message_handler.go
index 935e9ba4..9504d518 100644
--- a/api/pkg/handlers/message_handler.go
+++ b/api/pkg/handlers/message_handler.go
@@ -161,11 +161,6 @@ func (h *MessageHandler) BulkSend(c *fiber.Ctx) error {
wg.Add(1)
go func(message services.MessageSendParams, index int) {
count.Add(1)
- if message.SendAt == nil {
- sentAt := time.Now().UTC().Add(time.Duration(index) * time.Second)
- message.SendAt = &sentAt
- }
-
response, err := h.service.SendMessage(ctx, message)
if err != nil {
count.Add(-1)
diff --git a/api/pkg/requests/message_bulk_send_request.go b/api/pkg/requests/message_bulk_send_request.go
index 461ac2ed..8c7d8025 100644
--- a/api/pkg/requests/message_bulk_send_request.go
+++ b/api/pkg/requests/message_bulk_send_request.go
@@ -54,7 +54,6 @@ func (input *MessageBulkSend) ToMessageSendParams(userID entities.UserID, source
var result []services.MessageSendParams
for index, to := range input.To {
- sendAt := time.Now().UTC().Add(time.Duration(index) * time.Second)
result = append(result, services.MessageSendParams{
Source: source,
Owner: from,
@@ -63,9 +62,9 @@ func (input *MessageBulkSend) ToMessageSendParams(userID entities.UserID, source
UserID: userID,
RequestReceivedAt: time.Now().UTC(),
Contact: to,
- SendAt: &sendAt,
Content: input.Content,
Attachments: input.Attachments,
+ Index: index,
})
}