Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(cli): keep check --json stdout pure by sending proxy pre-resolve diagnostics to stderr (#3836)
miga-heygen1a619785d5ef
diff --git a/packages/cli/src/utils/checkBrowser.test.ts b/packages/cli/src/utils/checkBrowser.test.tsindex ce83152e32..d28011c78a 100644--- a/packages/cli/src/utils/checkBrowser.test.ts+++ b/packages/cli/src/utils/checkBrowser.test.ts@@ -605,16 +605,65 @@ describe("preResolveHostileMediaProxies", () => {},});mocks.resolveProxy.mockRejectedValue(new Error("ffmpeg exited with code 1"));- const infoSpy = vi.spyOn(console, "info").mockImplementation(() => undefined);+ const errorSpy = vi.spyOn(console, "error").mockImplementation(() => undefined);await expect(preResolveHostileMediaProxies(projectDir, "<html></html>"),).resolves.toBeUndefined();- expect(infoSpy).toHaveBeenCalledWith(+ expect(errorSpy).toHaveBeenCalledWith(expect.stringContaining("media proxy pre-resolve: 0/1 ready, 1 failed"),);});+ // `check --json` stdout must stay pure JSON, so these lines belong on stderr.+ it("writes the pre-resolve summary to stderr and leaves stdout untouched", async () => {+ const projectDir = mkProjectDir();+ mocks.scanProjectMediaCodecMap.mockResolvedValue({+ "/clip.mp4": {+ codecName: "hevc",+ browserHostile: true,+ representativeMime: null,+ hasAlpha: false,+ },+ });+ mocks.resolveProxy.mockResolvedValue("/cache/clip.mp4");+ const errorSpy = vi.spyOn(console, "error").mockImplementation(() => undefined);+ const infoSpy = vi.spyOn(console, "info").mockImplementation(() => undefined);+ const logSpy = vi.spyOn(console, "log").mockImplementation(() => undefined);+ const stdoutSpy = vi.spyOn(process.stdout, "write").mockImplementation(() => true);++ await preResolveHostileMediaProxies(projectDir, "<html></html>");++ expect(errorSpy).toHaveBeenCalledTimes(1);+ expect(errorSpy).toHaveBeenCalledWith(+ expect.stringMatching(+ /^\[hyperframes\] media proxy pre-resolve: 1\/1 ready, 0 failed \(\d+ms\)$/,+ ),+ );+ expect(infoSpy).not.toHaveBeenCalled();+ expect(logSpy).not.toHaveBeenCalled();+ expect(stdoutSpy).not.toHaveBeenCalled();+ });++ it("writes a scan failure to stderr and leaves stdout untouched", async () => {+ const projectDir = mkProjectDir();+ mocks.scanProjectMediaCodecMap.mockRejectedValue(new Error("ffprobe not found"));+ const errorSpy = vi.spyOn(console, "error").mockImplementation(() => undefined);+ const infoSpy = vi.spyOn(console, "info").mockImplementation(() => undefined);+ const stdoutSpy = vi.spyOn(process.stdout, "write").mockImplementation(() => true);++ await expect(+ preResolveHostileMediaProxies(projectDir, "<html></html>"),+ ).resolves.toBeUndefined();++ expect(errorSpy).toHaveBeenCalledWith(+ "[hyperframes] media proxy pre-resolve: scan failed (ffprobe not found)",+ );+ expect(infoSpy).not.toHaveBeenCalled();+ expect(stdoutSpy).not.toHaveBeenCalled();+ expect(mocks.resolveProxy).not.toHaveBeenCalled();+ });+it("pre-resolves an alpha VP9 asset through the Chromium-compatible VP8 proxy", async () => {const projectDir = mkProjectDir();mocks.scanProjectMediaCodecMap.mockResolvedValue({diff --git a/packages/cli/src/utils/checkBrowser.ts b/packages/cli/src/utils/checkBrowser.tsindex 57f5402886..c15ab95f45 100644--- a/packages/cli/src/utils/checkBrowser.ts+++ b/packages/cli/src/utils/checkBrowser.ts@@ -121,7 +121,7 @@ export async function preResolveHostileMediaProxies(try {codecMap = await scanProjectMediaCodecMap(projectDir, [{ html }]);} catch (err) {- console.info(+ console.error(`[hyperframes] media proxy pre-resolve: scan failed (${normalizeErrorMessage(err)})`,);return;@@ -142,7 +142,7 @@ export async function preResolveHostileMediaProxies(),);const failed = results.filter((result) => result.status === "rejected").length;- console.info(+ console.error(`[hyperframes] media proxy pre-resolve: ${results.length - failed}/${results.length} ready, ${failed} failed (${Date.now() - startedAt}ms)`,);}