Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(registry): clamp filmed-screen's curve and vignette (#5501)
Vance Ingalls37a79e93717b
diff --git a/registry/components/filmed-screen/README.md b/registry/components/filmed-screen/README.mdindex 16bd1a9746..efe94b00c3 100644--- a/registry/components/filmed-screen/README.md+++ b/registry/components/filmed-screen/README.md@@ -90,6 +90,13 @@ HFFilmedScreen.mount({| fadeOut | true | Fades to black over the last 0.4 s of the owning composition. || zIndex | 10 | z-index of the lens output canvas. |+**Previous look.** Before these defaults the lens used `blur: 0.9`, `rack: 0.7`, `vignette: 0.42`,+`aberration: 1`, `led: 0.9` and `curve: 0`; pass those to get close to it. Two changes have no+option and can't be restored: the LED grid now fades in only once a cell spans about 4 output+pixels, and a quarter of the fringing stays on the focused element.++`curve` is clamped at 0, and the vignette never darkens past black, so very large values are safe.+Pass `document.querySelectorAll(...)` from your own snippet rather than a selector string. Thelibrary initialises once per page, so its own `document` belongs to whichever copy loaded first;your query is scoped to your composition, which is what keeps two instances (or the samediff --git a/registry/components/filmed-screen/demo.html b/registry/components/filmed-screen/demo.htmlindex 80930c7c5b..75b0bdf5e7 100644--- a/registry/components/filmed-screen/demo.html+++ b/registry/components/filmed-screen/demo.html@@ -343,7 +343,7 @@ void main() {col *= mix(vec3(1.0), led * 1.3, ledAmt * uLed * (1.0 - 0.7 * sharp));col = col * (1.0 + uCut * 1.1) + uCut * 0.06;vec2 v = s0 * vec2(0.85, 1.15);- col *= 1.0 - uVig * dot(v, v);+ col *= max(0.0, 1.0 - uVig * dot(v, v));col *= 1.0 - (0.035 - 0.035 * sin(coord.y * 0.9 - uTime * 55.0));col += (hash(coord + frameSeed * 1.31) - 0.5) * 0.06;col *= 1.0 - uOut;@@ -781,7 +781,8 @@ void main() {gl.uniform1f(loc.uVig, opts.vignette == null ? 1.0 : opts.vignette);gl.uniform1f(loc.uCA, opts.aberration == null ? 2.2 : opts.aberration);gl.uniform1f(loc.uLed, opts.led == null ? 0.45 : opts.led);- gl.uniform1f(loc.uCurve, opts.curve == null ? 0.15 : opts.curve);+ // A negative curve would sample outside the frame and fold over.+ gl.uniform1f(loc.uCurve, Math.max(0, opts.curve == null ? 0.15 : opts.curve));gl.drawArrays(gl.TRIANGLE_STRIP, 0, 4);fs = null;return true;diff --git a/registry/components/filmed-screen/filmed-screen.html b/registry/components/filmed-screen/filmed-screen.htmlindex 7d6c66719f..c5f66e7e06 100644--- a/registry/components/filmed-screen/filmed-screen.html+++ b/registry/components/filmed-screen/filmed-screen.html@@ -191,7 +191,7 @@ void main() {col *= mix(vec3(1.0), led * 1.3, ledAmt * uLed * (1.0 - 0.7 * sharp));col = col * (1.0 + uCut * 1.1) + uCut * 0.06;vec2 v = s0 * vec2(0.85, 1.15);- col *= 1.0 - uVig * dot(v, v);+ col *= max(0.0, 1.0 - uVig * dot(v, v));col *= 1.0 - (0.035 - 0.035 * sin(coord.y * 0.9 - uTime * 55.0));col += (hash(coord + frameSeed * 1.31) - 0.5) * 0.06;col *= 1.0 - uOut;@@ -628,7 +628,8 @@ void main() {gl.uniform1f(loc.uVig, opts.vignette == null ? 1.0 : opts.vignette);gl.uniform1f(loc.uCA, opts.aberration == null ? 2.2 : opts.aberration);gl.uniform1f(loc.uLed, opts.led == null ? 0.45 : opts.led);- gl.uniform1f(loc.uCurve, opts.curve == null ? 0.15 : opts.curve);+ // A negative curve would sample outside the frame and fold over.+ gl.uniform1f(loc.uCurve, Math.max(0, opts.curve == null ? 0.15 : opts.curve));gl.drawArrays(gl.TRIANGLE_STRIP, 0, 4);fs = null;return true;diff --git a/registry/components/filmed-screen/filmed-screen.test.mjs b/registry/components/filmed-screen/filmed-screen.test.mjsindex 25d7b5ceba..9074ad9dab 100644--- a/registry/components/filmed-screen/filmed-screen.test.mjs+++ b/registry/components/filmed-screen/filmed-screen.test.mjs@@ -10,12 +10,15 @@ const library = html.match(/<script>([\s\S]*?)<\/script>/i)[1];// enough canvas/WebGL surface for mount() to build a lens. Draws are counted per lens.function page() {const draws = [];+ const uniforms = {};const gl = (id) =>new Proxy({},{get: (_, key) => {if (key === "getShaderParameter") return () => true;+ if (key === "getUniformLocation") return (_, name) => name;+ if (key === "uniform1f") return (name, v) => (uniforms[name] = v);if (key === "drawArrays") return () => draws.push(id);if (key === "getExtension") return () => null;if (typeof key === "string" && /^[A-Z0-9_]+$/.test(key)) return 1;@@ -80,7 +83,7 @@ function page() {setAttribute: (k, v) => attrs.set(k, v),};};- return { sandbox, draws, armVfx, canvas, captures: () => vfxCaptures };+ return { sandbox, draws, uniforms, armVfx, canvas, captures: () => vfxCaptures };}const shots = [{ until: 10, palette: null }];@@ -166,3 +169,11 @@ test("a draw before the scene's first paint waits for the paint instead of loggiassert.deepEqual(errors, []);assert.equal(p.draws.length, 1, "redrawn once the paint landed");});++test("a negative curve is clamped to flat instead of folding the frame", () => {+ const p = page();+ p.sandbox.HFFilmedScreen.mount({ canvas: [p.canvas()], shots, curve: -1 });+ p.sandbox.__hf.seek(0.5);+ p.sandbox.__hf_page_composite_resolve();+ assert.equal(p.uniforms.uCurve, 0);+});diff --git a/registry/components/filmed-screen/registry-item.json b/registry/components/filmed-screen/registry-item.jsonindex 7c67eaab09..afedf4caed 100644--- a/registry/components/filmed-screen/registry-item.json+++ b/registry/components/filmed-screen/registry-item.json@@ -23,5 +23,9 @@"target": "compositions/components/filmed-screen.html","type": "hyperframes:snippet"}- ]+ ],+ "preview": {+ "video": "https://static.heygen.ai/hyperframes-oss/docs/images/catalog/components/filmed-screen.mp4",+ "poster": "https://static.heygen.ai/hyperframes-oss/docs/images/catalog/components/filmed-screen.png"+ }}