Skip to content

Write HTML. Render video. Built for agents.

fix(core): a paused preview puts a reloaded video back at the playhead (#5912)

Miguel Ángel44ac4c4bbbad
diff --git a/packages/core/src/runtime/init.reloadedVideoKeepsPlayhead.test.ts b/packages/core/src/runtime/init.reloadedVideoKeepsPlayhead.test.ts
new file mode 100644
index 0000000000..b5681dc6ac
--- /dev/null
+++ b/packages/core/src/runtime/init.reloadedVideoKeepsPlayhead.test.ts
@@ -0,0 +1,61 @@
+import { afterEach, expect, it, vi } from "vitest";
+import { initSandboxRuntimeModular } from "./init";
+import { evictMediaSyncState } from "./media";
+import { createMockTimeline, resetRuntimeFixtureDom } from "./runtimeSeekFixture.test-helpers";
+
+/** A loaded, paused video whose `load()` starts it over at 0, as a browser's does. */
+function loadedVideo(el: HTMLVideoElement) {
+ Object.defineProperty(el, "duration", { value: 6.27, configurable: true });
+ Object.defineProperty(el, "readyState", { value: 4, configurable: true });
+ Object.defineProperty(el, "paused", { value: true, writable: true, configurable: true });
+ el.play = vi.fn(() => Promise.resolve());
+ el.pause = vi.fn();
+ el.load = vi.fn(() => {
+ el.currentTime = 0;
+ });
+}
+
+function reloadClipPausedAt4s() {
+ resetRuntimeFixtureDom();
+ document.body.innerHTML =
+ '<div data-composition-id="main" data-root="true" data-duration="6.27">' +
+ '<video id="clip" data-start="0" data-duration="6.27" data-track-index="0" src="/clip.mp4"></video>' +
+ '<video id="cutout" data-start="0" data-duration="6.27" data-track-index="2" muted src="/cutout.webm"></video>' +
+ "</div>";
+ const clip = document.getElementById("clip") as HTMLVideoElement;
+ const cutout = document.getElementById("cutout") as HTMLVideoElement;
+ loadedVideo(clip);
+ loadedVideo(cutout);
+ window.__timelines = { main: createMockTimeline(6.27) };
+ initSandboxRuntimeModular();
+ window.__player!.seek(4);
+ expect(clip.currentTime).toBe(4);
+ expect(cutout.currentTime).toBe(4);
+
+ evictMediaSyncState(clip);
+ clip.src = "/clip.mp4?hf-proxy=h264";
+ clip.load();
+ clip.dispatchEvent(new Event("loadedmetadata"));
+ return { clip, cutout };
+}
+
+// When the clip's authoring proxy (or that copy's larger size) loaded while paused, the clip restarted at 0 and
+// showed another moment of the person under the cutout.
+it("a paused video that loads a new source goes back to the playhead, level with its stacked twin", () => {
+ const { clip, cutout } = reloadClipPausedAt4s();
+ expect(clip.currentTime).toBe(4);
+ expect(cutout.currentTime).toBe(4);
+});
+
+it("leaves a render's videos to the render", () => {
+ window.__HF_EXPORT_RENDER_SEEK_CONFIG = { fps: 30, fpsSource: "render-options" };
+ const { clip } = reloadClipPausedAt4s();
+ expect(clip.currentTime).toBe(0);
+});
+
+afterEach(() => {
+ window.__hfRuntimeTeardown?.();
+ delete window.__HF_EXPORT_RENDER_SEEK_CONFIG;
+ vi.restoreAllMocks();
+ resetRuntimeFixtureDom();
+});
diff --git a/packages/core/src/runtime/init.ts b/packages/core/src/runtime/init.ts
index d21a57c485..fab9328bc3 100644
--- a/packages/core/src/runtime/init.ts
+++ b/packages/core/src/runtime/init.ts
@@ -67,6 +67,7 @@ import {
import {
handleErrorForProxy,
handleMetadataForProxy,
+ isRenderMode,
maybeProxyProactively,
setProxyDisplayScale,
} from "./mediaProxy";
@@ -2532,6 +2533,13 @@ export function initSandboxRuntimeModular(): void {
handleMetadataForProxy(event.currentTarget);
}
};
+ const onMediaLoadedMetadataForPlayhead = (event: Event) => {
+ const el = event.currentTarget;
+ if (state.tornDown || clock.isPlaying() || !isMediaElement(el) || isRenderMode(el)) return;
+ lastSyncedMediaTimeSeconds = null;
+ state.mediaForceSyncNextTick = true;
+ syncMediaForCurrentState();
+ };
const onMediaErrorForProxy = (event: Event) => {
if (isMediaElement(event.currentTarget)) {
handleErrorForProxy(event.currentTarget);
@@ -2561,6 +2569,7 @@ export function initSandboxRuntimeModular(): void {
mediaEl.removeEventListener("loadedmetadata", scheduleMetadataDurationHydration);
mediaEl.removeEventListener("durationchange", scheduleMetadataDurationHydration);
mediaEl.removeEventListener("loadedmetadata", onMediaLoadedMetadataForProxy);
+ mediaEl.removeEventListener("loadedmetadata", onMediaLoadedMetadataForPlayhead);
mediaEl.removeEventListener("loadedmetadata", onMediaLoadedMetadataForRoute);
mediaEl.removeEventListener("error", onMediaErrorForProxy);
metadataBoundMedia.delete(mediaEl);
@@ -2614,6 +2623,7 @@ export function initSandboxRuntimeModular(): void {
// triggers. Inert in render mode / when the codec map is absent /
// for <audio> — all guarded inside mediaProxy.ts itself.
mediaEl.addEventListener("loadedmetadata", onMediaLoadedMetadataForProxy);
+ mediaEl.addEventListener("loadedmetadata", onMediaLoadedMetadataForPlayhead);
mediaEl.addEventListener("error", onMediaErrorForProxy);
// Proactive proxy-fallback trigger: consult the codec map and swap
diff --git a/packages/core/src/runtime/mediaProxy.ts b/packages/core/src/runtime/mediaProxy.ts
index 8639b028d5..33aed24341 100644
--- a/packages/core/src/runtime/mediaProxy.ts
+++ b/packages/core/src/runtime/mediaProxy.ts
@@ -156,7 +156,7 @@ function loadProxy(
* render (the same check `syncRuntimeMedia`'s `skipForInjectedVideo` makes
* in media.ts).
*/
-function isRenderMode(el: HTMLMediaElement): boolean {
+export function isRenderMode(el: HTMLMediaElement): boolean {
if (window.__HF_EXPORT_RENDER_SEEK_CONFIG) return true;
return isVideoElement(el) && !!findInjectedRenderFrame(el);
}