Skip to content

Write HTML. Render video. Built for agents.

fix(engine): a WebGPU block mounted as a sub-composition gets WebGPU like a root one (#5735)

Miguel Ángel4e6ee6d23002
diff --git a/packages/engine/src/services/browserManager.test.ts b/packages/engine/src/services/browserManager.test.ts
index 0c0476e9ff..8f51e83c8f 100644
--- a/packages/engine/src/services/browserManager.test.ts
+++ b/packages/engine/src/services/browserManager.test.ts
@@ -263,7 +263,21 @@ describe("compositionRequiresWebGpu", () => {
).toBe(false);
});
- it("reads only the composition root tag and stays linear on repeated '<'", () => {
+ it("detects the marker on a mounted sub-composition's root in bundled HTML", () => {
+ expect(
+ compositionRequiresWebGpu(
+ '<div id="root" data-composition-id="main"><div id="aurora-host" data-composition-id="aurora">' +
+ '<div data-hf-inner-root="true" data-requires-webgpu=""><canvas data-shader="Aurora"></canvas></div></div></div>',
+ ),
+ ).toBe(true);
+ expect(
+ compositionRequiresWebGpu(
+ '<div data-composition-id="main"><div data-composition-id="scene"><div data-hf-inner-root="true"></div></div></div>',
+ ),
+ ).toBe(false);
+ });
+
+ it("reads only composition root tags and stays linear on repeated '<'", () => {
expect(
compositionRequiresWebGpu('<p data-requires-webgpu></p><div data-composition-id="a"></div>'),
).toBe(false);
diff --git a/packages/engine/src/services/browserManager.ts b/packages/engine/src/services/browserManager.ts
index d347e7aacc..4952238161 100644
--- a/packages/engine/src/services/browserManager.ts
+++ b/packages/engine/src/services/browserManager.ts
@@ -1149,11 +1149,12 @@ export function buildChromeArgs(options: BuildChromeArgsOptions, config?: GpuCon
return chromeArgs;
}
-/** Does the composition's root element declare `data-requires-webgpu`? */
+/** Does the root, or a mounted root (data-hf-inner-root once bundled), declare `data-requires-webgpu`? */
export function compositionRequiresWebGpu(html: string): boolean {
for (const tag of scanHtmlOpeningTags(html)) {
const names = tag.attributes.map((attribute) => attribute.name);
- if (names.includes("data-composition-id")) return names.includes("data-requires-webgpu");
+ const isRoot = names.includes("data-composition-id") || names.includes("data-hf-inner-root");
+ if (isRoot && names.includes("data-requires-webgpu")) return true;
}
return false;
}