Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
revert(engine): render workers keep the media of FFmpeg-fed videos loaded again (#5919)
Miguel Ángel50623ee60abc
diff --git a/packages/engine/src/services/frameCapture-releaseInjectedVideoMedia.browser.test.ts b/packages/engine/src/services/frameCapture-releaseInjectedVideoMedia.browser.test.tsdeleted file mode 100644index 2894a0371a..0000000000--- a/packages/engine/src/services/frameCapture-releaseInjectedVideoMedia.browser.test.ts+++ /dev/null@@ -1,91 +0,0 @@-import { spawnSync } from "node:child_process";-import { createServer, type ServerResponse } from "node:http";-import { afterAll, beforeAll, describe, expect, it } from "vitest";-import type { Browser } from "puppeteer-core";-import { resolveHeadlessShellPath } from "./browserManager.js";-import {- applyVideoMetadataHints,- releasableVideoIds,- releaseInjectedVideoMedia,-} from "./frameCapture.js";-import { closeTestChrome, listenOnLoopback, launchTestChrome } from "./__fixtures__/loopback.js";--const chromePath = resolveHeadlessShellPath();-const hasBrowser = chromePath !== undefined && spawnSync(chromePath, ["--version"]).status === 0;--describe("releasableVideoIds", () => {- it("keeps the media of a skipped video no poster sizes, such as a native HDR one", () => {- expect(- releasableVideoIds({- skipReadinessVideoIds: ["hdr", "sdr"],- videoMetadataHints: [{ id: "sdr", width: 640, height: 360 }],- } as Parameters<typeof releasableVideoIds>[0]),- ).toEqual(["sdr"]);- });-});--describe.skipIf(!hasBrowser)("releaseInjectedVideoMedia in Chrome", () => {- const openMedia = new Set<ServerResponse>();- let origin = "";- let browser: Browser;- const server = createServer((req, res) => {- if (req.url?.startsWith("/media/")) {- res.writeHead(200, { "Content-Type": "video/mp4" });- res.write(Buffer.alloc(1024));- openMedia.add(res);- res.on("close", () => openMedia.delete(res));- return;- }- const videos = ["a", "b", "c", "live"].map(- (id) =>- `<video id="${id}" preload="auto" src="/media/${id}.mp4" style="width:200px"></video>`,- );- res.writeHead(200, { "Content-Type": "text/html" });- res.end(`<html><body style="margin:0">${videos.join("")}</body></html>`);- });-- beforeAll(async () => {- origin = await listenOnLoopback(server);- browser = await launchTestChrome(chromePath);- });- afterAll(async () => {- for (const res of openMedia) res.destroy();- await closeTestChrome(browser);- await new Promise<void>((resolve) => server.close(() => resolve()));- });-- it("drops the media of videos whose frames come from FFmpeg and keeps their layout", async () => {- const page = await browser.newPage();- await page.goto(`${origin}/`);- const deadline = Date.now() + 10_000;- while (openMedia.size < 4 && Date.now() < deadline) {- await new Promise((resolve) => setTimeout(resolve, 50));- }- expect(openMedia.size).toBe(4);- const injected = ["a", "b", "c"];- await applyVideoMetadataHints(- page,- injected.map((id) => ({ id, width: 640, height: 360 })),- );-- await releaseInjectedVideoMedia(page, injected);-- const released = await page.evaluate((ids) => {- return ids.map((id) => {- const video = document.getElementById(id) as HTMLVideoElement;- const box = video.getBoundingClientRect();- return `${id}:${video.networkState}:${box.width}x${box.height}`;- });- }, injected);- expect(released).toEqual(["a:0:200x112.5", "b:0:200x112.5", "c:0:200x112.5"]);- const releaseDeadline = Date.now() + 10_000;- while (openMedia.size > 1 && Date.now() < releaseDeadline) {- await new Promise((resolve) => setTimeout(resolve, 50));- }- expect(openMedia.size).toBe(1);- expect(await page.$eval("#live", (video) => (video as HTMLVideoElement).currentSrc)).toBe(- `${origin}/media/live.mp4`,- );- await page.close();- }, 30_000);-});diff --git a/packages/engine/src/services/frameCapture.ts b/packages/engine/src/services/frameCapture.tsindex 36eadfef87..bc8be02e8f 100644--- a/packages/engine/src/services/frameCapture.ts+++ b/packages/engine/src/services/frameCapture.ts@@ -2218,33 +2218,6 @@ async function decodeAllImages(page: Page): Promise<void> {});}-/** Out-of-band videos a poster now sizes, so dropping their media cannot move layout. */-export function releasableVideoIds(options: CaptureOptions): string[] {- const hinted = new Set((options.videoMetadataHints ?? []).map((hint) => hint.id));- return (options.skipReadinessVideoIds ?? []).filter((id) => hinted.has(id));-}--/** FFmpeg supplies these videos' frames, so their own players would only hold decoders and buffers in every worker. */-export async function releaseInjectedVideoMedia(- page: Page,- videoIds: readonly string[],-): Promise<void> {- if (videoIds.length === 0) return;- await page.evaluate(- (ids: string[]) => {- for (const id of ids) {- const video = window.__hfMediaEl?.(id) ?? document.getElementById(id);- if (!(video instanceof HTMLVideoElement)) continue;- video.pause();- for (const source of video.querySelectorAll("source")) source.remove();- video.removeAttribute("src");- video.load();- }- },- [...videoIds],- );-}-export async function applyVideoMetadataHints(page: Page,hints: readonly CaptureVideoMetadataHint[] | undefined,@@ -2533,7 +2506,6 @@ export async function initializeSession(session: CaptureSession): Promise<void>recordSubTimelineWarning(session, pageReadyTimeout);await applyVideoMetadataHints(page, session.options.videoMetadataHints);- await releaseInjectedVideoMedia(page, releasableVideoIds(session.options));logInitPhase("applyVideoMetadataHints complete");// Run independent readiness checks in parallel — videos, images, fonts,@@ -2690,7 +2662,6 @@ export async function initializeSession(session: CaptureSession): Promise<void>recordSubTimelineWarning(session, pageReadyTimeout);await applyVideoMetadataHints(page, session.options.videoMetadataHints);- await releaseInjectedVideoMedia(page, releasableVideoIds(session.options));logInitPhase("applyVideoMetadataHints complete");// Run independent readiness checks in parallel — videos, images, fonts,@@ -3485,7 +3456,6 @@ export async function createStaticVerificationPage(session: CaptureSession): ProknownUnregisteredIds: session.subTimelineWaitMemo.unregisteredIds,});await applyVideoMetadataHints(page, session.options.videoMetadataHints);- await releaseInjectedVideoMedia(page, releasableVideoIds(session.options));const skipVideoIds = session.options.skipReadinessVideoIds ?? [];await Promise.all([diff --git a/scripts/check-no-main-deletions.mjs b/scripts/check-no-main-deletions.mjsindex bd7fcd04e9..b52e0b6db3 100644--- a/scripts/check-no-main-deletions.mjs+++ b/scripts/check-no-main-deletions.mjs@@ -1188,6 +1188,10 @@ export const ALLOWED_DELETIONS = new Map([],["scripts/prune-fallow-audit-caches.mjs", FALLOW_PRUNE_REASON],["scripts/prune-fallow-audit-caches.test.mjs", FALLOW_PRUNE_REASON],+ [+ "packages/engine/src/services/frameCapture-releaseInjectedVideoMedia.browser.test.ts",+ "the revert of #5795 removes releaseInjectedVideoMedia, the only code this file tested",+ ],]);export function parseBase(argv, fallback = "origin/main") {