Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(studio): selecting words while editing text keeps the edit open (#4738)
Miguel Ángel5470d5dea105
diff --git a/packages/studio/src/components/editor/PreviewOverlayProvider.test.tsx b/packages/studio/src/components/editor/PreviewOverlayProvider.test.tsxindex 788cea4c58..90b01fba33 100644--- a/packages/studio/src/components/editor/PreviewOverlayProvider.test.tsx+++ b/packages/studio/src/components/editor/PreviewOverlayProvider.test.tsx@@ -5,6 +5,7 @@ import { createRoot } from "react-dom/client";import { afterEach, beforeEach, describe, expect, it } from "vitest";import { GridOverlay } from "./GridOverlay";import { PreviewOverlayProvider } from "./PreviewOverlayProvider";+import { SnapToolbar } from "./SnapToolbar";import { usePreviewIframeStore } from "../../player/store/previewIframeStore";import { usePlayerStore } from "../../player/store/playerStore";@@ -92,4 +93,22 @@ describe("PreviewOverlayProvider", () => {expect(usePreviewIframeStore.getState().iframe).toBe(ownerIframe);});++ it("lets presses reach the preview beneath it, except on children that opt in", () => {+ const host = document.createElement("div");+ document.body.append(host);+ const root = createRoot(host);+ act(() => {+ root.render(+ <PreviewOverlayProvider iframe={null}>+ <SnapToolbar />+ </PreviewOverlayProvider>,+ );+ });++ const layer = host.firstElementChild;+ expect(layer?.classList.contains("pointer-events-none")).toBe(true);+ expect(layer?.firstElementChild?.classList.contains("pointer-events-auto")).toBe(true);+ act(() => root.unmount());+ });});diff --git a/packages/studio/src/components/editor/PreviewOverlayProvider.tsx b/packages/studio/src/components/editor/PreviewOverlayProvider.tsxindex 08edbec582..45a2c10b43 100644--- a/packages/studio/src/components/editor/PreviewOverlayProvider.tsx+++ b/packages/studio/src/components/editor/PreviewOverlayProvider.tsx@@ -71,7 +71,7 @@ export function PreviewOverlayProvider({ iframe, children }: PreviewOverlayProvireturn (<PreviewOverlayContext.Provider value={contextValue}>- <div ref={overlayRef} className="absolute inset-0">+ <div ref={overlayRef} className="pointer-events-none absolute inset-0">{children}</div></PreviewOverlayContext.Provider>diff --git a/packages/studio/src/components/editor/SnapToolbar.tsx b/packages/studio/src/components/editor/SnapToolbar.tsxindex a31bbfc058..267da1171b 100644--- a/packages/studio/src/components/editor/SnapToolbar.tsx+++ b/packages/studio/src/components/editor/SnapToolbar.tsx@@ -65,7 +65,7 @@ export const SnapToolbar = memo(function SnapToolbar() {return (<div- className="absolute top-2 right-2 z-50 flex items-center gap-1"+ className="pointer-events-auto absolute top-2 right-2 z-50 flex items-center gap-1"onPointerDown={(e) => e.stopPropagation()}>{motionPathCreateAvailable && (diff --git a/packages/studio/src/components/nle/PreviewOverlays.tsx b/packages/studio/src/components/nle/PreviewOverlays.tsxindex 4a4f61d25c..70efb55753 100644--- a/packages/studio/src/components/nle/PreviewOverlays.tsx+++ b/packages/studio/src/components/nle/PreviewOverlays.tsx@@ -90,7 +90,7 @@ export function PreviewOverlays({<TopologyLens iframeRef={previewIframeRef} activeCompositionPath={activeCompPath} /><CaptionOverlay iframeRef={previewIframeRef} />{/* Mode indicator + explicit exit */}- <div className="absolute top-2 left-1/2 -translate-x-1/2 z-60 flex items-center gap-2 rounded-full border border-studio-accent/40 bg-black/70 px-2.5 py-1">+ <div className="pointer-events-auto absolute top-2 left-1/2 -translate-x-1/2 z-60 flex items-center gap-2 rounded-full border border-studio-accent/40 bg-black/70 px-2.5 py-1"><span className="h-1.5 w-1.5 rounded-full bg-studio-accent" aria-hidden="true" /><span className="text-2xs text-neutral-200">Editing captions</span><button@@ -104,7 +104,7 @@ export function PreviewOverlays({{captionSyncError && (<divrole="alert"- className="absolute top-10 left-1/2 -translate-x-1/2 z-60 flex items-center gap-2 rounded-full border border-red-500/50 bg-red-950/90 px-2.5 py-1"+ className="pointer-events-auto absolute top-10 left-1/2 -translate-x-1/2 z-60 flex items-center gap-2 rounded-full border border-red-500/50 bg-red-950/90 px-2.5 py-1"><span className="text-2xs text-red-200">{captionSyncError}</span><button@@ -152,7 +152,7 @@ export function PreviewOverlays({<buttontype="button"onClick={enterCaptionMode}- className="absolute top-2 left-1/2 -translate-x-1/2 z-60 rounded-full border border-neutral-700 bg-black/60 px-2.5 py-1 text-2xs text-neutral-300 transition-colors hover:border-studio-accent/50 hover:text-studio-accent focus-visible:outline-solid focus-visible:outline-1 focus-visible:outline-studio-accent"+ className="pointer-events-auto absolute top-2 left-1/2 -translate-x-1/2 z-60 rounded-full border border-neutral-700 bg-black/60 px-2.5 py-1 text-2xs text-neutral-300 transition-colors hover:border-studio-accent/50 hover:text-studio-accent focus-visible:outline-solid focus-visible:outline-1 focus-visible:outline-studio-accent">Edit captions</button>