Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(core): a composition made only of a set shows it at a seek in the preview (#4865)
Miguel Ángel78e849235aa9
diff --git a/packages/core/src/runtime/init.test.ts b/packages/core/src/runtime/init.test.tsindex 43c1beac68..4a60c5155b 100644--- a/packages/core/src/runtime/init.test.ts+++ b/packages/core/src/runtime/init.test.ts@@ -1717,6 +1717,45 @@ describe("initSandboxRuntimeModular", () => {});});+ describe("duration floor under real GSAP", () => {+ type Timeline = ReturnType<typeof gsap.timeline>;+ const seekBoxWidthAt = (time: number, build: (box: HTMLElement) => Timeline) => {+ const root = document.createElement("div");+ root.setAttribute("data-composition-id", "main");+ root.setAttribute("data-root", "true");+ root.setAttribute("data-duration", "4");+ const box = document.createElement("div");+ box.style.width = "240px";+ root.appendChild(box);+ document.body.appendChild(root);+ const main = build(box);+ window.gsap = gsap as unknown as typeof window.gsap;+ window.__timelines = { main: main as unknown as RuntimeTimelineLike };+ initSandboxRuntimeModular();+ window.__player?.seek(time);+ return box.style.width;+ };++ it("renders a set-only root that the floor wraps", () => {+ const width = seekBoxWidthAt(1, (box) =>+ gsap.timeline({ paused: true }).set(box, { width: 340 }, 0),+ );+ expect(window.__player?.getDuration()).toBe(4);+ expect(width).toBe("340px");+ });++ it("leaves a root as long as the floor unwrapped", () => {+ let main: Timeline | undefined;+ const width = seekBoxWidthAt(1, (box) => {+ main = gsap.timeline({ paused: true }).set(box, { width: 340 }, 0).to({}, { duration: 4 });+ return main;+ });+ expect(main?.parent).toBe(gsap.globalTimeline);+ expect(main?.paused()).toBe(true);+ expect(width).toBe("340px");+ });+ });+// #6: a single timeline registered under a key that does NOT match the root's// data-composition-id must still bind (sole-timeline fallback) instead of// silently rendering the frozen t=0 DOM.diff --git a/packages/core/src/runtime/init.ts b/packages/core/src/runtime/init.tsindex 21a4dbeb07..012ec73c62 100644--- a/packages/core/src/runtime/init.ts+++ b/packages/core/src/runtime/init.ts@@ -1485,9 +1485,12 @@ export function initSandboxRuntimeModular(): void {try {fallbackTimeline.add(existingRootTimeline, 0);} catch (err) {- // keep fallback resilient if root add failsswallow("runtime.init.site2", err);}+ // A paused child never renders under its parent's seek; the wrapper drives it now.+ ensureChildCandidatesActive(+ nestedCandidates(fallbackTimeline, [{ timeline: existingRootTimeline }]),+ );}const withTween = fallbackTimeline as RuntimeTimelineLike & {to?: (target: object, vars: { duration?: number; data?: string }) => unknown;@@ -1592,11 +1595,7 @@ export function initSandboxRuntimeModular(): void {};const rootChildCandidates = collectRootChildCandidates();const ensureChildCandidatesActive = (- candidates: Array<{- compositionId: string;- timeline: RuntimeTimelineLike;- durationSeconds: number;- }>,+ candidates: Array<{ timeline: RuntimeTimelineLike }>,): void => {for (const candidate of candidates) {const timelineWithPaused = candidate.timeline as RuntimeTimelineLike & {diff --git a/packages/studio/tests/e2e/edit-accuracy/baseline.json b/packages/studio/tests/e2e/edit-accuracy/baseline.jsonindex cb5e7e57f8..6487bd1153 100644--- a/packages/studio/tests/e2e/edit-accuracy/baseline.json+++ b/packages/studio/tests/e2e/edit-accuracy/baseline.json@@ -557,7 +557,7 @@"resize-hold-center-r0-nested-z200": {"pass":true,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0.01,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":5.56,"frameP95":20.3},"resize-hold-center-r0-nested-z50": {"pass":false,"tracking":0.27,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0.07,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":8.12,"frameP95":20.31},"resize-hold-center-r0-root-z100": {"pass":false,"tracking":0.26,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":60.2,"render":50,"undo":false,"dropped":0,"controlDropped":0,"work":6.5,"frameP95":20.91},- "resize-hold-center-r0-root-z200": {"pass":false,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":60.2,"render":50,"undo":false,"dropped":0,"controlDropped":0,"work":6.59,"frameP95":19.1},+ "resize-hold-center-r0-root-z200": {"pass":true,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0.01,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":5.43,"frameP95":18.1},"resize-hold-center-r0-root-z50": {"pass":false,"tracking":0.27,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":60.21,"render":50,"undo":false,"dropped":0,"controlDropped":0,"work":5.74,"frameP95":20.21},"resize-hold-center-r30-nested-z100": {"pass":false,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0,"render":0.04,"undo":true,"dropped":0,"controlDropped":0,"work":null,"frameP95":18.41},"resize-hold-center-r30-nested-z200": {"pass":true,"tracking":0.24,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0.04,"render":0.04,"undo":true,"dropped":0,"controlDropped":0,"work":5.52,"frameP95":19.41},@@ -592,9 +592,9 @@"resize-hold-xpercent-r0-nested-z100": {"pass":true,"tracking":0.26,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":5.19,"frameP95":19.91},"resize-hold-xpercent-r0-nested-z200": {"pass":true,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0.01,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":5.41,"frameP95":19.6},"resize-hold-xpercent-r0-nested-z50": {"pass":true,"tracking":0.27,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0.07,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":5.95,"frameP95":19.11},- "resize-hold-xpercent-r0-root-z100": {"pass":false,"tracking":0.26,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":60.2,"render":50,"undo":false,"dropped":0,"controlDropped":0,"work":6.22,"frameP95":20.11},- "resize-hold-xpercent-r0-root-z200": {"pass":false,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":60.2,"render":50,"undo":false,"dropped":0,"controlDropped":0,"work":6.02,"frameP95":18.1},- "resize-hold-xpercent-r0-root-z50": {"pass":false,"tracking":0.27,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":60.21,"render":50,"undo":false,"dropped":0,"controlDropped":0,"work":5.55,"frameP95":19.21},+ "resize-hold-xpercent-r0-root-z100": {"pass":false,"tracking":0.26,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0,"render":0.02,"undo":true,"dropped":1,"controlDropped":0,"work":7.11,"frameP95":22.4},+ "resize-hold-xpercent-r0-root-z200": {"pass":true,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0.01,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":4.91,"frameP95":18.41},+ "resize-hold-xpercent-r0-root-z50": {"pass":true,"tracking":0.27,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0.07,"render":0.02,"undo":true,"dropped":0,"controlDropped":0,"work":3.28,"frameP95":17.31},"resize-hold-xpercent-r30-nested-z100": {"pass":true,"tracking":0.23,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0,"render":0.04,"undo":true,"dropped":0,"controlDropped":0,"work":4.09,"frameP95":17.7},"resize-hold-xpercent-r30-nested-z200": {"pass":true,"tracking":0.24,"pressJump":0,"teleport":true,"teleportPx":0.24,"drop":0,"reload":0.04,"render":0.04,"undo":true,"dropped":0,"controlDropped":0,"work":5.52,"frameP95":18.31},"resize-hold-xpercent-r30-nested-z50": {"pass":true,"tracking":0.31,"pressJump":0,"teleport":true,"teleportPx":0.23,"drop":0,"reload":0.07,"render":0.04,"undo":true,"dropped":0,"controlDropped":0,"work":5.43,"frameP95":19.3},