Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(studio-server): history routes say why a project's history cannot open instead of a bare 500 (#5821)
Miguel Ángel7b1b0bb005ab
diff --git a/packages/studio-server/src/routes/history.test.ts b/packages/studio-server/src/routes/history.test.tsindex b82ffcecb3..92dd0cc467 100644--- a/packages/studio-server/src/routes/history.test.ts+++ b/packages/studio-server/src/routes/history.test.ts@@ -521,6 +521,30 @@ describe("history routes", () => {const call = apiFor(tempDir("hf-history-routes-none-"));expect((await call("")).status).toBe(404);});++ it("say why when the project's history cannot open, on every route", async () => {+ const projectDir = tempDir("hf-history-routes-busy-");+ writeFileSync(join(projectDir, "index.html"), "A");+ const historyRoot = tempDir("hf-history-routes-busy-root-");+ const owner = await openProjectHistory({ projectDir, historyRoot });+ cleanup.push(() => owner.close());+ const api = createStudioApi({+ listProjects: () => [],+ resolveProject: (id: string) => (id === "demo" ? { id, dir: projectDir } : null),+ history: () => openProjectHistory({ projectDir, historyRoot, ownerWaitMs: 0 }),+ } as unknown as StudioApiAdapter);+ const busy = {+ error: `This project's history is open in another process (pid ${process.pid}).`,+ };++ const claim = await api.request("/projects/demo/history/claim", {+ method: "POST",+ body: JSON.stringify({ label: "Color", paths: ["index.html"] }),+ });+ expect([claim.status, await claim.json()]).toEqual([409, busy]);+ const blob = await api.request(`/projects/demo/history/blob/${"0".repeat(64)}`);+ expect([blob.status, await blob.json()]).toEqual([409, busy]);+ });});it("checkpoints pending writes without closing an agent window", async () => {diff --git a/packages/studio-server/src/routes/history.ts b/packages/studio-server/src/routes/history.tsindex df17f81a00..e2d6240f48 100644--- a/packages/studio-server/src/routes/history.ts+++ b/packages/studio-server/src/routes/history.ts@@ -91,16 +91,17 @@ function nextStep(history: ProjectHistory, direction: "back" | "forward") {return { id: target.id, label: target.label, endedAt: target.endedAt, paths };}-/** Runs `task` on the project's history; no history is a 404, an engine refusal ("no longer kept") a 409. */+/** Runs `task` on the project's history; no history is a 404, a refusal to open or to act ("no longer kept") a 409. */async function withHistory(adapter: StudioApiAdapter,c: Context,task: (history: ProjectHistory, body: Record<string, unknown>) => Promise<unknown> | unknown,) {- const history = await historyOf(adapter, c);- if (!history) return c.json({ error: "This project has no history here." }, 404);try {- return c.json((await task(history, await bodyOf(c))) ?? null);+ const history = await historyOf(adapter, c);+ if (!history) return c.json({ error: "This project has no history here." }, 404);+ const result = await task(history, await bodyOf(c));+ return result instanceof Response ? result : c.json(result ?? null);} catch (error) {return c.json({ error: error instanceof Error ? error.message : String(error) }, 409);}@@ -149,15 +150,17 @@ export function registerHistoryRoutes(api: Hono, adapter: StudioApiAdapter): voireturn { ok: true };}),);- api.get(`${base}/blob/:hash`, async (c) => {- const history = await historyOf(adapter, c);- const hash = c.req.param("hash") ?? "";- const missing = () =>- c.json({ error: "That file is not kept in this project's history." }, 404);- if (!history || !/^[0-9a-f]{64}$/.test(hash)) return missing();- const bytes = await history.readBlob(hash).catch(() => null);- return bytes ? c.body(new Uint8Array(bytes)) : missing();- });+ api.get(`${base}/blob/:hash`, (c) =>+ withHistory(adapter, c, async (history) => {+ const hash = c.req.param("hash") ?? "";+ const bytes = /^[0-9a-f]{64}$/.test(hash)+ ? await history.readBlob(hash).catch(() => null)+ : null;+ return bytes+ ? c.body(new Uint8Array(bytes))+ : c.json({ error: "That file is not kept in this project's history." }, 404);+ }),+ );// Studio records after it writes, under the edit's label; a gesture with no idleMs holds until another key.api.post(`${base}/claim`, (c) =>withHistory(adapter, c, async (history, body) => {