Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(producer): exports no longer fail on a video clip outside the composition's length (#5431)
Miguel Ángel81f60dbc9850
diff --git a/packages/engine/src/index.ts b/packages/engine/src/index.tsindex 674f23c9c1..69d284b9cf 100644--- a/packages/engine/src/index.ts+++ b/packages/engine/src/index.ts@@ -204,6 +204,7 @@ export {parseImageElements,extractVideoFramesRange,extractAllVideoFrames,+ isVideoPastTimelineEnd,resolveTimelineExtractionWindow,resolveVideoExtractionWindow,resolveFinalFrameExtractionWindow,diff --git a/packages/engine/src/services/videoFrameExtractor.ts b/packages/engine/src/services/videoFrameExtractor.tsindex 76e9ea43cd..e5c9aac861 100644--- a/packages/engine/src/services/videoFrameExtractor.ts+++ b/packages/engine/src/services/videoFrameExtractor.ts@@ -1348,6 +1348,10 @@ function canHoldFinalFramePastEof(video: TimelineWindowVideo): boolean {// one frame, while FFmpeg seeks to the separately probed real frame timestamp.const FINAL_FRAME_LOGICAL_DURATION_SECONDS = 1e-6;+export function isVideoPastTimelineEnd(video: Pick<VideoElement, "start">, timelineEnd: number) {+ return video.start >= timelineEnd;+}+/** Move a clip to its extraction window; a rate lane is shifted so it keeps integrating from the new origin. */export function rebaseVideoToWindow(video: VideoElement, window: TimelineExtractionWindow): void {if (window.preserveTimelinePhase) return;@@ -1868,7 +1872,9 @@ export async function extractAllVideoFrames(const warnedSrcs = new Set<string>();for (const video of videos) {if (signal?.aborted) break;- if (options.timelineEnd !== undefined && video.start >= options.timelineEnd) continue;+ if (options.timelineEnd !== undefined && isVideoPastTimelineEnd(video, options.timelineEnd)) {+ continue;+ }try {let videoPath = video.src;if (!isHttpUrl(videoPath)) {diff --git a/packages/producer/src/services/render/stages/extractVideosStage.timelineBound.test.ts b/packages/producer/src/services/render/stages/extractVideosStage.timelineBound.test.tsindex d16a2ef5e7..e4eaf73019 100644--- a/packages/producer/src/services/render/stages/extractVideosStage.timelineBound.test.ts+++ b/packages/producer/src/services/render/stages/extractVideosStage.timelineBound.test.ts@@ -12,6 +12,7 @@ const extractionCalls = vi.hoisted();const toneMapHdrToSdrCalls = vi.hoisted(() => new Array<boolean | undefined>());const contentKeyedDirsCalls = vi.hoisted(() => new Array<readonly string[] | undefined>());+const requestedVideoIds = vi.hoisted(() => new Array<string[]>());const fixtureState = vi.hoisted(() => ({ sourceDurationSeconds: 60 }));vi.mock("@hyperframes/engine", async (importOriginal) => {@@ -27,6 +28,7 @@ vi.mock("@hyperframes/engine", async (importOriginal) => {contentKeyedDirs?: readonly string[];},): Promise<ExtractionResult> => {+ requestedVideoIds.push(videos.map((v) => v.id));const sourceDurationSeconds = fixtureState.sourceDurationSeconds;const video = videos[0];if (!video) throw new Error("timeline-bound fixture requires one video");@@ -80,8 +82,8 @@ import { runExtractVideosStage } from "./extractVideosStage.js";async function runStage(compositionDuration: number,materializeSymlinks: boolean,- options: { source?: string; log?: ProducerLogger } = {},-): Promise<void> {+ options: { source?: string; log?: ProducerLogger; extraVideos?: VideoElement[] } = {},+): Promise<VideoElement[]> {const composition = {duration: compositionDuration,videos: [@@ -94,6 +96,7 @@ async function runStage(loop: false,hasAudio: false,},+ ...(options.extraVideos ?? []),],audios: [],images: [],@@ -115,6 +118,7 @@ async function runStage(assertNotAborted: () => {},materializeSymlinks,});+ return composition.videos;}describe.each([@@ -150,6 +154,32 @@ describe.each([expect(toneMapHdrToSdrCalls).toEqual([true]);});+ it("drops clips starting at or after the end before extraction, keeping natural-length ones", async () => {+ requestedVideoIds.splice(0);+ const outside = (id: string, start: number, end: number): VideoElement => ({+ id,+ src: "outside.mp4",+ start,+ end,+ mediaStart: 0,+ loop: false,+ hasAudio: false,+ });++ const videos = await runStage(2, materializeSymlinks, {+ extraVideos: [+ outside("after-end", 2, 4),+ outside("just-before-end", 1.99, 0),+ outside("natural-length", 0, 0),+ outside("negative-natural-length", -1, 0),+ ],+ });++ const kept = ["root-video", "just-before-end", "natural-length", "negative-natural-length"];+ expect(requestedVideoIds).toEqual([kept]);+ expect(videos.map((v) => v.id)).toEqual(kept);+ });+it("caches the compiled remote-media copies by content", async () => {contentKeyedDirsCalls.splice(0);diff --git a/packages/producer/src/services/render/stages/extractVideosStage.ts b/packages/producer/src/services/render/stages/extractVideosStage.tsindex 877b602cfd..5208f5fac5 100644--- a/packages/producer/src/services/render/stages/extractVideosStage.ts+++ b/packages/producer/src/services/render/stages/extractVideosStage.ts@@ -45,6 +45,7 @@ import {detectTransfer,extractAllVideoFrames,extractMediaMetadata,+ isVideoPastTimelineEnd,isHdrColorSpace,resolveProjectRelativeSrc,runVideoExtractionWithRetry,@@ -389,6 +390,9 @@ export async function runExtractVideosStage(const stage2Start = Date.now();const extractionPolicy = resolveVideoExtractionPolicy();+ composition.videos = composition.videos.filter(+ (video) => !isVideoPastTimelineEnd(video, composition.duration),+ );let frameLookup: FrameLookupTable | null = null;let extractionResult: Awaited<ReturnType<typeof extractAllVideoFrames>> | null = null;