Skip to content

Write HTML. Render video. Built for agents.

fix(studio): dragging a Layers row no longer highlights the row names (#5104)

Miguel Ángel8b5b012e5c0b
diff --git a/packages/studio/src/components/editor/LayersPanel.test.ts b/packages/studio/src/components/editor/LayersPanel.test.ts
index 033eb98aa4..e93e9c1e78 100644
--- a/packages/studio/src/components/editor/LayersPanel.test.ts
+++ b/packages/studio/src/components/editor/LayersPanel.test.ts
@@ -306,4 +306,29 @@ describe("LayersPanel preview promotion", () => {
expect(collectedRootIds()).toEqual(["a"]);
fetchSpy.mockRestore();
});
+
+ it("a row press starts no text selection, so dragging a row leaves no letters highlighted", () => {
+ const doc = new Window().document;
+ doc.body.innerHTML = `<div data-composition-id="a"><div id="back"></div><div id="front"></div></div>`;
+ const iframe = document.createElement("iframe");
+ Object.defineProperty(iframe, "contentDocument", { value: doc });
+ const item = (id: string) =>
+ ({
+ key: id,
+ element: doc.getElementById(id),
+ label: id,
+ depth: 0,
+ childCount: 0,
+ id,
+ }) as unknown as DomEditLayerItem;
+ mocks.collect.mockReset().mockReturnValue([item("back"), item("front")]);
+ mocks.previewIframeRef.current = iframe;
+ usePreviewIframeStore.setState({ iframe });
+ act(() => root.render(createElement(LayersPanel)));
+ act(() => void iframe.dispatchEvent(new Event("load")));
+
+ const rows = [...host.querySelectorAll("[data-layer-index]")];
+ expect(rows).toHaveLength(2);
+ expect(rows.every((row) => row.closest(".select-none"))).toBe(true);
+ });
});
diff --git a/packages/studio/src/components/editor/LayersPanel.tsx b/packages/studio/src/components/editor/LayersPanel.tsx
index 2199a8ab19..06ae66c3fe 100644
--- a/packages/studio/src/components/editor/LayersPanel.tsx
+++ b/packages/studio/src/components/editor/LayersPanel.tsx
@@ -433,7 +433,7 @@ export const LayersPanel = memo(function LayersPanel({ host }: { host?: LayersPa
</div>
<div
ref={scrollContainerRef}
- className="relative min-h-0 flex-1 overflow-y-auto py-1"
+ className="relative min-h-0 flex-1 select-none overflow-y-auto py-1"
onPointerMove={handleContainerPointerMove}
onPointerUp={handleContainerPointerUp}
onPointerCancel={handleContainerPointerUp}