Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(lint): ignore attribute values when checking media attributes (#4396)
lorenzozane924b93345664
diff --git a/packages/lint/src/rules/media.test.ts b/packages/lint/src/rules/media.test.tsindex ab940d8d95..81054940fb 100644--- a/packages/lint/src/rules/media.test.ts+++ b/packages/lint/src/rules/media.test.ts@@ -2,6 +2,40 @@ import { describe, it, expect } from "vitest";import { lintHyperframeHtml } from "../hyperframeLinter.js";describe("media rules", () => {+ it.each([+ 'title="an unmuted muted crossorigin clip"',+ "title='an unmuted muted crossorigin clip'",+ ])("does not treat words in %s as media attributes", async (tooltip) => {+ const html = `+<html><body>+ <div id="root" data-composition-id="c1" data-width="1920" data-height="1080">+ <video id="v1" ${tooltip} src="a.mp4" data-start="0" data-duration="3"></video>+ <audio id="a1" src="a.mp4" data-start="0" data-duration="3"></audio>+ </div>+</body></html>`;+ const result = await lintHyperframeHtml(html);+ const codes = result.findings.map((finding) => finding.code);++ expect(codes).toContain("video_missing_muted");+ expect(codes).toContain("video_audio_double_source");+ expect(codes).not.toContain("media_crossorigin_breaks_preview");+ });++ it.each(["muted", 'muted=""', 'muted="false"', "MUTED"])(+ "keeps %s as a present Boolean attribute",+ async (mutedAttr) => {+ const html = `+<html><body>+ <div id="root" data-composition-id="c1" data-width="1920" data-height="1080">+ <video id="v1" ${mutedAttr} src="a.mp4" data-start="0" data-duration="3"></video>+ </div>+</body></html>`;+ const result = await lintHyperframeHtml(html);++ expect(result.findings.some((finding) => finding.code === "video_missing_muted")).toBe(false);+ },+ );+it("reports error for duplicate media ids", async () => {const html = `<html><body>diff --git a/packages/lint/src/utils.ts b/packages/lint/src/utils.tsindex 57f0fc0bc4..a34397ae6c 100644--- a/packages/lint/src/utils.ts+++ b/packages/lint/src/utils.ts@@ -234,9 +234,7 @@ export function readAttr(tagSource: string, attr: string): string | null {}export function hasAttrName(tagSource: string, attr: string): boolean {- const escaped = attr.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");- const attrs = tagSource.replace(/^<\s*[a-z][\w:-]*/i, "");- return new RegExp(`(?:^|\\s)${escaped}(?:\\s*=|\\s|/?>)`, "i").test(attrs);+ return readDecodedAttr(tagSource, attr) !== null;}// An explicit data-has-audio is authoritative for the compiler; only the exact value "true" means audible.