Skip to content

Write HTML. Render video. Built for agents.

fix(cli): check audits a color-graded video's canvas as the video it shows (#5963)

Miguel Ángel9f793a6dbd42
diff --git a/packages/cli/src/commands/layout-audit.browser.js b/packages/cli/src/commands/layout-audit.browser.js
index 235733f938..ca1873a0ad 100644
--- a/packages/cli/src/commands/layout-audit.browser.js
+++ b/packages/cli/src/commands/layout-audit.browser.js
@@ -107,20 +107,29 @@
return `${uniqueSelectorFor(parent)} > ${element.tagName.toLowerCase()}:nth-of-type(${index})`;
}
+ // Color grading paints an <img>/<video> into a canvas the runtime inserts right after it; that canvas answers
+ // to the element the author wrote. ponytail: render-frame siblings sit between them only in render, not check.
+ const GRADED_STAND_IN = "[data-hf-color-grading-canvas]";
+ function authoredElement(element) {
+ return (element.matches(GRADED_STAND_IN) && element.previousElementSibling) || element;
+ }
+
function hasIgnoreFlag(element) {
- return !!element.closest("[data-layout-ignore], [data-layout-check='ignore']");
+ return !!authoredElement(element).closest("[data-layout-ignore], [data-layout-check='ignore']");
}
function hasAllowOverflowFlag(element) {
- return !!element.closest("[data-layout-allow-overflow]");
+ return !!authoredElement(element).closest("[data-layout-allow-overflow]");
}
function hasAllowCaptionZoneFlag(element) {
- return !!element.closest("[data-layout-allow-caption-zone]");
+ return !!authoredElement(element).closest("[data-layout-allow-caption-zone]");
}
function hasTextClipOptOut(element) {
- return hasAllowOverflowFlag(element) || element.hasAttribute("data-layout-bleed");
+ return (
+ hasAllowOverflowFlag(element) || authoredElement(element).hasAttribute("data-layout-bleed")
+ );
}
function opacityChain(element) {
@@ -1935,6 +1944,8 @@
function canvasEdgeIssues(root, rootRect, time, tolerance) {
const issues = [];
for (const canvas of Array.from(root.querySelectorAll("canvas"))) {
+ // A graded stand-in shows the author's media, not drawn art; the media itself is never read here.
+ if (canvas.matches(GRADED_STAND_IN)) continue;
if (!isVisibleElement(canvas) || hasAllowOverflowFlag(canvas)) continue;
if (!canvas.width || !canvas.height) continue;
const rect = toRect(canvas.getBoundingClientRect());
diff --git a/packages/cli/src/commands/layout-audit.browser.test.ts b/packages/cli/src/commands/layout-audit.browser.test.ts
index 7184a7787f..b00daa6144 100644
--- a/packages/cli/src/commands/layout-audit.browser.test.ts
+++ b/packages/cli/src/commands/layout-audit.browser.test.ts
@@ -1244,10 +1244,10 @@ describe("layout-audit.browser coordinate-frame findings", () => {
return drawImage;
}
- function mountCanvas(canvasRect: DOMRect, attributes = ""): void {
+ function mountCanvas(canvasRect: DOMRect, attributes = "", before = ""): void {
document.body.innerHTML = `
<div id="root" data-composition-id="main" data-width="1920" data-height="1080">
- <canvas id="art" width="1920" height="1080" ${attributes}></canvas>
+ ${before}<canvas id="art" width="1920" height="1080" ${attributes}></canvas>
</div>
`;
installGeometry({
@@ -1305,6 +1305,42 @@ describe("layout-audit.browser coordinate-frame findings", () => {
expect(runAudit().some((issue) => issue.code === "canvas_content_at_edge")).toBe(false);
});
+ it("reads a color-graded video's stand-in canvas as the video, not as drawn art", () => {
+ const drawImage = stubEdgeReads(CUT_TEXT);
+ mountCanvas(FULL_FRAME, "data-hf-color-grading-canvas", '<video id="clip"></video>');
+
+ expect(runAudit().some((issue) => issue.code === "canvas_content_at_edge")).toBe(false);
+ expect(drawImage).not.toHaveBeenCalled();
+ });
+
+ it.each([
+ ["flags", "", true],
+ ["clears", "data-layout-allow-overflow", false],
+ ])(
+ "%s a graded video's canvas overflowing a clipping wrapper, per the video's own flag",
+ (_, flag, flagged) => {
+ document.body.innerHTML = `
+ <div id="root" data-composition-id="main" data-width="1920" data-height="1080">
+ <div id="frame">
+ <video id="clip" ${flag}></video><canvas id="art" data-hf-color-grading-canvas></canvas>
+ </div>
+ </div>
+ `;
+ installGeometry(
+ {
+ root: FULL_FRAME,
+ frame: rect({ left: 0, top: 0, width: 960, height: 540 }),
+ art: rect({ left: -48, top: -27, width: 1056, height: 594 }),
+ },
+ { frame: { overflow: "hidden" } },
+ );
+ installAuditScript();
+
+ const overflow = runAudit().filter((issue) => issue.code === "container_overflow");
+ expect(overflow.map((issue) => issue.selector)).toEqual(flagged ? ["#art"] : []);
+ },
+ );
+
it("never reads a canvas that sits inside the frame", () => {
const drawImage = stubEdgeReads(CUT_TEXT);
mountCanvas(rect({ left: 200, top: 200, width: 800, height: 450 }));