Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(engine): keep beginframe when a passed probe's page close is slow (#6037)
Miguel Ángela8b576d15610
diff --git a/packages/engine/src/services/browserManager.test.ts b/packages/engine/src/services/browserManager.test.tsindex e9248ec5f5..4525713d25 100644--- a/packages/engine/src/services/browserManager.test.ts+++ b/packages/engine/src/services/browserManager.test.ts@@ -112,6 +112,30 @@ describe("BeginFrame capability probe", () => {expect(close).toHaveBeenCalledOnce();});+ it("keeps a passed probe supported when its page close is slow", async () => {+ const png = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]);+ const send = vi+ .fn()+ .mockResolvedValueOnce({})+ .mockResolvedValueOnce({})+ .mockResolvedValueOnce({ hasDamage: true, screenshotData: png.toString("base64") });+ const browser = {+ newPage: vi.fn().mockResolvedValue({+ goto: vi.fn().mockResolvedValue(null),+ createCDPSession: vi.fn().mockResolvedValue({+ send,+ detach: vi.fn().mockResolvedValue(undefined),+ }),+ close: vi.fn().mockReturnValue(new Promise<never>(() => {})),+ }),+ } as unknown as Browser;++ const result = await _probeBeginFrameSupportForTests(browser);++ expect(result.supported).toBe(true);+ expect(result.detail).toContain("probe page cleanup timed out");+ });+it("force-kills and disconnects when graceful browser cleanup never resolves", async () => {const kill = vi.fn();const disconnect = vi.fn().mockResolvedValue(undefined);diff --git a/packages/engine/src/services/browserManager.ts b/packages/engine/src/services/browserManager.tsindex eb85e92dbe..652ae94c76 100644--- a/packages/engine/src/services/browserManager.ts+++ b/packages/engine/src/services/browserManager.ts@@ -511,11 +511,7 @@ async function probeBeginFrameSupport(};}if (page && !(await settleWithin(page.close(), BEGINFRAME_PROBE_CLEANUP_TIMEOUT_MS))) {- return {- supported: false,- detail: `${result.detail}; probe page cleanup timed out`,- durationMs: Date.now() - started,- };+ return { ...result, detail: `${result.detail}; probe page cleanup timed out` };}return result;}