Write HTML. Render video. Built for agents.
JavaScript aiai-agentsanimationclaude-codeffmpegframeworkgsaphtmlhtml-to-videomcpmotion-graphicspuppeteerrenderingtypescriptvideo-editor
fix(producer): a blank media src is no source instead of the page itself (#6121)
Miguel Ángelc4c1e621d428
diff --git a/packages/producer/src/services/htmlCompiler.test.ts b/packages/producer/src/services/htmlCompiler.test.tsindex 20f5973ffa..a25b2ccfcc 100644--- a/packages/producer/src/services/htmlCompiler.test.ts+++ b/packages/producer/src/services/htmlCompiler.test.ts@@ -120,6 +120,33 @@ describe("discoverMediaFromBrowser", () => {});});+ it("reports no source for a blank src even though the browser resolves it to the page URL", async () => {+ const { document } = parseHTML(+ `<video id="empty" src="" data-start="0" data-end="1"></video>+ <video id="real" src="clip.mp4" data-start="0" data-end="1"></video>`,+ );+ const resolved = {+ empty: "http://localhost:4000/index.html",+ real: "http://localhost:4000/clip.mp4",+ };+ for (const [id, value] of Object.entries(resolved)) {+ const element = document.getElementById(id);+ if (element) Object.defineProperty(element, "src", { value });+ }+ const previousDocument = Reflect.get(globalThis, "document");+ Reflect.set(globalThis, "document", document);+ try {+ const media = await discoverMediaFromBrowser({+ evaluate: async (collect) => collect(),+ } as never);+ expect(media.find((item) => item.id === "empty")?.src).toBe("");+ expect(media.find((item) => item.id === "real")?.src).toBe("http://localhost:4000/clip.mp4");+ } finally {+ if (previousDocument === undefined) Reflect.deleteProperty(globalThis, "document");+ else Reflect.set(globalThis, "document", previousDocument);+ }+ });+it("keeps strict timing parsing self-contained after Puppeteer serializes the callback", async () => {const media = await discover('<video id="clip" src="clip.mp4" data-start="0" data-end="2" data-duration="2" data-media-start="1"></video>',diff --git a/packages/producer/src/services/htmlCompiler.ts b/packages/producer/src/services/htmlCompiler.tsindex cc66a131a0..9b892a49b4 100644--- a/packages/producer/src/services/htmlCompiler.ts+++ b/packages/producer/src/services/htmlCompiler.ts@@ -2341,7 +2341,10 @@ export async function discoverMediaFromBrowser(page: Page): Promise<BrowserMediaif (!id) return;// currentSrc is authoritative for <video>/<audio><source> and responsive images.- const src = htmlEl.currentSrc || htmlEl.src || htmlEl.getAttribute("src") || "";+ const ownSrc = htmlEl.getAttribute("src");+ const blankSrc =+ ownSrc !== null && ownSrc.trim() === "" && !htmlEl.querySelector("source[src]");+ const src = blankSrc ? "" : htmlEl.currentSrc || htmlEl.src || ownSrc || "";const start = parseFloat(htmlEl.getAttribute("data-start") || "0");const endRaw = htmlEl.getAttribute("data-end");const durationRaw = htmlEl.getAttribute("data-duration");