Skip to content

Write HTML. Render video. Built for agents.

fix(studio): undo that reloads the preview keeps the timeline clips on screen (#4790)

Miguel Ángeld4176c4ce6ee
diff --git a/packages/studio/src/hooks/usePreviewPersistence.history.test.tsx b/packages/studio/src/hooks/usePreviewPersistence.history.test.tsx
new file mode 100644
index 0000000000..91f0c18f73
--- /dev/null
+++ b/packages/studio/src/hooks/usePreviewPersistence.history.test.tsx
@@ -0,0 +1,47 @@
+// @vitest-environment happy-dom
+
+import React, { act } from "react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { usePlayerStore } from "../player/store/playerStore";
+import type { TimelineElement } from "../player/store/timelineElement";
+import { mountReactHarness } from "./domSelectionTestHarness";
+import { usePreviewPersistence } from "./usePreviewPersistence";
+
+(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
+
+afterEach(() => {
+ document.body.innerHTML = "";
+ usePlayerStore.getState().reset();
+});
+
+describe("undo that reloads the preview", () => {
+ it("keeps the timeline's clips until the reloaded preview reports its own", async () => {
+ const clips = [{ id: "a" }, { id: "b" }] as unknown as TimelineElement[];
+ usePlayerStore.getState().setElements(clips);
+ usePlayerStore.getState().setTimelineReady(true);
+ const reloadPreview = vi.fn();
+ let sync: ReturnType<typeof usePreviewPersistence>["syncHistoryPreviewAfterApply"] | null =
+ null;
+ function Harness() {
+ sync = usePreviewPersistence({
+ showToast: () => {},
+ readOptionalProjectFile: async () => "",
+ writeProjectFile: async () => {},
+ recordEdit: async () => {},
+ previewIframeRef: { current: null },
+ activeCompPathRef: { current: "index.html" },
+ reloadPreview,
+ }).syncHistoryPreviewAfterApply;
+ return null;
+ }
+ mountReactHarness(<Harness />);
+
+ // A nested composition's undo is not the active file's, so it reloads the preview.
+ const files = { "compositions/sub.html": { previous: "<p>1</p>", restored: "<p>2</p>" } };
+ await act(async () => sync!({ paths: Object.keys(files), files }));
+
+ expect(reloadPreview).toHaveBeenCalledTimes(1);
+ const player = usePlayerStore.getState();
+ expect([player.elements, player.timelineReady]).toEqual([clips, true]);
+ });
+});
diff --git a/packages/studio/src/hooks/usePreviewPersistence.ts b/packages/studio/src/hooks/usePreviewPersistence.ts
index 913614a31b..3b6144ab62 100644
--- a/packages/studio/src/hooks/usePreviewPersistence.ts
+++ b/packages/studio/src/hooks/usePreviewPersistence.ts
@@ -207,16 +207,13 @@ export function usePreviewPersistence({
reloadPreview,
);
if (strategy === "full") {
- const player = usePlayerStore.getState();
- player.setElements([]);
- player.setSelectedElementId(null);
- player.setTimelineReady(false);
+ usePlayerStore.getState().setSelectedElementId(null);
return;
}
// A soft restore patched the reverted attributes onto the live preview, but the
// player store keeps its own copy and that copy is what the automation lanes
// draw — so without this an undone envelope edit stayed invisible until a
- // reload. The full path above clears the store and waits for discovery instead.
+ // reload. The full path above waits for the reloaded preview to report instead.
syncStoredAutomationFromPreview(previewIframeRef.current?.contentDocument ?? null);
},
[previewIframeRef, activeCompPathRef, reloadPreview],