Skip to content

Write HTML. Render video. Built for agents.

fix(producer): honor FFMPEG_PROCESS_TIMEOUT_MS during video-frame extraction (#3918)

miga-heygene0d4c9600335
diff --git a/packages/producer/src/services/render/stages/extractVideosStage.ffmpegTimeout.test.ts b/packages/producer/src/services/render/stages/extractVideosStage.ffmpegTimeout.test.ts
new file mode 100644
index 0000000000..cff87e99c2
--- /dev/null
+++ b/packages/producer/src/services/render/stages/extractVideosStage.ffmpegTimeout.test.ts
@@ -0,0 +1,109 @@
+import { resolveConfig, type EngineConfig, type ExtractionResult } from "@hyperframes/engine";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+/** The optional engine-config argument the stage passes to `extractAllVideoFrames`. */
+type ExtractionConfigArg = Partial<EngineConfig> | undefined;
+
+const capturedConfigs = vi.hoisted(() => new Array<ExtractionConfigArg>());
+
+vi.mock("@hyperframes/engine", async (importOriginal) => {
+ const real = await importOriginal<typeof import("@hyperframes/engine")>();
+ return {
+ ...real,
+ extractAllVideoFrames: async (
+ _videos: unknown,
+ _baseDir: unknown,
+ _options: unknown,
+ _signal: unknown,
+ config: ExtractionConfigArg,
+ ): Promise<ExtractionResult> => {
+ capturedConfigs.push(config);
+ return {
+ success: true,
+ extracted: [],
+ errors: [],
+ totalFramesExtracted: 0,
+ durationMs: 0,
+ phaseBreakdown: {
+ resolveMs: 0,
+ cachePublishFailures: 0,
+ cacheGcEvictions: 0,
+ cacheGcBytesFreed: 0,
+ cacheAgedPartialsCleared: 0,
+ hdrProbeMs: 0,
+ hdrPreflightMs: 0,
+ hdrPreflightCount: 0,
+ vfrProbeMs: 0,
+ vfrPreflightMs: 0,
+ vfrPreflightCount: 0,
+ extractMs: 0,
+ cacheHits: 0,
+ cacheMisses: 0,
+ transientRetries: 0,
+ },
+ };
+ },
+ };
+});
+
+import { createRenderJob } from "../../renderOrchestrator.js";
+import { runExtractVideosStage } from "./extractVideosStage.js";
+
+async function runStage(cfg: EngineConfig): Promise<void> {
+ const composition = {
+ duration: 5,
+ videos: [
+ {
+ id: "root-video",
+ src: "clip.mp4",
+ start: 0,
+ end: 5,
+ mediaStart: 0,
+ loop: false,
+ hasAudio: false,
+ },
+ ],
+ audios: [],
+ images: [],
+ width: 1920,
+ height: 1080,
+ };
+ await runExtractVideosStage({
+ projectDir: "/tmp/hf-ffmpeg-timeout-project",
+ compiledDir: "/tmp/hf-ffmpeg-timeout-compiled",
+ job: createRenderJob({
+ fps: { num: 30, den: 1 },
+ quality: "standard",
+ hdrMode: "force-sdr",
+ }),
+ cfg,
+ composition,
+ abortSignal: undefined,
+ assertNotAborted: () => {},
+ materializeSymlinks: false,
+ });
+}
+
+describe("video extraction ffmpeg timeout threading", () => {
+ beforeEach(() => {
+ capturedConfigs.splice(0);
+ });
+
+ it("forwards every resolved extraction setting, including FFMPEG_PROCESS_TIMEOUT_MS", async () => {
+ await runStage(
+ resolveConfig({
+ ffmpegProcessTimeout: 5_000,
+ extractCacheDir: "/tmp/hf-ffmpeg-timeout-cache",
+ extractCacheMaxBytes: 1234,
+ }),
+ );
+
+ expect(capturedConfigs).toEqual([
+ expect.objectContaining({
+ ffmpegProcessTimeout: 5_000,
+ extractCacheDir: "/tmp/hf-ffmpeg-timeout-cache",
+ extractCacheMaxBytes: 1234,
+ }),
+ ]);
+ });
+});
diff --git a/packages/producer/src/services/render/stages/extractVideosStage.ts b/packages/producer/src/services/render/stages/extractVideosStage.ts
index a2c27774d8..adb435b972 100644
--- a/packages/producer/src/services/render/stages/extractVideosStage.ts
+++ b/packages/producer/src/services/render/stages/extractVideosStage.ts
@@ -503,7 +503,7 @@ export async function runExtractVideosStage(
collectProbeFailures: extractionPolicy.failureMode === "enforce",
},
abortSignal,
- { extractCacheDir: cfg.extractCacheDir, extractCacheMaxBytes: cfg.extractCacheMaxBytes },
+ cfg,
compiledDir,
);
extractionResult.phaseBreakdown.transientRetries =