Skip to content

armgit / hypit

Public Imported from GitHub
0

Clone any viral video with AI agents. Not just a script, the whole workflow: swap the face, the words, the B-roll, ship 100 variants in one command, and get your 100M views.

fix(caption): style non-contiguous role cues

kashorinfcc11e8ce052
diff --git a/packages/caption/src/style.ts b/packages/caption/src/style.ts
index a3d7126b..58a477d0 100644
--- a/packages/caption/src/style.ts
+++ b/packages/caption/src/style.ts
@@ -3,7 +3,6 @@ import { canonicalStringify, canonicalize } from "@hypit/protocol";
import {
assertCaptionDocument,
- assertCaptionUnitSubset,
captionUnitsForRole,
type CaptionUnitSubset,
} from "./display.js";
@@ -78,8 +77,15 @@ export function assertCaptionProgramForDocument(value: CaptionProgram, document:
"Caption Program styles an unknown display word");
}
-function subset(value: CaptionUnitSubset, document: CaptionDocument): string[] {
- assertCaptionUnitSubset(value, document);
+function orderedSubset(value: CaptionUnitSubset, document: CaptionDocument): string[] {
+ assertCaptionDocument(document);
+ assert(value.documentId === document.id, "Caption unit subset belongs to another document");
+ const order = new Map(document.units.map((unit, index) => [unit.id, index]));
+ const indices = value.unitIds.map((id) => order.get(id));
+ assert(indices.length > 0 && indices.every((index) => index !== undefined),
+ "Caption unit subset contains an unknown unit");
+ assert(indices.every((index, position) => position === 0 || index! > indices[position - 1]!),
+ "Caption unit subset must be ordered and contain no repeated unit");
return [...value.unitIds];
}
@@ -98,7 +104,7 @@ export function resolveCaptionProgram(
const selected = applications.map((application) => {
assert(ID.test(application.id), "Caption Style Application identity is invalid");
assertCaptionStyle(application.style);
- const unitIds = subset({ documentId: document.id, unitIds: application.unitIds }, document);
+ const unitIds = orderedSubset({ documentId: document.id, unitIds: application.unitIds }, document);
const previous = styles.get(application.style.id);
assert(previous === undefined || canonicalStringify(previous) === canonicalStringify(application.style),
`Caption Style ${application.style.id} has conflicting definitions`);
@@ -107,7 +113,7 @@ export function resolveCaptionProgram(
});
const muted = mutes.flatMap((application) => {
assert(ID.test(application.id), "Caption Mute identity is invalid");
- return subset({ documentId: document.id, unitIds: application.unitIds }, document);
+ return orderedSubset({ documentId: document.id, unitIds: application.unitIds }, document);
});
const wordChosen = new Map<string, string>();
for (const application of wordApplications) {
diff --git a/packages/caption/test/caption.test.ts b/packages/caption/test/caption.test.ts
index 0672b9db..8b2eed9e 100644
--- a/packages/caption/test/caption.test.ts
+++ b/packages/caption/test/caption.test.ts
@@ -4,6 +4,7 @@ import test from "node:test";
import { canonicalize } from "@hypit/protocol";
import {
assertCaptionProgramForDocument,
+ captionUnitsForRole,
captionUnitsForSelection,
resolveCaptionProgram,
sealCaptionStyle,
@@ -24,6 +25,23 @@ test("Caption uses complete semantic selections and authored cue breaks", () =>
assert.equal(document.cueBreaks.length, 1);
});
+test("Caption styles one Role across non-contiguous authored Cues", () => {
+ const parsed = parseScript("caption-roles.svml", "<line><GUY>one || <GIRL>two || <GUY>three</line>");
+ const narrative = narrativeValue(parsed, "story") as unknown as Narrative;
+ const document = captionDocument(parsed, "story.caption", "story");
+ const plain = sealCaptionStyle({ id: "plain", rendering: { family: "test", parameters: canonicalize({}) } });
+ const guy = sealCaptionStyle({ id: "guy", rendering: { family: "test", parameters: canonicalize({}) } });
+ const program = resolveCaptionProgram(
+ document,
+ narrative,
+ "captions",
+ plain,
+ [{ id: "guy-role", unitIds: captionUnitsForRole(document, "GUY").unitIds, style: guy }],
+ );
+ assertCaptionProgramForDocument(program, document);
+ assert.deepEqual(program.runs.map((run) => run.styleId), ["guy", "plain", "guy"]);
+});
+
test("Caption keeps Selection styles and adds flat word-attribute styles separately", () => {
const parsed = parseScript("caption-attributes.svml", "<line>@focus really{emphasis} matters @/focus</line>");
const narrative = narrativeValue(parsed, "story") as unknown as Narrative;